From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Jiri Slaby <jslaby@suse.com>,
"Ivan T. Ivanov" <ivan.ivanov@linaro.org>,
Kees Cook <keescook@chromium.org>,
"Joel Fernandes (Google)" <joel@joelfernandes.org>,
Geliang Tang <geliangtang@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Pramod Gurav <gpramod@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Rajendra Nayak <rnayak@codeaurora.org>,
Vivek Gautam <vivek.gautam@codeaurora.org>,
Sibi Sankar <sibis@codeaurora.org>
Subject: Re: Crash in msm serial on dragonboard with ftrace bootargs
Date: Tue, 16 Oct 2018 22:05:23 +0530 [thread overview]
Message-ID: <8c2fb318-813d-81f1-1e2f-cdbc68353077@codeaurora.org> (raw)
In-Reply-To: <20181016112928.4b52afb5@gandalf.local.home>
On 10/16/2018 8:59 PM, Steven Rostedt wrote:
> On Tue, 16 Oct 2018 17:08:25 +0530
> Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> wrote:
>
>> Hi,
>>
>> On dragonboard 410c, with "ftrace=function" boot args, the console
>> output slows down and board resets without any backtrace as below. This
>> is tested on latest kernel and seems to exist even in older kernels as well.
>
> So this only happens when ftrace=function is on the boot console.
>
Yes. If I do not use boot console, target does not crash.
>
>>
>> [ 2.949164] EINJ: ACPI disabled.
>> [ 3.133001] Serial: 8250/16550 dri
>> Format: Log Type - Time(microsec) - Message - Optional Info
>> Log Type: B - Since Boot(Power On Reset), D - Delta, S - Statistic
>>
>> But with pstore enabled, able to get the below backtrace:
>>
>> <4>[ 2.949164] EINJ: ACPI disabled.
>> <6>[ 3.133001] Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled
>> <6>[ 3.164097] SuperH (H)SCI(F) driver initialized
>> <0>[ 3.164471] Internal error: synchronous external abort: 96000010
>> [#1] PREEMPT SMP
>> <4>[ 3.164479] Modules linked in:
>> <4>[ 3.164495] CPU: 2 PID: 1 Comm: swapper/0 Not tainted
>> 4.19.0-rc8-00008-ge033b9909fff-dirty #175
>> <4>[ 3.164501] Hardware name: Qualcomm Technologies, Inc. APQ 8016
>> SBC (DT)
>> <4>[ 3.164508] pstate: 40000085 (nZcv daIf -PAN -UAO)
>> <4>[ 3.164514] pc : msm_read.isra.2+0x20/0x50
>> <4>[ 3.164520] lr : msm_read.isra.2+0x1c/0x50
>> <4>[ 3.164526] sp : ffff000008033a50
>> <4>[ 3.164531] x29: ffff000008033a50 x28: ffff000009486018
>> <4>[ 3.164548] x27: 0000000000000001 x26: ffff7dfffe7ff070
>> <4>[ 3.164565] x25: 0000000000000034 x24: ffff000009486000
>> <4>[ 3.164582] x23: 0000000000000000 x22: ffff00000978e190
>> <4>[ 3.164599] x21: ffff0000095e8228 x20: 0000000000000034
>> <4>[ 3.164616] x19: ffff7dfffe7ff008 x18: ffffffffffffffff
>> <4>[ 3.164632] x17: 0000000000000000 x16: 0000000000000000
>> <4>[ 3.164649] x15: ffff0000094a96c8 x14: ffff00008978e6bf
>> <4>[ 3.164666] x13: ffff00000978e6cd x12: 0000000000000038
>> <4>[ 3.164683] x11: ffff0000094c6000 x10: 0000000000000c24
>> <4>[ 3.164699] x9 : ffff80003c89b400 x8 : ffff000008033970
>> <4>[ 3.164716] x7 : ffff80000eb04100 x6 : 00000000000af304
>> <4>[ 3.164732] x5 : 0000000000000c40 x4 : ffff80003c06f000
>> <4>[ 3.164750] x3 : ffff80003c89b498 x2 : 0000000000000000
>> <4>[ 3.164766] x1 : ffff80003ca68000 x0 : 0000000000000800
>> <0>[ 3.164785] Process swapper/0 (pid: 1, stack limit =
>> 0x(____ptrval____))
>> <4>[ 3.164791] Call trace:
>> <4>[ 3.164797] msm_read.isra.2+0x20/0x50
>> <4>[ 3.164804] msm_reset_dm_count+0x44/0x80
>> <4>[ 3.164810] __msm_console_write+0x1c8/0x1d0
>> <4>[ 3.164816] msm_serial_early_write_dm+0x3c/0x50
>> <4>[ 3.164823] console_unlock.part.6+0x468/0x528
>> <4>[ 3.164829] vprintk_emit+0x210/0x218
>> <4>[ 3.164835] vprintk_default+0x48/0x58
>> <4>[ 3.164841] vprintk_func+0xf0/0x1c0
>> <4>[ 3.164847] printk+0x74/0x94
>> <4>[ 3.164853] sci_init+0x24/0x3c
>> <4>[ 3.164859] do_one_initcall+0x54/0x248
>> <4>[ 3.164866] kernel_init_freeable+0x210/0x378
>> <4>[ 3.164872] kernel_init+0x18/0x118
>> <4>[ 3.164878] ret_from_fork+0x10/0x1c
>> <0>[ 3.164884] Code: aa1e03e0 8b214273 97e616f7 d503201f (b9400260)
>>
>> Seems to be issue with the msm serial driver and not ftrace.
>> Could someone look into it.
>
> I'm guessing that there may have been an issue with ftrace, it tried to
> print, but the printing caused a bug that rebooted the box.
>
> Does function tracing work after boot up? That is, without the
> ftrace=function, can you do:
>
> echo function > /sys/kernel/debug/tracing/current_tracer
>
> without any issue?
>
Yes ftrace in general works without any issue. I have also tested on
db820c and sdm845 where "ftrace=function" works fine. I am seeing this
issue only on db410c board.
>>
>> One more thing is for pstore dmesg-ramoops, I had to change
>> late_initcall to postcore_initcall which brings the question as to why
>> we changed to late_initcall?
>> Simple git blame shows to support crypto compress api, but is it really
>> helpful? A lot of boottime issues can be caught with pstore enabled at
>> postcore_initcall rather than late_initcall, this backtrace
>> is just one example. Is there any way we could change this?
>
> Does it break if the crypto is not initialized? Perhaps add a command
> line flag to have it happen earlier:
>
I didnt see any breakage, have been using ramoops with postcore_initcall
for sometime now.
> ramoops=earlyinit
>
> and add a postcore_initcall that checks if that flag is set, and if so,
> it does the work then, and the late_initcall() will do nothing.
>
> That way, you can still have unmodified kernels use pstore when it
> crashes at boot up.
>
Sounds good.
Thanks,
Sai
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2018-10-16 16:35 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 11:38 Crash in msm serial on dragonboard with ftrace bootargs Sai Prakash Ranjan
2018-10-16 11:44 ` Greg Kroah-Hartman
2018-10-16 11:58 ` Sai Prakash Ranjan
2018-10-16 15:29 ` Steven Rostedt
2018-10-16 16:35 ` Sai Prakash Ranjan [this message]
2018-10-16 16:57 ` Steven Rostedt
2018-10-16 17:36 ` Sai Prakash Ranjan
2018-10-16 17:48 ` Steven Rostedt
2018-10-16 18:05 ` Sai Prakash Ranjan
2018-10-16 18:16 ` Steven Rostedt
2018-10-16 18:25 ` Sai Prakash Ranjan
2018-10-16 18:41 ` Steven Rostedt
2018-10-16 19:01 ` Sai Prakash Ranjan
2018-10-16 19:03 ` Steven Rostedt
2018-10-16 19:06 ` Sai Prakash Ranjan
2018-10-16 19:15 ` Steven Rostedt
2018-10-16 19:16 ` Steven Rostedt
2018-10-16 19:37 ` Sai Prakash Ranjan
2018-10-16 19:35 ` Sai Prakash Ranjan
2018-10-16 20:51 ` Stephen Boyd
2018-10-17 11:27 ` Sai Prakash Ranjan
2018-10-18 2:33 ` Steven Rostedt
2018-10-18 5:21 ` Sai Prakash Ranjan
2018-10-18 13:17 ` Steven Rostedt
2018-10-19 4:17 ` Joel Fernandes
2018-10-19 6:54 ` Sai Prakash Ranjan
2018-10-19 13:51 ` Steven Rostedt
2018-10-19 14:48 ` Sai Prakash Ranjan
2018-10-19 15:12 ` Steven Rostedt
2018-10-25 14:36 ` saiprakash.ranjan
2018-11-13 9:44 ` Srinivas Kandagatla
2018-11-15 10:33 ` Sai Prakash Ranjan
2018-11-15 10:53 ` Srinivas Kandagatla
2018-11-16 3:39 ` Viresh Kumar
2018-11-16 10:49 ` Sai Prakash Ranjan
2018-10-16 17:02 ` Kees Cook
2018-10-17 10:13 ` Joel Fernandes
2018-10-17 11:38 ` Sai Prakash Ranjan
2018-10-17 14:49 ` Sai Prakash Ranjan
2018-10-17 17:56 ` Joel Fernandes
2018-10-17 18:25 ` Kees Cook
2018-10-16 23:09 ` Joel Fernandes
2018-10-17 11:53 ` Sai Prakash Ranjan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c2fb318-813d-81f1-1e2f-cdbc68353077@codeaurora.org \
--to=saiprakash.ranjan@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=geliangtang@gmail.com \
--cc=gpramod@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ivan.ivanov@linaro.org \
--cc=joel@joelfernandes.org \
--cc=jslaby@suse.com \
--cc=keescook@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=rnayak@codeaurora.org \
--cc=rostedt@goodmis.org \
--cc=sboyd@kernel.org \
--cc=sibis@codeaurora.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).