From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Randy Dunlap <rdunlap@infradead.org>,
linux-aspeed@lists.ozlabs.org, devicetree@vger.kernel.org,
Vernon Mauery <vernon.mauery@linux.intel.com>,
Frederic Barrat <fbarrat@linux.vnet.ibm.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Jason M Biils <jason.m.bills@linux.intel.com>,
Eric Sandeen <sandeen@redhat.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Jonathan Corbet <corbet@lwn.net>,
openbmc@lists.ozlabs.org, linux-doc@vger.kernel.org,
Kishon Vijay Abraham I <kishon@ti.com>,
"Bryant G . Ly" <bryantly@linux.vnet.ibm.com>,
Uwe Kleine-Konig <u.kleine-koenig@pengutronix.de>,
David Kershner <david.kershner@unisys.com>,
Guenter Roeck <linux@roeck-us.net>, Wu Hao <hao.wu@intel.com>,
linux-hwmon@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
Arnd Bergmann <arnd@arndb.de>,
Philippe Ombredanne <pombredanne@nexb.com>,
Johan Hovold <johan@kernel.org>,
Tomohiro Kusumi <kusumi.tomohiro@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Sagar Dharia <sdharia@codeaurora.org>,
linux-arm-kernel@lists.infradead.org,
Juergen Gross <jgross@suse.com>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
Andrew Jeffery <andrew@aj.id.au>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org, Vinod Koul <vkoul@kernel.org>,
James Feist <james.feist@linux.intel.com>,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Andrew Morton <akpm@linux-foundation.org>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH v8 07/12] dt-bindings: mfd: Add a document for PECI client MFD
Date: Wed, 24 Oct 2018 09:39:51 -0700 [thread overview]
Message-ID: <8c322777-7c35-1c2a-730f-f8de86522b96@linux.intel.com> (raw)
In-Reply-To: <20181024072540.GA4939@dell>
Hi Lee,
On 10/24/2018 12:25 AM, Lee Jones wrote:
> On Tue, 18 Sep 2018, Jae Hyun Yoo wrote:
>
>> +Required properties:
>> +- compatible : Should be "intel,peci-client".
>> +- reg : Should contain address of a client CPU. Address range of CPU
>> + clients starts from 0x30 based on PECI specification.
>
> Nit: "start"
>
> Would be better worded:
>
> "According to the PECI specification client addresses start from 0x30."
>
Yes, that would be better. Will fix it like you suggested.
Thanks for the review!
Jae
next prev parent reply other threads:[~2018-10-24 16:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 21:51 [PATCH v8 00/12] PECI device driver introduction Jae Hyun Yoo
2018-09-18 21:51 ` [PATCH v8 01/12] dt-bindings: Add a document of PECI subsystem Jae Hyun Yoo
2018-09-27 15:10 ` Rob Herring
2018-09-27 16:27 ` Jae Hyun Yoo
2018-09-18 21:51 ` [PATCH v8 02/12] Documentation: ioctl: Add ioctl numbers for " Jae Hyun Yoo
2018-09-18 21:51 ` [PATCH v8 03/12] peci: Add support for PECI bus driver core Jae Hyun Yoo
2018-09-18 21:51 ` [PATCH v8 04/12] dt-bindings: Add a document of PECI adapter driver for ASPEED AST24xx/25xx SoCs Jae Hyun Yoo
2018-09-18 21:51 ` [PATCH v8 05/12] ARM: dts: aspeed: peci: Add PECI node Jae Hyun Yoo
2018-09-18 21:51 ` [PATCH v8 06/12] peci: Add a PECI adapter driver for Aspeed AST24xx/AST25xx Jae Hyun Yoo
2018-09-18 21:51 ` [PATCH v8 07/12] dt-bindings: mfd: Add a document for PECI client MFD Jae Hyun Yoo
2018-09-27 15:15 ` Rob Herring
2018-09-27 16:28 ` Jae Hyun Yoo
2018-10-24 7:25 ` Lee Jones
2018-10-24 16:39 ` Jae Hyun Yoo [this message]
2018-09-18 21:51 ` [PATCH v8 08/12] mfd: intel-peci-client: Add PECI client MFD driver Jae Hyun Yoo
2018-10-24 10:59 ` Lee Jones
2018-10-24 21:10 ` Jae Hyun Yoo
2018-10-25 5:30 ` Lee Jones
2018-10-25 16:16 ` Jae Hyun Yoo
2018-09-18 21:51 ` [PATCH v8 09/12] Documentation: hwmon: Add documents for PECI hwmon client drivers Jae Hyun Yoo
2018-09-18 21:51 ` [PATCH v8 10/12] hwmon: Add PECI cputemp driver Jae Hyun Yoo
2018-09-18 21:51 ` [PATCH v8 11/12] hwmon: Add PECI dimmtemp driver Jae Hyun Yoo
2018-09-18 21:51 ` [PATCH v8 12/12] Add maintainers for the PECI subsystem Jae Hyun Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c322777-7c35-1c2a-730f-f8de86522b96@linux.intel.com \
--to=jae.hyun.yoo@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andrew@aj.id.au \
--cc=arnd@arndb.de \
--cc=bryantly@linux.vnet.ibm.com \
--cc=corbet@lwn.net \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=darrick.wong@oracle.com \
--cc=davem@davemloft.net \
--cc=david.kershner@unisys.com \
--cc=devicetree@vger.kernel.org \
--cc=fbarrat@linux.vnet.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=hao.wu@intel.com \
--cc=james.feist@linux.intel.com \
--cc=jason.m.bills@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=jgross@suse.com \
--cc=johan@kernel.org \
--cc=kishon@ti.com \
--cc=kusumi.tomohiro@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=pombredanne@nexb.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=sandeen@redhat.com \
--cc=sboyd@codeaurora.org \
--cc=sdharia@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vernon.mauery@linux.intel.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).