From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755240AbcFQIxl (ORCPT ); Fri, 17 Jun 2016 04:53:41 -0400 Received: from mx2.suse.de ([195.135.220.15]:35558 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752337AbcFQIxj (ORCPT ); Fri, 17 Jun 2016 04:53:39 -0400 Subject: Re: [PATCH 20/27] mm, vmscan: Update classzone_idx if buffer_heads_over_limit To: Mel Gorman , Andrew Morton , Linux-MM References: <1465495483-11855-1-git-send-email-mgorman@techsingularity.net> <1465495483-11855-21-git-send-email-mgorman@techsingularity.net> Cc: Rik van Riel , Johannes Weiner , LKML From: Vlastimil Babka Message-ID: <8e47f6d8-ec2f-fc2d-ccf1-c32baec92110@suse.cz> Date: Fri, 17 Jun 2016 10:53:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1465495483-11855-21-git-send-email-mgorman@techsingularity.net> Content-Type: text/plain; charset=iso-8859-2; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/09/2016 08:04 PM, Mel Gorman wrote: > If buffer heads are over the limit then the direct reclaim gfp_mask > is promoted to __GFP_HIGHMEM so that lowmem is indirectly freed. With > node-based reclaim, it is also required that the classzone_idx be updated > or the pages will be skipped. > > Signed-off-by: Mel Gorman Acked-by: Vlastimil Babka > --- > mm/vmscan.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 3edf941e9965..7a2d69612231 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -2547,8 +2547,10 @@ static void shrink_zones(struct zonelist *zonelist, struct scan_control *sc, > * highmem pages could be pinning lowmem pages storing buffer_heads > */ > orig_mask = sc->gfp_mask; > - if (buffer_heads_over_limit) > + if (buffer_heads_over_limit) { > sc->gfp_mask |= __GFP_HIGHMEM; > + classzone_idx = gfp_zone(sc->gfp_mask); > + } > > for_each_zone_zonelist_nodemask(zone, z, zonelist, > gfp_zone(sc->gfp_mask), sc->nodemask) { >