From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: afzal mohammed <afzal.mohd.ma@gmail.com>
Cc: kbuild test robot <lkp@intel.com>,
kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clocksource/drivers/timer-vf-pit: Fix build error
Date: Mon, 23 Mar 2020 11:02:05 +0100 [thread overview]
Message-ID: <8e5a2afc-4b5d-9e37-d529-42773d5af007@linaro.org> (raw)
In-Reply-To: <20200323061130.GA6286@afzalpc>
On 23/03/2020 07:11, afzal mohammed wrote:
> Recently all usages of setup_irq() was replaced by request_irq(). The
> replacement in timer-vf-pit.c missed closing parentheses resulting in
> build error (vf610m4_defconfig). Fix it.
>
> Fixes: cc2550b421aa ("clocksource: Replace setup_irq() by request_irq()")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
> ---
> drivers/clocksource/timer-vf-pit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/timer-vf-pit.c b/drivers/clocksource/timer-vf-pit.c
> index 7ad4a8b008c2..1a86a4e7e344 100644
> --- a/drivers/clocksource/timer-vf-pit.c
> +++ b/drivers/clocksource/timer-vf-pit.c
> @@ -129,7 +129,7 @@ static int __init pit_clockevent_init(unsigned long rate, int irq)
> __raw_writel(PITTFLG_TIF, clkevt_base + PITTFLG);
>
> BUG_ON(request_irq(irq, pit_timer_interrupt, IRQF_TIMER | IRQF_IRQPOLL,
> - "VF pit timer", &clockevent_pit);
> + "VF pit timer", &clockevent_pit));
Applied
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2020-03-23 10:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202003230153.VzOyvdbR%lkp@intel.com>
2020-03-23 6:11 ` [PATCH] clocksource/drivers/timer-vf-pit: Fix build error afzal mohammed
2020-03-23 10:02 ` Daniel Lezcano [this message]
2020-03-31 11:40 ` Daniel Lezcano
2020-04-05 5:38 ` afzal mohammed
2020-04-05 7:32 ` [tip: timers/urgent] clocksource/drivers/timer-vf-pit: Add missing parenthesis tip-bot2 for afzal mohammed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e5a2afc-4b5d-9e37-d529-42773d5af007@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=afzal.mohd.ma@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).