From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36465C433F5 for ; Wed, 2 Mar 2022 13:20:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242121AbiCBNUq (ORCPT ); Wed, 2 Mar 2022 08:20:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236810AbiCBNUo (ORCPT ); Wed, 2 Mar 2022 08:20:44 -0500 Received: from relay-us1.mymailcheap.com (relay-us1.mymailcheap.com [51.81.35.219]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1870454BF4 for ; Wed, 2 Mar 2022 05:19:59 -0800 (PST) Received: from relay5.mymailcheap.com (relay5.mymailcheap.com [159.100.241.64]) by relay-us1.mymailcheap.com (Postfix) with ESMTPS id DC07B202B1; Wed, 2 Mar 2022 13:19:58 +0000 (UTC) Received: from relay2.mymailcheap.com (relay2.mymailcheap.com [217.182.66.162]) by relay5.mymailcheap.com (Postfix) with ESMTPS id 233DC206D5; Wed, 2 Mar 2022 13:19:55 +0000 (UTC) Received: from filter2.mymailcheap.com (filter2.mymailcheap.com [91.134.140.82]) by relay2.mymailcheap.com (Postfix) with ESMTPS id E44BB3EDEC; Wed, 2 Mar 2022 14:19:52 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by filter2.mymailcheap.com (Postfix) with ESMTP id C0C002A7F2; Wed, 2 Mar 2022 13:19:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at filter2.mymailcheap.com Received: from filter2.mymailcheap.com ([127.0.0.1]) by localhost (filter2.mymailcheap.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c2EAhZFMfF6P; Wed, 2 Mar 2022 13:19:51 +0000 (UTC) Received: from mail20.mymailcheap.com (mail20.mymailcheap.com [51.83.111.147]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by filter2.mymailcheap.com (Postfix) with ESMTPS; Wed, 2 Mar 2022 13:19:51 +0000 (UTC) Received: from edelgard.icenowy.info (unknown [59.41.161.219]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail20.mymailcheap.com (Postfix) with ESMTPSA id 7A374405B8; Wed, 2 Mar 2022 13:19:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=aosc.io; s=default; t=1646227190; bh=uzuQhPYukEVDmR2T7XfgnVMsGzP7uCq9kYtRfCYK73Q=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=LOD+Fb/gOaASgF++PlmHiielHuGbCtQw1g4Dqxxhi7hO68es+wD1LaPtUrB5j+3S4 eISTyc+joHHq2mTvZLPaxlFWirq/dY63o0UTiHIG3e/t6Uu6Nkz7tZA5wd+P/XORQr J81yAxPAptCz1T1GmyexXXogRgKfODxbva7rSZNk= Message-ID: <8e799cadb1104714f998fe74e40b3cb052c9c1ed.camel@aosc.io> Subject: Re: [PATCH v2] parport_pc: Also enable driver for PCI systems From: Icenowy Zheng To: "Maciej W. Rozycki" , Sudip Mukherjee Cc: Catalin Marinas , Will Deacon , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Alexander Gordeev , Sven Schnelle , Jeff Dike , Richard Weinberger , Anton Ivanov , Chris Zankel , Max Filippov , linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, linux-kernel@vger.kernel.org Date: Wed, 02 Mar 2022 21:19:37 +0800 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2022-02-14星期一的 20:16 +0000，Maciej W. Rozycki写道： > Nowadays PC-style parallel ports come in the form of PCI and PCIe > option > cards and there are some combined parallel/serial option cards as > well > that we handle in the parport subsystem.  There is nothing in > particular > that would prevent them from being used in any system equipped with > PCI > or PCIe connectivity, except that we do not permit the PARPORT_PC > config > option to be selected for platforms for which > ARCH_MIGHT_HAVE_PC_PARPORT > has not been set for. > > The only PCI platforms that actually can't make use of PC-style > parallel > port hardware are those newer PCIe systems that have no support for > I/O > cycles in the host bridge, required by such parallel ports.  Notably, > this includes the s390 arch, which has port I/O accessors that cause > compilation warnings (promoted to errors with `-Werror'), and there > are > other cases such as the POWER9 PHB4 device, though this one has > variable > port I/O accessors that depend on the particular system.  Also it is > not > clear whether the serial port side of devices enabled by > PARPORT_SERIAL > uses port I/O or MMIO.  Finally Super I/O solutions are always either > ISA or platform devices. Just spot this patch in linux-riscv mailing list, I think there's a pending patchset that tries to add a HAS_IOPORT Kconfig option, which can be used in this situation. > > Make the PARPORT_PC option selectable also for PCI systems then, > except > for the s390 arch, however limit the availability of > PARPORT_PC_SUPERIO > to platforms that enable ARCH_MIGHT_HAVE_PC_PARPORT.  Update > platforms > accordingly for the required header. > > Signed-off-by: Maciej W. Rozycki > --- > Hi, > >  I have verified this lightly by booting a kernel with PARPORT_PC and > PARPORT_SERIAL enabled on a RISC-V HiFive Unmatched system.  While I > do > have a PCIe parallel port option available that I could use with my > RISC-V > machine (based on the OxSemi OXPCIe952 chip) it is currently plugged > in > the wrong system, and both machines are in my remote lab I have > currently > no visit scheduled to in the near future.  For the record the device > reports as: > > PCI parallel port detected: 1415:c118, I/O at 0x1000(0x1008), IRQ 18 > parport1: PC-style at 0x1000 (0x1008), irq 18, using FIFO > [PCSPP,TRISTATE,COMPAT,EPP,ECP] > > in the other system.  I'll see if I can verify it with the Unmatched > at > the next opportunity, though it seems like an overkill to me given > that a > PC-style parallel port is a generic PCIe device.  The OXPCIe952 > implements > a multifunction device, so it doesn't rely on PARPORT_SERIAL. > >  NB platforms to be updated for generation were > chosen by > the presence of the HAVE_PCI or FORCE_PCI option from ones that do > not > already have or generate that header, except for s390, now excluded.  > Let > me know if I got anything wrong here. > >   Maciej > > Changes from v1: > > - Exclude s390 systems, update the change description accordingly. > --- >  arch/arm64/include/asm/Kbuild  |    1 + >  arch/csky/include/asm/Kbuild   |    1 + >  arch/riscv/include/asm/Kbuild  |    1 + >  arch/um/include/asm/Kbuild     |    1 + >  arch/xtensa/include/asm/Kbuild |    1 + >  drivers/parport/Kconfig        |    4 ++-- >  6 files changed, 7 insertions(+), 2 deletions(-) > > linux-parport-pc-pci.diff > Index: linux-macro/arch/arm64/include/asm/Kbuild > =================================================================== > --- linux-macro.orig/arch/arm64/include/asm/Kbuild > +++ linux-macro/arch/arm64/include/asm/Kbuild > @@ -3,6 +3,7 @@ generic-y += early_ioremap.h >  generic-y += mcs_spinlock.h >  generic-y += qrwlock.h >  generic-y += qspinlock.h > +generic-y += parport.h >  generic-y += user.h >   >  generated-y += cpucaps.h > Index: linux-macro/arch/csky/include/asm/Kbuild > =================================================================== > --- linux-macro.orig/arch/csky/include/asm/Kbuild > +++ linux-macro/arch/csky/include/asm/Kbuild > @@ -4,5 +4,6 @@ generic-y += extable.h >  generic-y += gpio.h >  generic-y += kvm_para.h >  generic-y += qrwlock.h > +generic-y += parport.h >  generic-y += user.h >  generic-y += vmlinux.lds.h > Index: linux-macro/arch/riscv/include/asm/Kbuild > =================================================================== > --- linux-macro.orig/arch/riscv/include/asm/Kbuild > +++ linux-macro/arch/riscv/include/asm/Kbuild > @@ -2,5 +2,6 @@ >  generic-y += early_ioremap.h >  generic-y += flat.h >  generic-y += kvm_para.h > +generic-y += parport.h >  generic-y += user.h >  generic-y += vmlinux.lds.h > Index: linux-macro/arch/um/include/asm/Kbuild > =================================================================== > --- linux-macro.orig/arch/um/include/asm/Kbuild > +++ linux-macro/arch/um/include/asm/Kbuild > @@ -17,6 +17,7 @@ generic-y += mcs_spinlock.h >  generic-y += mmiowb.h >  generic-y += module.lds.h >  generic-y += param.h > +generic-y += parport.h >  generic-y += percpu.h >  generic-y += preempt.h >  generic-y += softirq_stack.h > Index: linux-macro/arch/xtensa/include/asm/Kbuild > =================================================================== > --- linux-macro.orig/arch/xtensa/include/asm/Kbuild > +++ linux-macro/arch/xtensa/include/asm/Kbuild > @@ -4,6 +4,7 @@ generic-y += extable.h >  generic-y += kvm_para.h >  generic-y += mcs_spinlock.h >  generic-y += param.h > +generic-y += parport.h >  generic-y += qrwlock.h >  generic-y += qspinlock.h >  generic-y += user.h > Index: linux-macro/drivers/parport/Kconfig > =================================================================== > --- linux-macro.orig/drivers/parport/Kconfig > +++ linux-macro/drivers/parport/Kconfig > @@ -42,7 +42,7 @@ if PARPORT >   >  config PARPORT_PC >         tristate "PC-style hardware" > -       depends on ARCH_MIGHT_HAVE_PC_PARPORT > +       depends on ARCH_MIGHT_HAVE_PC_PARPORT || (PCI && !S390) >         help >           You should say Y here if you have a PC-style parallel port. > All >           IBM PC compatible computers and some Alphas have PC-style > @@ -77,7 +77,7 @@ config PARPORT_PC_FIFO >   >  config PARPORT_PC_SUPERIO >         bool "SuperIO chipset support" > -       depends on PARPORT_PC && !PARISC > +       depends on ARCH_MIGHT_HAVE_PC_PARPORT && PARPORT_PC && > !PARISC >         help >           Saying Y here enables some probes for Super-IO chipsets in > order to >           find out things like base addresses, IRQ lines and DMA > channels.  It > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv