From: Florian Fainelli <f.fainelli@gmail.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
Guenter Roeck <linux@roeck-us.net>
Cc: "Naresh Kamboju" <naresh.kamboju@linaro.org>,
"Álvaro Fernández Rojas" <noltari@gmail.com>,
linux-mips@vger.kernel.org, tsbogend@alpha.franken.de,
bcm-kernel-feedback-list@broadcom.com,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
jonas.gorski@gmail.com,
"Linus Walleij" <linus.walleij@linaro.org>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"open list" <linux-kernel@vger.kernel.org>,
linux-mtd@lists.infradead.org, lkft-triage@lists.linaro.org
Subject: Re: [PATCH v4] mtd: parsers: bcm63xx: simplify CFE detection
Date: Mon, 28 Sep 2020 12:35:08 -0700 [thread overview]
Message-ID: <8f25c3c8-f2c6-73a9-a9f5-cf244c53754a@gmail.com> (raw)
In-Reply-To: <20200928161617.2a1b2244@xps13>
On 9/28/2020 7:16 AM, Miquel Raynal wrote:
> Hello,
>
> Guenter Roeck <linux@roeck-us.net> wrote on Mon, 21 Sep 2020 20:26:19
> -0700:
>
>> On 9/21/20 8:18 PM, Naresh Kamboju wrote:
>>> On Fri, 14 Aug 2020 at 14:26, Guenter Roeck <linux@roeck-us.net> wrote:
>>>>
>>>> On Mon, Jun 15, 2020 at 11:17:40AM +0200, Álvaro Fernández Rojas wrote:
>>>>> Instead of trying to parse CFE version string, which is customized by some
>>>>> vendors, let's just check that "CFE1" was passed on argument 3.
>>>>>
>>>>> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
>>>>> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
>>>>> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>>>>
>>>
>>> We still see mips: allmodconfig build failure on Linus tree
>>>
>>
>> Yes, same here.
>
> Perhaps this check should be done by an exported helper so that we do
> not blindly export the variable?
>
> Alvaro, Jonas, can one of you try to address this issue please?
We should probably just make the parser 'bool' there is no much point
building this as a module, it will not improve compile time coverage,
and it will most likely not help with the kernel image size on the
platforms that require the parser to be there anyway.
--
Florian
next prev parent reply other threads:[~2020-09-28 19:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 9:40 [PATCH 0/2] mtd: parsers: bcm63xx: simplify CFE detection Álvaro Fernández Rojas
2020-06-08 9:40 ` [PATCH 1/2] MIPS: BCM63xx: add helper function to detect CFE Álvaro Fernández Rojas
2020-06-08 9:40 ` [PATCH 2/2] mtd: parsers: bcm63xx: simplify CFE detection Álvaro Fernández Rojas
2020-06-08 16:06 ` [PATCH v2] " Álvaro Fernández Rojas
2020-06-11 7:55 ` Miquel Raynal
2020-06-11 15:16 ` Álvaro Fernández Rojas
2020-06-11 15:42 ` Florian Fainelli
2020-06-11 15:46 ` Miquel Raynal
2020-06-11 16:14 ` Álvaro Fernández Rojas
2020-06-12 7:02 ` Miquel Raynal
2020-06-12 7:30 ` Álvaro Fernández Rojas
2020-06-12 7:33 ` Miquel Raynal
2020-06-12 7:37 ` Álvaro Fernández Rojas
2020-06-12 7:35 ` [PATCH v3] " Álvaro Fernández Rojas
2020-06-15 8:54 ` Miquel Raynal
2020-06-15 9:17 ` [PATCH v4] " Álvaro Fernández Rojas
2020-06-15 16:30 ` Florian Fainelli
2020-06-15 17:38 ` Miquel Raynal
2020-08-14 8:56 ` Guenter Roeck
2020-09-22 3:18 ` Naresh Kamboju
2020-09-22 3:26 ` Guenter Roeck
2020-09-28 14:16 ` Miquel Raynal
2020-09-28 19:35 ` Florian Fainelli [this message]
2020-09-29 17:27 ` [PATCH] mtd: parsers: bcm63xx: Do not make it modular Florian Fainelli
2020-10-02 7:15 ` Miquel Raynal
2020-10-11 14:14 ` Guenter Roeck
2020-10-12 7:04 ` Miquel Raynal
2020-10-12 13:24 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f25c3c8-f2c6-73a9-a9f5-cf244c53754a@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=jonas.gorski@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=lkft-triage@lists.linaro.org \
--cc=miquel.raynal@bootlin.com \
--cc=naresh.kamboju@linaro.org \
--cc=noltari@gmail.com \
--cc=richard@nod.at \
--cc=tsbogend@alpha.franken.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).