From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>,
Olivier Langlois <olivier@trillion01.com>,
io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] io_uring: Create define to modify a SQPOLL parameter
Date: Thu, 24 Jun 2021 00:39:42 +0100 [thread overview]
Message-ID: <8f4c6fad-ff01-4b3a-a0d8-06717af5095c@gmail.com> (raw)
In-Reply-To: <6a566122-c4b2-6594-cc94-c578988d3f80@kernel.dk>
On 6/23/21 11:24 PM, Jens Axboe wrote:
> On 6/23/21 4:14 PM, Pavel Begunkov wrote:
>> On 6/23/21 7:50 PM, Olivier Langlois wrote:
>>> The magic number used to cap the number of entries extracted from an
>>> io_uring instance SQ before moving to the other instances is an
>>> interesting parameter to experiment with.
>>>
>>> A define has been created to make it easy to change its value from a
>>> single location.
>>
>> It's better to send fixes separately from other improvements,
>> because the process a bit different for them, go into different
>> branches and so on.
>
> It's not a huge problem even if they go to different branches,
> for these I'd be more comfortable doing 5.14 anyway and that
> makes it even less of a concern.
Ok, good to know. I was finding splitting more convenient
as a default option, easier with b4, more confidence that
they apply to the right branch and so on
--
Pavel Begunkov
next prev parent reply other threads:[~2021-06-23 23:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 18:50 [PATCH v2 0/2] Minor SQPOLL thread fix and improvement Olivier Langlois
2021-06-23 18:50 ` [PATCH v2 1/2] io_uring: Fix race condition when sqp thread goes to sleep Olivier Langlois
2021-06-23 22:02 ` Pavel Begunkov
2021-06-23 18:50 ` [PATCH v2 2/2] io_uring: Create define to modify a SQPOLL parameter Olivier Langlois
2021-06-23 22:14 ` Pavel Begunkov
2021-06-23 22:24 ` Jens Axboe
2021-06-23 23:39 ` Pavel Begunkov [this message]
2021-06-23 22:24 ` [PATCH v2 0/2] Minor SQPOLL thread fix and improvement Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f4c6fad-ff01-4b3a-a0d8-06717af5095c@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olivier@trillion01.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).