From: Shuah Khan <skhan@linuxfoundation.org>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Shuah Khan <shuah@kernel.org>, Andy Lutomirski <luto@kernel.org>,
Jethro Beekman <jethro@fortanix.com>,
Borislav Petkov <bp@suse.de>,
"open list:INTEL SGX" <linux-sgx@vger.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
David.Laight@ACULAB.COM
Cc: kernel@collabora.com, kernelci@groups.io,
"kernelci.org bot" <bot@kernelci.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH V2 1/2] selftests: x86: add validity check and allow field splitting
Date: Mon, 14 Feb 2022 13:59:42 -0700 [thread overview]
Message-ID: <8f62537f-e191-1d60-530a-9eb9c31b0511@linuxfoundation.org> (raw)
In-Reply-To: <20220214184109.3739179-2-usama.anjum@collabora.com>
On 2/14/22 11:41 AM, Muhammad Usama Anjum wrote:
> Add check to test if CC has a string. CC can have multiple sub-strings
> like "ccache gcc". Erorr pops up if it is treated as single string and
> double quotes are used around it. This can be fixed by removing the
> quotes and not treating CC as a single string.
>
> Fixes: e9886ace222e ("selftests, x86: Rework x86 target architecture detection")
> Reported-by: "kernelci.org bot" <bot@kernelci.org>
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> Changes in V2:
> Update if condition to check if CC has a string
> ---
> tools/testing/selftests/x86/check_cc.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/x86/check_cc.sh b/tools/testing/selftests/x86/check_cc.sh
> index 3e2089c8cf549..8c669c0d662ee 100755
> --- a/tools/testing/selftests/x86/check_cc.sh
> +++ b/tools/testing/selftests/x86/check_cc.sh
> @@ -7,7 +7,7 @@ CC="$1"
> TESTPROG="$2"
> shift 2
>
> -if "$CC" -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then
> +if [ -n "$CC" ] && $CC -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then
> echo 1
> else
> echo 0
>
Looks good to me.
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
next prev parent reply other threads:[~2022-02-14 20:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 18:41 [PATCH V2 0/2] selftests: sgx: Fix build of test_sgx Muhammad Usama Anjum
2022-02-14 18:41 ` [PATCH V2 1/2] selftests: x86: add validity check and allow field splitting Muhammad Usama Anjum
2022-02-14 20:59 ` Shuah Khan [this message]
2022-02-17 20:03 ` [tip: x86/sgx] selftests/x86: Add " tip-bot2 for Muhammad Usama Anjum
2022-02-14 18:41 ` [PATCH V2 2/2] selftests: sgx: Treat CC as one argument Muhammad Usama Anjum
2022-02-14 21:00 ` Shuah Khan
2022-02-17 20:03 ` [tip: x86/sgx] selftests/sgx: " tip-bot2 for Muhammad Usama Anjum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f62537f-e191-1d60-530a-9eb9c31b0511@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=David.Laight@ACULAB.COM \
--cc=bot@kernelci.org \
--cc=bp@suse.de \
--cc=dave.hansen@linux.intel.com \
--cc=jarkko@kernel.org \
--cc=jethro@fortanix.com \
--cc=kernel@collabora.com \
--cc=kernelci@groups.io \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=luto@kernel.org \
--cc=shuah@kernel.org \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).