From: Randy Dunlap <rdunlap@infradead.org>
To: Nayna <nayna@linux.vnet.ibm.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-integrity@vger.kernel.org, Mimi Zohar <zohar@linux.ibm.com>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
Masahiro Yamada <masahiroy@kernel.org>
Subject: Re: linux-next: Tree for Apr 16 (IMA appraise causing build error)
Date: Fri, 16 Apr 2021 13:32:15 -0700 [thread overview]
Message-ID: <8fbd9822-bc70-f103-ace9-22733b8475e5@infradead.org> (raw)
In-Reply-To: <3b06deaa-2ec1-88cd-87aa-970b9fa4315a@linux.vnet.ibm.com>
Hi,
On 4/16/21 1:25 PM, Nayna wrote:
>
> On 4/16/21 2:53 PM, Randy Dunlap wrote:
>> On 4/16/21 4:36 AM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20210415:
>>>
>> I noticed this build error message (on an i386 build):
>>
>> ../certs/Makefile:52: *** Could not determine digest type to use from kernel config. Stop.
>>
>> and when I was checking on why it happened, I noticed that
>> # CONFIG_MODULES is not set
>>
>> and hence
>> ifndef CONFIG_MODULE_SIG_HASH
>> $(error Could not determine digest type to use from kernel config)
>> endif
>>
>> CONFIG_MODULE_SIG_HASH is not set/enabled/defined.
>>
>> However, the .config file does have
>> CONFIG_IMA_APPRAISE=y
>> # CONFIG_IMA_ARCH_POLICY is not set
>> # CONFIG_IMA_APPRAISE_BUILD_POLICY is not set
>> CONFIG_IMA_APPRAISE_BOOTPARAM=y
>> CONFIG_IMA_APPRAISE_MODSIG=y
>>
>> as well as
>> CONFIG_MODULE_SIG_FORMAT=y
>>
>> due to a "select" by IMA_APPRAISE_MODSIG.
>> (although I see that MODULE_SIG_FORMAT does not depend on MODULES)
>>
>>
>> Is there anything that you can do (or recommend) to prevent
>> the build error?
>>
>>
>>
>> BTW, it looks like this:
>> config IMA_APPRAISE_REQUIRE_MODULE_SIGS
>> bool "Appraise kernel modules signatures"
>> depends on IMA_APPRAISE_BUILD_POLICY
>>
>> could also depend on MODULES.
>>
>>
>>
>> Full i386 randconfig file is attached.
>
>
> With the new patchset "ima: kernel build support for loading the kernel module signing key", there shouldn't be a difference when generating the config file between MODULE_SIG and IMA_APPRAISE_MODSIG. Both prompt for the hash algorithm.
That patchset appears to be included in today's linux-next 2021-04-16.
> Can you please explain how you generate randconfig? Do you use make xconfig?
with the 'make randconfig' command.
--
~Randy
prev parent reply other threads:[~2021-04-16 20:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 11:36 linux-next: Tree for Apr 16 Stephen Rothwell
2021-04-16 17:50 ` linux-next: Tree for Apr 16 (objtool: warnings) Randy Dunlap
2021-06-21 13:34 ` Peter Zijlstra
2021-06-21 14:23 ` Peter Zijlstra
2021-06-21 17:53 ` [tip: objtool/urgent] objtool/x86: Ignore __x86_indirect_alt_* symbols tip-bot2 for Peter Zijlstra
2021-06-21 23:30 ` linux-next: Tree for Apr 16 (objtool: warnings) Randy Dunlap
2021-04-16 18:53 ` linux-next: Tree for Apr 16 (IMA appraise causing build error) Randy Dunlap
2021-04-16 20:25 ` Nayna
2021-04-16 20:32 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fbd9822-bc70-f103-ace9-22733b8475e5@infradead.org \
--to=rdunlap@infradead.org \
--cc=dmitry.kasatkin@gmail.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nayna@linux.vnet.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).