From: Leonardo Bras <leonardo@linux.ibm.com>
To: John Hubbard <jhubbard@nvidia.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Linux-MM <linux-mm@kvack.org>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
Thomas Gleixner <tglx@linutronix.de>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
YueHaibing <yuehaibing@huawei.com>,
Keith Busch <keith.busch@intel.com>,
Nicholas Piggin <npiggin@gmail.com>,
Mike Rapoport <rppt@linux.ibm.com>,
Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>,
Richard Fontana <rfontana@redhat.com>,
Paul Mackerras <paulus@samba.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Ganesh Goudar <ganeshgr@linux.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ira Weiny <ira.weiny@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Allison Randal <allison@lohutok.net>
Subject: Re: [PATCH v2 03/11] mm/gup: Applies counting method to monitor gup_pgd_range
Date: Mon, 23 Sep 2019 18:01:54 -0300 [thread overview]
Message-ID: <907304d0599684b3caa6773197fd40e09191b48e.camel@linux.ibm.com> (raw)
In-Reply-To: <2e060677-eadf-c32e-d8c5-8e22c8ca118e@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 837 bytes --]
On Mon, 2019-09-23 at 13:27 -0700, John Hubbard wrote:
> I'd also like a second opinion from the "core" -mm maintainers, but it seems like
> there is now too much code around the gup_pgd_range() call. Especially since there
> are two places where it's called--did you forget the other one in
> __get_user_pages_fast(), btw??
>
Oh, sorry, I missed this one. I will put it on v3.
(Also I will make sure to include linux-mm on v3.)
> Maybe the irq handling and atomic counting should be moved into start/finish
> calls, like this:
>
> start_gup_fast_walk()
> gup_pgd_range()
> finish_gup_fast_walk()
There are cases where interrupt disable/enable is not done around the
lockless pagetable walk.
It may come from functions called above on stack, that's why I opted it
to be only the atomic operation.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-09-23 21:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 19:50 [PATCH v2 00/11] Introduces new count-based method for monitoring lockless pagetable wakls Leonardo Bras
2019-09-20 19:50 ` [PATCH v2 01/11] powerpc/mm: Adds counting method to monitor lockless pgtable walks Leonardo Bras
[not found] ` <90ceb0ca-9f04-65a5-586c-e37c2ecc6e4e@nvidia.com>
2019-09-23 20:50 ` Leonardo Bras
2019-09-20 19:50 ` [PATCH v2 02/11] asm-generic/pgtable: Adds dummy functions " Leonardo Bras
[not found] ` <cb7d4196-c646-82c7-d61f-b28ee9ab47b9@nvidia.com>
2019-09-23 20:48 ` Leonardo Bras
2019-09-20 19:50 ` [PATCH v2 03/11] mm/gup: Applies counting method to monitor gup_pgd_range Leonardo Bras
[not found] ` <2e060677-eadf-c32e-d8c5-8e22c8ca118e@nvidia.com>
2019-09-23 21:01 ` Leonardo Bras [this message]
2019-09-20 19:50 ` [PATCH v2 04/11] powerpc/mce_power: Applies counting method to monitor lockless pgtbl walks Leonardo Bras
2019-09-20 19:50 ` [PATCH v2 05/11] powerpc/perf: " Leonardo Bras
2019-09-20 19:50 ` [PATCH v2 06/11] powerpc/mm/book3s64/hash: " Leonardo Bras
2019-09-20 19:50 ` [PATCH v2 07/11] powerpc/kvm/e500: " Leonardo Bras
2019-09-20 19:50 ` [PATCH v2 08/11] powerpc/kvm/book3s_hv: " Leonardo Bras
2019-09-20 19:50 ` [PATCH v2 09/11] powerpc/kvm/book3s_64: " Leonardo Bras
2019-09-20 19:50 ` [PATCH v2 10/11] powerpc/book3s_64: Enables counting method to monitor lockless pgtbl walk Leonardo Bras
2019-09-20 19:50 ` [PATCH v2 11/11] powerpc/mm/book3s64/pgtable: Uses counting method to skip serializing Leonardo Bras
[not found] ` <1b39eaa7-751d-40bc-d3d7-41aaa15be42a@nvidia.com>
2019-09-20 20:28 ` Leonardo Bras
[not found] ` <4ea26ffb-ad03-bdff-7893-95332b22a5fd@nvidia.com>
2019-09-23 17:25 ` Leonardo Bras
[not found] ` <8706a1f1-0c5e-d152-938b-f355b9a5aaa8@nvidia.com>
2019-09-23 19:40 ` Leonardo Bras
[not found] ` <1568b3ef-cec9-bf47-edaa-c775c2f544fb@nvidia.com>
2019-09-23 20:23 ` Leonardo Bras
2019-09-23 20:26 ` John Hubbard
2019-09-20 19:56 ` [PATCH v2 00/11] Introduces new count-based method for monitoring lockless pagetable wakls Leonardo Bras
2019-09-20 20:12 ` Leonardo Bras
[not found] ` <b2d47f4b-2bf2-20a8-2438-4fd3f9b08a63@nvidia.com>
2019-09-23 20:58 ` Leonardo Bras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=907304d0599684b3caa6773197fd40e09191b48e.camel@linux.ibm.com \
--to=leonardo@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=allison@lohutok.net \
--cc=aneesh.kumar@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=ganeshgr@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=ira.weiny@intel.com \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
--cc=rfontana@redhat.com \
--cc=rppt@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).