From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Nikita Shubin" <nikita.shubin@maquefel.me>,
"Russell King" <linux@armlinux.org.uk>,
"Hartley Sweeten" <hsweeten@visionengravers.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Mike Rapoport" <rppt@kernel.org>,
"Gregory Fong" <gregory.0xf0@gmail.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"YiFei Zhu" <yifeifz2@illinois.edu>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] ep93xx: clock: convert in-place to COMMON_CLK
Date: Sun, 13 Jun 2021 22:11:02 +0200 [thread overview]
Message-ID: <90c958bacfb77080ee524c55f5e1a01696b27017.camel@gmail.com> (raw)
In-Reply-To: <CAMuHMdVMbik3Zti3eKm1T9tAgY-iinD=om6qBA3DK5JwmqrMtA@mail.gmail.com>
Hello Geert!
On Sat, 2021-06-12 at 11:18 +0200, Geert Uytterhoeven wrote:
> > WARNING: CPU: 0 PID: 36 at drivers/clk/clk.c:952 clk_core_disable+0xbc/0xd8
> > ep93xx-spi.0 already disabled
> > [<c023ee98>] (ep93xx_spi_unprepare_hardware) from [<c023c35c>] (__spi_pump_messages+0x388/0x620)
>
> These are issues in individual drivers, not in the CCF implementation.
> All drivers using the clock API should be converted from
> clk_{en,dis}able() to clk_{prepare_enable,disable_unprepare}() first.
You are right!
I'm currently testing a series, which will convert the calls.
--
Alexander Sverdlin.
next prev parent reply other threads:[~2021-06-13 20:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 8:33 [RFC][PATCH 0/1] ep93xx: clock: convert in-place Nikita Shubin
2021-05-25 8:33 ` [PATCH 1/1] ep93xx: clock: convert in-place to COMMON_CLK Nikita Shubin
2021-05-25 19:35 ` Alexander Sverdlin
2021-06-11 22:42 ` Alexander Sverdlin
2021-06-12 9:18 ` Geert Uytterhoeven
2021-06-13 20:11 ` Alexander Sverdlin [this message]
2021-06-17 8:26 ` Nikita Shubin
2021-05-25 10:19 ` [RFC][PATCH 0/1] ep93xx: clock: convert in-place Linus Walleij
2021-05-25 11:38 ` Nikita Shubin
2021-05-25 19:39 ` Alexander Sverdlin
2021-05-26 6:11 ` Nikita Shubin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90c958bacfb77080ee524c55f5e1a01696b27017.camel@gmail.com \
--to=alexander.sverdlin@gmail.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=gregory.0xf0@gmail.com \
--cc=hsweeten@visionengravers.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nikita.shubin@maquefel.me \
--cc=rppt@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yifeifz2@illinois.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).