From: Laura Abbott <labbott@redhat.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Kees Cook <keescook@chromium.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kernel-hardening@lists.openwall.com
Subject: Re: [PATCH 3/4] gpio: Remove VLA from xra1403 driver
Date: Wed, 28 Mar 2018 10:27:09 -0700 [thread overview]
Message-ID: <90ca44b5-52d0-be74-f36c-55d6f4a9bf25@redhat.com> (raw)
In-Reply-To: <CAMuHMdUfGp_rn_fMWdOfWxPvyE1Y9oemm2piXszFTvBi9sQ5Eg@mail.gmail.com>
On 03/28/2018 12:27 AM, Geert Uytterhoeven wrote:
> Hi Laura,
>
> On Sat, Mar 10, 2018 at 1:10 AM, Laura Abbott <labbott@redhat.com> wrote:
>> The new challenge is to remove VLAs from the kernel
>> (see https://lkml.org/lkml/2018/3/7/621)
>>
>> This patch replaces a VLA with an appropriate call to kmalloc_array.
>>
>> Signed-off-by: Laura Abbott <labbott@redhat.com>
>
> Thanks for your patch!
>
>> --- a/drivers/gpio/gpio-xra1403.c
>> +++ b/drivers/gpio/gpio-xra1403.c
>> @@ -126,11 +126,16 @@ static void xra1403_dbg_show(struct seq_file *s, struct gpio_chip *chip)
>> {
>> int reg;
>> struct xra1403 *xra = gpiochip_get_data(chip);
>> - int value[xra1403_regmap_cfg.max_register];
>
> Apparently xra1403_regmap_cfg.max_register is always 0x15?
>
> What about adding
>
> #define XRA_LAST 15
>
> at the top, and replacing both "XRA_IFR | 0x01" and
> xra1403_regmap_cfg.max_register by XRA_LAST instead?
> That would avoid doing yet another memory allocation over and over.
>
> Gr{oetje,eeting}s,
>
> Geert
>
I'm okay with making the change but I think Linus already picked
up the patch into his gpio trees. Linus, do you want a patch on
top of your -devel branch or should I just send a new patch?
Thanks,
Laura
next prev parent reply other threads:[~2018-03-28 17:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-10 0:10 [PATCH 0/4] VLA removal from the GPIO subsystem Laura Abbott
2018-03-10 0:10 ` [PATCH 1/4] gpio: Remove VLA from gpiolib Laura Abbott
2018-03-12 15:00 ` Rasmus Villemoes
2018-03-12 23:40 ` Laura Abbott
2018-03-13 7:23 ` Rasmus Villemoes
2018-03-17 8:25 ` Lukas Wunner
2018-03-18 14:23 ` Lukas Wunner
2018-03-18 20:34 ` Rasmus Villemoes
2018-03-19 7:00 ` Lukas Wunner
2018-03-19 15:09 ` Andy Shevchenko
2018-03-28 0:37 ` Laura Abbott
2018-03-28 3:54 ` Lukas Wunner
2018-03-10 0:10 ` [PATCH 2/4] gpio: Remove VLA from MAX3191X driver Laura Abbott
2018-03-26 9:07 ` Linus Walleij
2018-03-10 0:10 ` [PATCH 3/4] gpio: Remove VLA from xra1403 driver Laura Abbott
2018-03-12 6:06 ` EXT: " Nandor Han
2018-03-26 9:09 ` Linus Walleij
2018-03-28 7:27 ` Geert Uytterhoeven
2018-03-28 17:27 ` Laura Abbott [this message]
2018-04-04 12:53 ` Linus Walleij
2018-03-10 0:10 ` [PATCH 4/4] gpio: Remove VLA from stmpe driver Laura Abbott
2018-03-13 9:13 ` Phil Reid
2018-03-14 0:18 ` Laura Abbott
2018-03-14 1:16 ` Laura Abbott
2018-03-14 2:55 ` Phil Reid
2018-03-13 9:42 ` [PATCH 0/4] VLA removal from the GPIO subsystem Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90ca44b5-52d0-be74-f36c-55d6f4a9bf25@redhat.com \
--to=labbott@redhat.com \
--cc=geert@linux-m68k.org \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).