From: Grant Likely <grant.likely@arm.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Saravana Kannan <saravanak@google.com>
Cc: a.hajda@samsung.com, artem.bityutskiy@linux.intel.com,
balbi@kernel.org, Mark Brown <broonie@kernel.org>,
fntoth@gmail.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
peter.ujfalusi@ti.com, "Rafael J. Wysocki" <rafael@kernel.org>,
Android Kernel Team <kernel-team@android.com>, nd <nd@arm.com>
Subject: Re: [PATCH v3] driver core: Break infinite loop when deferred probe can't be satisfied
Date: Thu, 26 Mar 2020 14:46:52 +0000 [thread overview]
Message-ID: <9175e54e-6764-458f-6e86-39a599574af5@arm.com> (raw)
In-Reply-To: <20200326115431.GP1922688@smile.fi.intel.com>
On 26/03/2020 11:54, Andy Shevchenko wrote:
> On Wed, Mar 25, 2020 at 03:08:29PM -0700, Saravana Kannan wrote:
>> On Wed, Mar 25, 2020 at 5:51 AM Andy Shevchenko
>> <andriy.shevchenko@linux.intel.com> wrote:
>>> On Tue, Mar 24, 2020 at 08:29:01PM -0700, Saravana Kannan wrote:
>>>> On Tue, Mar 24, 2020 at 5:38 AM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>>>>> Consider the following scenario.
>>>>>
>>>>> The main driver of USB OTG controller (dwc3-pci), which has the following
>>>>> functional dependencies on certain platform:
>>>>> - ULPI (tusb1210)
>>>>> - extcon (tested with extcon-intel-mrfld)
>>>>>
>>>>> Note, that first driver, tusb1210, is available at the moment of
>>>>> dwc3-pci probing, while extcon-intel-mrfld is built as a module and
>>>>> won't appear till user space does something about it.
>>>>>
>>>>> This is depicted by kernel configuration excerpt:
>>>>>
>>>>> CONFIG_PHY_TUSB1210=y
>>>>> CONFIG_USB_DWC3=y
>>>>> CONFIG_USB_DWC3_ULPI=y
>>>>> CONFIG_USB_DWC3_DUAL_ROLE=y
>>>>> CONFIG_USB_DWC3_PCI=y
>>>>> CONFIG_EXTCON_INTEL_MRFLD=m
>>>>>
>>>>> In the Buildroot environment the modules are probed by alphabetical ordering
>>>>> of their modaliases. The latter comes to the case when USB OTG driver will be
>>>>> probed first followed by extcon one.
>>>>>
>>>>> So, if the platform anticipates extcon device to be appeared, in the above case
>>>>> we will get deferred probe of USB OTG, because of ordering.
>>>>>
>>>>> Since current implementation, done by the commit 58b116bce136 ("drivercore:
>>>>> deferral race condition fix") counts the amount of triggered deferred probe,
>>>>> we never advance the situation -- the change makes it to be an infinite loop.
>>>>
>>>> Hi Andy,
>>>>
>>>> I'm trying to understand this sequence of steps. Sorry if the questions
>>>> are stupid -- I'm not very familiar with USB/PCI stuff.
>>>
>>> Thank you for looking into this. My answer below.
>>>
>>> As a first thing I would like to tell that there is another example of bad
>>> behaviour of deferred probe with no relation to USB. The proposed change also
>>> fixes that one (however, less possible to find in real life).
>>
>> Unless I see what the other issue is, I can't speak for the unknown.
>
> Okay, let's talk about other case (actually it's the one which I had noticed
> approximately at the time when culprit patch made the kernel).
>
> For some debugging purposes I have been using pin control table in board code.
>
> Since I would like to boot kernel on different systems I have some tables for
> non-existing pin control device. Pin control framework returns -EPROBE_DEFER
> when trying to probe device with attached table for wrong pin control. This is
> fine, the problem is that *any* successfully probed device, which happens in
> the deferred probe initcall will desynchronize existing counter. As a result ->
> infinite loop. For the record, I didn't realize and didn't investigate that
> time the issue and now I can confirm that this is a culprit which is fixed by
> this patch.
Specific code path please?
g.
next prev parent reply other threads:[~2020-03-26 14:47 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 17:57 [PATCH v3] driver core: Break infinite loop when deferred probe can't be satisfied Andy Shevchenko
2020-03-25 3:29 ` Saravana Kannan
2020-03-25 12:51 ` Andy Shevchenko
2020-03-25 22:08 ` Saravana Kannan
2020-03-26 8:39 ` Rafael J. Wysocki
2020-03-26 9:45 ` Peter Ujfalusi
2020-03-26 12:03 ` Andy Shevchenko
2020-03-26 13:45 ` Grant Likely
2020-03-26 14:23 ` Andy Shevchenko
2020-03-26 11:57 ` Andy Shevchenko
2020-03-26 13:48 ` Grant Likely
2020-03-26 18:45 ` Saravana Kannan
2020-03-26 11:54 ` Andy Shevchenko
2020-03-26 14:46 ` Grant Likely [this message]
2020-03-26 19:55 ` Saravana Kannan
2020-03-26 15:01 ` Grant Likely
2020-03-26 15:20 ` Grant Likely
2020-03-26 16:31 ` Andy Shevchenko
2020-03-26 16:39 ` Greg KH
2020-03-26 18:06 ` Grant Likely
2020-03-27 8:03 ` Greg KH
2020-03-27 12:37 ` Grant Likely
2020-03-27 12:51 ` Greg KH
2020-06-08 9:17 ` Marco Felsch
2020-06-08 11:11 ` Andrzej Hajda
2020-06-09 6:45 ` Marco Felsch
2020-06-09 7:30 ` Saravana Kannan
2020-06-09 9:27 ` Andrzej Hajda
2020-06-09 12:10 ` Marco Felsch
2020-06-09 13:02 ` Andrzej Hajda
2020-06-09 13:16 ` Mark Brown
2020-06-08 11:13 ` Andy Shevchenko
2020-06-08 11:59 ` Marco Felsch
2020-06-08 12:11 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9175e54e-6764-458f-6e86-39a599574af5@arm.com \
--to=grant.likely@arm.com \
--cc=a.hajda@samsung.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=balbi@kernel.org \
--cc=broonie@kernel.org \
--cc=fntoth@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nd@arm.com \
--cc=peter.ujfalusi@ti.com \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).