From: Arnaud Pouliquen <arnaud.pouliquen@st.com>
To: Suman Anna <s-anna@ti.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
<ohad@wizery.com>, <bjorn.andersson@linaro.org>
Cc: <linux-remoteproc@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Loic Pallardy <loic.pallardy@st.com>
Subject: Re: [PATCH] rpmsg: core: add support to power domains for devices
Date: Tue, 25 Sep 2018 19:25:24 +0200 [thread overview]
Message-ID: <91dda9df-8074-925d-dcd3-d7c01e6f2363@st.com> (raw)
In-Reply-To: <a80cce14-9e57-32a2-760f-3d29de009f99@ti.com>
Hi Suman
On 09/25/2018 02:25 AM, Suman Anna wrote:
> Hi Srinivas,
>
> On 06/15/2018 04:59 AM, Srinivas Kandagatla wrote:
>> Some of the rpmsg devices need to switch on power domains to communicate
>> with remote processor. For example on Qualcomm DB820c platform LPASS
>> power domain needs to switched on for any kind of audio services.
>> This patch adds the missing power domain support in rpmsg core.
>>
>> Without this patch attempting to play audio via QDSP on DB820c would
>> reboot the system.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>> drivers/rpmsg/rpmsg_core.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c
>> index b714a543a91d..8122807db380 100644
>> --- a/drivers/rpmsg/rpmsg_core.c
>> +++ b/drivers/rpmsg/rpmsg_core.c
>> @@ -15,6 +15,7 @@
>> #include <linux/module.h>
>> #include <linux/rpmsg.h>
>> #include <linux/of_device.h>
>> +#include <linux/pm_domain.h>
>> #include <linux/slab.h>
>>
>> #include "rpmsg_internal.h"
>> @@ -449,6 +450,10 @@ static int rpmsg_dev_probe(struct device *dev)
>> struct rpmsg_endpoint *ept = NULL;
>> int err;
>>
>> + err = dev_pm_domain_attach(dev, true);
>> + if (err)
>> + goto out;
>
> This patch has broken the virtio-rpmsg stack based rpmsg devices. These
> devices are non-DT and the rpmsg_dev_probe() is now failing with -19
> (-ENODEV) error code.
>
> Loic, Arnaud,
> Can one of you double-confirm this behavior on ST platforms as well?
> The patch came through 4.14.71 stable release and broke our downstream
> kernels.
I do not reproduce issue on 4.14.0 + your patch, on my ST platform (not
able to test on the LTS branch).
By looking the source code, seems that your issue is related to
genpd_dev_pm_attach that returns -ENODEV because you have
no remoteproc device node...
Do you have a rproc node defined in your DT? we have one.
Regards
Arnaud
>
> regards
> Suman
>
>> +
>> if (rpdrv->callback) {
>> strncpy(chinfo.name, rpdev->id.name, RPMSG_NAME_SIZE);
>> chinfo.src = rpdev->src;
>> @@ -490,6 +495,8 @@ static int rpmsg_dev_remove(struct device *dev)
>>
>> rpdrv->remove(rpdev);
>>
>> + dev_pm_domain_detach(dev, true);
>> +
>> if (rpdev->ept)
>> rpmsg_destroy_ept(rpdev->ept);
>>
>>
>
next prev parent reply other threads:[~2018-09-25 17:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 9:59 [PATCH] rpmsg: core: add support to power domains for devices Srinivas Kandagatla
2018-09-25 0:25 ` Suman Anna
2018-09-25 8:29 ` Srinivas Kandagatla
2018-09-25 17:20 ` Suman Anna
2018-09-25 17:25 ` Arnaud Pouliquen [this message]
2018-09-25 19:02 ` Suman Anna
2018-09-26 12:48 ` Arnaud Pouliquen
2018-09-26 13:06 ` Srinivas Kandagatla
2018-09-26 17:14 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91dda9df-8074-925d-dcd3-d7c01e6f2363@st.com \
--to=arnaud.pouliquen@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=loic.pallardy@st.com \
--cc=ohad@wizery.com \
--cc=s-anna@ti.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).