From: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
To: David Miller <davem@davemloft.net>
Cc: steffen.klassert@secunet.com, kuznet@ms2.inr.ac.ru,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
edumazet@google.com
Subject: Re: [PATCH 1/2] ip_vti: fix a null pointer deferrence when create vti fallback tunnel
Date: Mon, 20 Aug 2018 09:58:11 +0800 [thread overview]
Message-ID: <92EF6630-83A9-4F42-8444-8E67C801208E@cmss.chinamobile.com> (raw)
In-Reply-To: <20180819.112753.320024709787799108.davem@davemloft.net>
> On 2018年8月20日, at 上午2:27, David Miller <davem@davemloft.net> wrote:
>
> From: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
> Date: Sun, 19 Aug 2018 15:05:04 +0800
>
>> After set fb_tunnels_only_for_init_net to 1, the itn->fb_tunnel_dev will
>> be NULL and will cause following crash:
> ...
>> Reproduce:
>> echo 1 > /proc/sys/net/core/fb_tunnels_only_for_init_net
>> modprobe ip_vti
>> unshare -n
>>
>> Fixes: 79134e6ce2c9 (net: do not create fallback tunnels for non-default
>> namespaces)
>> Cc: Eric Dumazet <edumazet@google.com>
>> Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
>
> Applied, but please format your Fixes: tag properly next time.
>
> Do not split up a Fixes tag into multiple lines, no matter how long it
> is. And enclose the commit header text in both parenthesis and double
> quotes, not just parenthesis. Like ("blah blah blah"), thank you.
>
Okay, thanks for reviewing.
prev parent reply other threads:[~2018-08-20 1:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-19 7:05 [PATCH 1/2] ip_vti: fix a null pointer deferrence when create vti fallback tunnel Haishuang Yan
2018-08-19 7:05 ` [PATCH 2/2] ip6_vti: fix creating fallback tunnel device for vti6 Haishuang Yan
2018-08-19 18:27 ` David Miller
2018-08-19 18:27 ` [PATCH 1/2] ip_vti: fix a null pointer deferrence when create vti fallback tunnel David Miller
2018-08-20 1:58 ` Haishuang Yan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92EF6630-83A9-4F42-8444-8E67C801208E@cmss.chinamobile.com \
--to=yanhaishuang@cmss.chinamobile.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).