From: Paolo Bonzini <pbonzini@redhat.com>
To: Wanpeng Li <kernellwp@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kvm <kvm@vger.kernel.org>, "Radim Krčmář" <rkrcmar@redhat.com>,
"Wanpeng Li" <wanpeng.li@hotmail.com>,
"Eduardo Valentin" <eduval@amazon.com>
Subject: Re: [PATCH RESEND 2/3] KVM: Add paravirt remote TLB flush
Date: Thu, 9 Nov 2017 12:02:56 +0100 [thread overview]
Message-ID: <93c53d82-2b62-bb74-c472-8923bb2893aa@redhat.com> (raw)
In-Reply-To: <CANRm+Cy6rC3+avTuzxHMKtgiyJVPpLXJc0v_YxE-T6kF6kYT9w@mail.gmail.com>
On 09/11/2017 12:01, Wanpeng Li wrote:
> 2017-11-09 18:48 GMT+08:00 Paolo Bonzini <pbonzini@redhat.com>:
>> On 09/11/2017 03:02, Wanpeng Li wrote:
>>> @@ -484,6 +511,8 @@ void __init kvm_guest_init(void)
>>> pv_time_ops.steal_clock = kvm_steal_clock;
>>> }
>>>
>>> + pv_mmu_ops.flush_tlb_others = kvm_flush_tlb_others;
>>
>> This needs to be keyed on a new CPUID feature bit. Eduardo is also
>
> Will do.
>
>> adding a new "PV_DEDICATED" hint and you might disable PV TLB flush when
>> PV_DEDICATED is set.
>
> Why disable PV TLB flush for PV_DEDICATED(qspinlock)?
PV_DEDICATED says pretty much that it is very unlikely to have a
preempted vCPU. Therefore, the cpumask loop is unnecessary.
Paolo
next prev parent reply other threads:[~2017-11-09 11:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 2:02 [PATCH RESEND 0/3] KVM: Paravirt remote TLB flush Wanpeng Li
2017-11-09 2:02 ` [PATCH RESEND 1/3] KVM: Add vCPU running/preempted state Wanpeng Li
2017-11-09 2:02 ` [PATCH RESEND 2/3] KVM: Add paravirt remote TLB flush Wanpeng Li
2017-11-09 10:48 ` Paolo Bonzini
2017-11-09 11:01 ` Wanpeng Li
2017-11-09 11:02 ` Paolo Bonzini [this message]
2017-11-09 11:08 ` Wanpeng Li
2017-11-09 15:11 ` Radim Krčmář
2017-11-09 2:02 ` [PATCH RESEND 3/3] KVM: Add flush_on_enter before guest enter Wanpeng Li
2017-11-09 10:54 ` Paolo Bonzini
2017-11-09 12:31 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93c53d82-2b62-bb74-c472-8923bb2893aa@redhat.com \
--to=pbonzini@redhat.com \
--cc=eduval@amazon.com \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=wanpeng.li@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).