From: Arnd Bergmann <arnd@arndb.de>
To: maitysanchayan@gmail.com
Cc: Rob Herring <robh@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Stefan Agner <stefan@agner.ch>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 4/4] soc: Add SoC driver for Freescale Vybrid platform
Date: Fri, 27 May 2016 10:31:55 +0200 [thread overview]
Message-ID: <9495361.v6aft1QR0M@wuerfel> (raw)
In-Reply-To: <20160527063301.GB1554@Sanchayan-Arch.localdomain>
On Friday, May 27, 2016 12:03:01 PM CEST maitysanchayan@gmail.com wrote:
>
> So if I understand correctly, the binding at the SoC level is fine.
> Keeping that but removing the additional made-up properties, viz. below
>
> rom-revision: phandle to the on-chip ROM node
> mscm: phandle to the MSCM CPU configuration node
> nvmem-cells: phandles to two OCOTP child nodes ocotp_cfg0 and ocotp_cfg1
> nvmem-cell-names: should contain string names "cfg0" and "cfg1"
>
> would be fine?
>
> We would have something similar to here
> http://www.spinics.net/lists/devicetree/msg80655.html
>
> but now with the DT binding under SoC bus.
>
You look up the OTP device as a syscon here, which seems odd since there
is already an nvmem driver for it. Shouldn't you use the nvmem API for
that?
Arnd
next prev parent reply other threads:[~2016-05-27 8:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 10:02 [PATCH v3 0/4] Implement SoC driver for Vybrid Sanchayan Maity
2016-05-20 10:02 ` [PATCH v3 1/4] ARM: dts: vfxxx: Add device tree node for OCOTP Sanchayan Maity
2016-05-20 10:02 ` [PATCH v3 2/4] ARM: dts: vfxxx: Add On-Chip ROM node for Vybrid Sanchayan Maity
2016-05-20 10:02 ` [PATCH v3 3/4] ARM: dts: vfxxx: Add device tree node required by Vybrid SoC driver Sanchayan Maity
2016-05-20 10:02 ` [PATCH v3 4/4] soc: Add SoC driver for Freescale Vybrid platform Sanchayan Maity
2016-05-23 21:18 ` Rob Herring
2016-05-24 4:14 ` maitysanchayan
2016-05-24 17:09 ` Rob Herring
2016-05-25 15:18 ` Arnd Bergmann
2016-05-27 6:33 ` maitysanchayan
2016-05-27 8:31 ` Arnd Bergmann [this message]
2016-05-27 10:08 ` maitysanchayan
2016-05-27 17:28 ` Stefan Agner
2016-05-27 17:56 ` maitysanchayan
2016-06-09 10:38 ` maitysanchayan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9495361.v6aft1QR0M@wuerfel \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maitysanchayan@gmail.com \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).