From: "Elliott, Robert (Server Storage)" <Elliott@hp.com>
To: Fabian Frederick <fabf@skynet.be>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
ISS StorageDev <iss_storagedev@hp.com>
Subject: RE: [PATCH 4/7 linux-next] cpqarray: remove deprecated IRQF_DISABLED
Date: Mon, 6 Oct 2014 19:19:38 +0000 [thread overview]
Message-ID: <94D0CD8314A33A4D9D801C0FE68B402958CD82A4@G4W3202.americas.hpqcorp.net> (raw)
In-Reply-To: <1412609755-28627-5-git-send-email-fabf@skynet.be>
> -----Original Message-----
> From: Fabian Frederick [mailto:fabf@skynet.be]
> Sent: Monday, October 06, 2014 10:36 AM
> To: linux-kernel@vger.kernel.org
> Cc: Greg Kroah-Hartman; Fabian Frederick; ISS StorageDev
> Subject: [PATCH 4/7 linux-next] cpqarray: remove deprecated
> IRQF_DISABLED
>
> See include/linux/interrupt.h:
> "This flag is a NOOP and scheduled to be removed"
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/block/cpqarray.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/cpqarray.c b/drivers/block/cpqarray.c
> index 2b94403..370721e 100644
> --- a/drivers/block/cpqarray.c
> +++ b/drivers/block/cpqarray.c
> @@ -406,7 +406,7 @@ static int cpqarray_register_ctlr(int i, struct
> pci_dev *pdev)
> }
> hba[i]->access.set_intr_mask(hba[i], 0);
> if (request_irq(hba[i]->intr, do_ida_intr,
> - IRQF_DISABLED|IRQF_SHARED, hba[i]->devname, hba[i]))
> + IRQF_SHARED, hba[i]->devname, hba[i]))
> {
> printk(KERN_ERR "cpqarray: Unable to get irq %d for %s\n",
> hba[i]->intr, hba[i]->devname);
> --
> 1.9.3
Although we're awaiting resolution of MAINTAINERS updates for that
driver, this change was already made to cciss and hpsa several years
ago and seems fine here too.
Acked-by: Robert Elliott <elliott@hp.com>
next prev parent reply other threads:[~2014-10-06 19:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 15:35 [PATCH 0/7 linux-next] drivers: remove deprecated IRQF_DISABLED Fabian Frederick
2014-10-06 15:35 ` [PATCH 1/7 linux-next] mv64x60_edac: " Fabian Frederick
2014-10-06 15:35 ` [PATCH 2/7 linux-next] ppc4xx_edac: " Fabian Frederick
2014-10-06 15:35 ` [PATCH 3/7 linux-next] tw68: " Fabian Frederick
2014-10-06 15:35 ` [PATCH 4/7 linux-next] cpqarray: " Fabian Frederick
2014-10-06 19:19 ` Elliott, Robert (Server Storage) [this message]
2014-10-06 15:35 ` [PATCH 5/7 linux-next] HSI: " Fabian Frederick
2014-10-07 0:59 ` Sebastian Reichel
2014-10-06 15:35 ` [PATCH 6/7 linux-next] bus: omap_l3_noc: " Fabian Frederick
2014-10-06 15:35 ` [PATCH 7/7 linux-next] bus: omap_l3_smx: " Fabian Frederick
2014-10-06 17:40 ` [PATCH 0/7 linux-next] drivers: " Borislav Petkov
2014-10-06 18:33 ` Fabian Frederick
2014-10-06 18:46 ` Borislav Petkov
2014-10-06 19:23 ` Fabian Frederick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94D0CD8314A33A4D9D801C0FE68B402958CD82A4@G4W3202.americas.hpqcorp.net \
--to=elliott@hp.com \
--cc=fabf@skynet.be \
--cc=gregkh@linuxfoundation.org \
--cc=iss_storagedev@hp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).