From: "Elliott, Robert (Persistent Memory)" <elliott@hpe.com>
To: Matt Fleming <matt@codeblueprint.co.uk>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/4] x86/efi: show actual ending addresses in efi_print_memmap
Date: Mon, 21 Dec 2015 16:44:19 +0000 [thread overview]
Message-ID: <94D0CD8314A33A4D9D801C0FE68B40295BEC3C9C@G9W0745.americas.hpqcorp.net> (raw)
In-Reply-To: <20151221155038.GD4227@codeblueprint.co.uk>
> -----Original Message-----
> From: Matt Fleming [mailto:matt@codeblueprint.co.uk]
> Sent: Monday, December 21, 2015 9:51 AM
> To: Elliott, Robert (Persistent Memory) <elliott@hpe.com>
> Cc: tglx@linutronix.de; mingo@redhat.com; hpa@zytor.com; x86@kernel.org;
> linux-efi@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 1/4] x86/efi: show actual ending addresses in
> efi_print_memmap
>
> On Thu, 17 Dec, at 07:28:31PM, Robert Elliott wrote:
> > Adjust efi_print_memmap to print the real end address of each
> > range, not 1 byte beyond. This matches other prints like those for
> > SRAT and nosave memory.
> >
> > Change the closing ) to ] to match the opening [.
> >
> > old:
> > efi: mem61: [Persistent Memory | | | | | | | |WB|WT|WC|UC]
> range=[0x0000000880000000-0x0000000c80000000) (16384MB)
> >
> > new:
> > efi: mem61: [Persistent Memory | | | | | | | |WB|WT|WC|UC]
> range=[0x0000000880000000-0x0000000c7fffffff] (16384MB)
> >
> > Example other address range prints:
> > SRAT: Node 1 PXM 1 [mem 0x480000000-0x87fffffff]
> > PM: Registered nosave memory: [mem 0x880000000-0xc7fffffff]
> >
> > Signed-off-by: Robert Elliott <elliott@hpe.com>
> > ---
> > arch/x86/platform/efi/efi.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Is this change purely for aesthetic reasons? We're usually not in the
> habit of changing the output of print messages without a good reason
> because people downstream do rely on them being consistent.
The format of that line is architecture-specific and only appears
under the efi=debug kernel parameter, so I don't know how much
anyone relies on the specific format. Good question for the lists.
arch/ia64/kernel/efi.c shares the range=[...) format, but prints
the range after the bitmask rather than before:
printk("mem%02d: %s "
"range=[0x%016lx-0x%016lx) (%4lu%s)\n",
i, efi_md_typeattr_format(buf, sizeof(buf), md),
md->phys_addr,
md->phys_addr + efi_md_size(md), size, unit);
arch/arm64/kernel/efi.c has no mem prefix, or range=[...) text
surrounding the range:
pr_info(" 0x%012llx-0x%012llx %s",
paddr, paddr + (npages << EFI_PAGE_SHIFT) - 1,
efi_md_typeattr_format(buf, sizeof(buf), md));
pr_cont("*");
pr_cont("\n");
The x86 code is inside ifdef EFI_DEBUG, which is always
defined in that file. I wonder if it was supposed to change
to efi_enabled(EFI_DBG) to be based off the efi=debug kernel
parameter? efi_init() qualified the call to this function
based on that:
if (efi_enabled(EFI_DBG))
efi_print_memmap();
In arch/ia64/kernel/efi.c efi_init(), EFI_DEBUG is set to 0
so the print doesn't happen at all without editing the
source code. It doesn't use efi_enabled(EFI_DBG).
arch/arm64/kernel/efi.c uses efi_enabled(EFI_DBG) exclusively.
---
Robert Elliott, HPE Persistent Memory
next prev parent reply other threads:[~2015-12-21 16:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 1:28 Robert Elliott
2015-12-18 1:28 ` [PATCH 1/4] x86/efi: show actual ending addresses in efi_print_memmap Robert Elliott
2015-12-21 15:50 ` Matt Fleming
2015-12-21 16:06 ` Matt Fleming
2015-12-22 20:08 ` Elliott, Robert (Persistent Memory)
2015-12-23 12:44 ` Matt Fleming
2015-12-21 16:44 ` Elliott, Robert (Persistent Memory) [this message]
2015-12-23 12:47 ` Matt Fleming
2015-12-24 1:07 ` [PATCH v2 " Robert Elliott
2016-01-08 12:04 ` Matt Fleming
2015-12-18 1:28 ` [PATCH 2/4] efi: add NV memory attribute Robert Elliott
2015-12-21 15:54 ` Matt Fleming
2015-12-18 1:28 ` [PATCH 3/4] efi: add Persistent Memory type name Robert Elliott
2016-01-08 12:20 ` Matt Fleming
2015-12-18 1:28 ` [PATCH 4/4] x86/efi: print size and base in binary units in efi_print_memmap Robert Elliott
2015-12-21 16:16 ` Matt Fleming
2015-12-23 0:11 ` Elliott, Robert (Persistent Memory)
2015-12-23 15:52 ` Matt Fleming
2015-12-27 14:35 ` Andy Shevchenko
2016-01-08 12:19 ` Matt Fleming
2016-01-08 16:38 ` Elliott, Robert (Persistent Memory)
2016-01-08 16:44 ` Andy Shevchenko
2016-01-08 16:39 ` Andy Shevchenko
2016-01-11 14:09 ` Matt Fleming
2016-01-12 13:17 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94D0CD8314A33A4D9D801C0FE68B40295BEC3C9C@G9W0745.americas.hpqcorp.net \
--to=elliott@hpe.com \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).