linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
To: Linus Walleij <linus.walleij@linaro.org>,
	Ard Biesheuvel <ardb@kernel.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>,
	Russell King <linux@armlinux.org.uk>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 0/2] ARM: Implement MODULE_PLT support in FTRACE
Date: Tue, 2 Mar 2021 11:00:51 +0100	[thread overview]
Message-ID: <950ee6f5-13f2-8a07-6956-6921df4fc435@nokia.com> (raw)
In-Reply-To: <CACRpkdZby96WZtO7FEHc1YJ0RfyCi2u_q1PsfJQP6yLGX1Nmrg@mail.gmail.com>

Hello Linus,

On 02/03/2021 09:29, Linus Walleij wrote:
>>>> FTRACE's function tracer currently doesn't always work on ARM with
>>>> MODULE_PLT option enabled. If the module is loaded too far, FTRACE's

First of all:

config ARM_MODULE_PLTS                                                                                                                                                                                             
        bool "Use PLTs to allow module memory to spill over into vmalloc area"                                                                                                                                     


[...]

> Any suggestions on a quick use case that illustrates how the problem
> manifest and how to test it is gone? The errors in patch 2, what do
> I need to configure in to get them? Does it manifest at modprobe?

And then I use this module to test for the problem:

/**********************************************************************
 * Author: Alexander Sverdlin <alexander.sverdlin@nokia.com>
 *
 * Copyright (c) 2018 Nokia
 *
 * SPDX-License-Identifier: GPL-2.0
 *
 * This module is intended to test ARM MODULE_PLT functionality
 **********************************************************************/

#include <linux/types.h>
#include <linux/kernel.h>
#include <linux/module.h>

static int fatmod_init(void)
{
	asm volatile (".rept (6 * 1024 * 1024 / 2)\n\t"
		      "nop\n\t"
		      ".endr");
	return 0;
}
module_init(fatmod_init);

static void __exit fatmod_exit(void)
{
}
module_exit(fatmod_exit);

MODULE_AUTHOR("Alexander Sverdlin <alexander.sverdlin@nokia.com>");
MODULE_DESCRIPTION("ARM MODULE_PLT test module");
MODULE_LICENSE("GPL");

-- 
Best regards,
Alexander Sverdlin.

      reply	other threads:[~2021-03-02 10:47 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27 11:09 [PATCH v7 0/2] ARM: Implement MODULE_PLT support in FTRACE Alexander A Sverdlin
2021-01-27 11:09 ` [PATCH v7 1/2] ARM: PLT: Move struct plt_entries definition to header Alexander A Sverdlin
2021-01-27 20:25   ` Florian Fainelli
2021-01-27 11:09 ` [PATCH v7 2/2] ARM: ftrace: Add MODULE_PLTS support Alexander A Sverdlin
2021-01-27 19:36   ` Florian Fainelli
2021-03-07 17:26   ` Qais Yousef
2021-03-08  7:58     ` Alexander Sverdlin
2021-03-09 17:42       ` Qais Yousef
2021-03-10  7:23         ` Alexander Sverdlin
2021-03-10 16:14           ` Florian Fainelli
2021-03-10 17:17             ` Alexander Sverdlin
2021-03-12 17:24               ` Qais Yousef
2021-03-12 18:35                 ` Florian Fainelli
2021-03-14 22:02                   ` Qais Yousef
2021-03-21 19:06                     ` Qais Yousef
2021-03-22 15:01                       ` Steven Rostedt
2021-03-22 16:32                         ` Qais Yousef
2021-03-22 17:02                           ` Alexander Sverdlin
2021-03-23 22:22                             ` Qais Yousef
2021-03-24  3:37                               ` Florian Fainelli
2021-03-24 16:10                                 ` Qais Yousef
2021-03-24  9:04                               ` Alexander Sverdlin
2021-03-24 15:57                                 ` Qais Yousef
2021-03-24 16:33                                   ` Alexander Sverdlin
2021-03-24 16:46                                     ` Qais Yousef
2021-03-15  9:19                   ` Alexander Sverdlin
2021-02-03 18:23 ` [PATCH v7 0/2] ARM: Implement MODULE_PLT support in FTRACE Florian Fainelli
2021-02-15 18:31   ` Ard Biesheuvel
2021-03-02  8:29     ` Linus Walleij
2021-03-02 10:00       ` Alexander Sverdlin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=950ee6f5-13f2-8a07-6956-6921df4fc435@nokia.com \
    --to=alexander.sverdlin@nokia.com \
    --cc=ardb@kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).