From: Colin Ian King <colin.king@canonical.com>
To: "Harry Wentland" <harry.wentland@amd.com>,
"Leo Li" <sunpeng.li@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"amd-gfx mailing list" <amd-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Bhawanpreet Lakha" <Bhawanpreet.Lakha@amd.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: re: drm/amd/display: Add HDCP module - static analysis bug report
Date: Thu, 3 Oct 2019 23:08:03 +0100 [thread overview]
Message-ID: <951eb7dc-bebe-5049-4998-f199e18b0bf3@canonical.com> (raw)
Hi,
Static analysis with Coverity has detected a potential issue with
function validate_bksv in
drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c with recent
commit:
commit ed9d8e2bcb003ec94658cafe9b1bb3960e2139ec
Author: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
Date: Tue Aug 6 17:52:01 2019 -0400
drm/amd/display: Add HDCP module
The analysis is as follows:
28 static inline enum mod_hdcp_status validate_bksv(struct mod_hdcp *hdcp)
29 {
CID 89852 (#1 of 1): Out-of-bounds read (OVERRUN)
1. overrun-local:
Overrunning array of 5 bytes at byte offset 7 by dereferencing pointer
(uint64_t *)hdcp->auth.msg.hdcp1.bksv.
30 uint64_t n = *(uint64_t *)hdcp->auth.msg.hdcp1.bksv;
31 uint8_t count = 0;
32
33 while (n) {
34 count++;
35 n &= (n - 1);
36 }
hdcp->auth.msg.hdcp1.bksv is an array of 5 uint8_t as defined in
drivers/gpu/drm/amd/display/modules/hdcp/hdcp.h as follows:
struct mod_hdcp_message_hdcp1 {
uint8_t an[8];
uint8_t aksv[5];
uint8_t ainfo;
uint8_t bksv[5];
uint16_t r0p;
uint8_t bcaps;
uint16_t bstatus;
uint8_t ksvlist[635];
uint16_t ksvlist_size;
uint8_t vp[20];
uint16_t binfo_dp;
};
variable n is going to contain the contains of r0p and bcaps. I'm not
sure if that is intentional. If not, then the count is going to be
incorrect if these are non-zero.
Colin
next reply other threads:[~2019-10-03 22:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 22:08 Colin Ian King [this message]
2019-10-09 16:32 ` drm/amd/display: Add HDCP module - static analysis bug report Daniel Vetter
2019-10-09 18:23 ` Lakha, Bhawanpreet
2019-10-09 18:43 ` Daniel Vetter
2019-10-09 20:46 ` Lakha, Bhawanpreet
2019-10-09 20:58 ` Daniel Vetter
2019-11-04 10:53 ` Daniel Vetter
2019-11-04 15:23 ` Harry Wentland
2019-11-04 16:05 ` Lakha, Bhawanpreet
2019-11-04 16:54 ` Daniel Vetter
2019-11-04 17:05 ` Alex Deucher
2019-11-04 17:24 ` Daniel Vetter
2019-11-05 12:51 ` Alex Deucher
2019-11-05 13:14 ` Daniel Vetter
2019-11-05 14:17 ` Harry Wentland
2019-11-05 14:23 ` Daniel Vetter
2019-11-05 14:39 ` Harry Wentland
2019-11-05 15:00 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=951eb7dc-bebe-5049-4998-f199e18b0bf3@canonical.com \
--to=colin.king@canonical.com \
--cc=Bhawanpreet.Lakha@amd.com \
--cc=David1.Zhou@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).