From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCH 1/3] regulator: max14577: Add proper dt-compatible strings
Date: Fri, 21 Feb 2020 11:44:03 +0100 [thread overview]
Message-ID: <964b8c4c-36ca-203d-e62b-4a8fc970e23d@samsung.com> (raw)
In-Reply-To: <20200220165614.GD3926@sirena.org.uk>
Hi Mark,
On 20.02.2020 17:56, Mark Brown wrote:
> On Thu, Feb 20, 2020 at 03:51:25PM +0100, Marek Szyprowski wrote:
>> Add device tree compatible strings and create proper modalias structures
>> to let this driver load automatically if compiled as module, because
>> max14577 MFD driver creates MFD cells with such compatible strings.
>> +static const struct of_device_id of_max14577_regulator_dt_match[] = {
>> + { .compatible = "maxim,max77836-regulator",
>> + .data = (void *)MAXIM_DEVICE_TYPE_MAX77836, },
>> + { .compatible = "maxim,max14577-regulator",
>> + .data = (void *)MAXIM_DEVICE_TYPE_MAX14577, },
> Why would we want to encode the particular way Linux happens to
> represent regulators on a MFD into the DT binding? It's not clear that
> this is a generic thing (another OS might choose to have a separate
> object for each regulator with no parent for example) and the compatible
> isn't adding any information we didn't have already knowing about the
> parent device.
Well, that's how the bindings for max14577/max77836 are defined:
Documentation/devicetree/bindings/mfd/max14577.txt
I've only fixed regulator, charger and extcon drivers to match the cells
created by the current mfd driver.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2020-02-21 10:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200220145134eucas1p288ae1910d3e8d12dc12f010ed0b07b45@eucas1p2.samsung.com>
2020-02-20 14:51 ` [PATCH 1/3] regulator: max14577: Add proper dt-compatible strings Marek Szyprowski
[not found] ` <CGME20200220145135eucas1p123c4e4523e7e6eb86b64e728d6931cee@eucas1p1.samsung.com>
2020-02-20 14:51 ` [PATCH 2/3] extcon: " Marek Szyprowski
2020-03-14 18:45 ` Krzysztof Kozlowski
[not found] ` <CGME20200220145135eucas1p1ba181cef65c7a4f91a254ee35e022f08@eucas1p1.samsung.com>
2020-02-20 14:51 ` [PATCH 3/3] power: charger: " Marek Szyprowski
2020-03-14 18:45 ` Krzysztof Kozlowski
2020-05-10 16:54 ` Sebastian Reichel
2020-02-20 16:56 ` [PATCH 1/3] regulator: " Mark Brown
2020-02-21 10:44 ` Marek Szyprowski [this message]
2020-02-21 12:38 ` Mark Brown
2020-02-21 13:23 ` Marek Szyprowski
2020-02-21 17:13 ` Mark Brown
2020-02-24 14:08 ` Marek Szyprowski
2020-02-24 20:12 ` Krzysztof Kozlowski
2020-03-06 13:51 ` Marek Szyprowski
2020-03-14 18:41 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=964b8c4c-36ca-203d-e62b-4a8fc970e23d@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).