From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3603FC0650F for ; Tue, 30 Jul 2019 11:33:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1502E2087F for ; Tue, 30 Jul 2019 11:33:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730359AbfG3LdN (ORCPT ); Tue, 30 Jul 2019 07:33:13 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:52837 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728554AbfG3LdM (ORCPT ); Tue, 30 Jul 2019 07:33:12 -0400 Received: by mail-wm1-f65.google.com with SMTP id s3so56786593wms.2 for ; Tue, 30 Jul 2019 04:33:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UPB+O1cCb7Wq2RKCoVQnzfZBI5pS9MKq+7qoNAVhJ6s=; b=XXw31HwvFxLcndX+7JYIMQI+uz7y09cdGSiVfB01dMZbq4OCF90Mz8Q6/6CQM9bXeS ImUGGHQCSc8dQe84BWT1gQ/V8rg35IxGKgacjWwzWBFvKSzLO7iEYtsZRRds9heiUxTJ ecSPyxrRQsbv15/+iEZsbsGuahA7OcPIq+71+me+4kMmru/8jX/sWbHl2dX3PLjJ+iqV kh+Cx5gLFSm8gy9g4t4yc7ZDqJV9b3KIDsnUENnQaAmD8BmuGdGBN7eF//6QKQ1NWqWv Ti576G6tsTETaiUBuAcWGvaspskaxnPo5W+bK+OEzylEAxuBgn+uxrC5r/+K2UJe9hs3 vFwA== X-Gm-Message-State: APjAAAXaE3gnoyB/maV3vKw/dUAaCO7xhEpCPlMyYtzdTupfUUtCjXbG PDNkyhlscNjbUdGKu2e5RAGt4hzPyjM= X-Google-Smtp-Source: APXvYqwZbQfaWi8ZX3vZiY1Jont5uSIg4Z3fLMXkr7rwafZ4q9S6fJyyXi6HPOxn4HmB3Yz8Zlp4bw== X-Received: by 2002:a7b:c144:: with SMTP id z4mr109313020wmi.50.1564486390353; Tue, 30 Jul 2019 04:33:10 -0700 (PDT) Received: from [192.168.10.150] ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id j10sm111237085wrd.26.2019.07.30.04.33.08 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 30 Jul 2019 04:33:09 -0700 (PDT) Subject: Re: [RFC PATCH 00/16] KVM RISC-V Support To: Anup Patel Cc: Anup Patel , Palmer Dabbelt , Paul Walmsley , Radim K , Daniel Lezcano , Thomas Gleixner , Atish Patra , Alistair Francis , Damien Le Moal , Christoph Hellwig , "kvm@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "linux-kernel@vger.kernel.org" References: <20190729115544.17895-1-anup.patel@wdc.com> <72e9f668-f496-3fca-a1a8-a3c3122a3fd9@redhat.com> From: Paolo Bonzini Message-ID: <965cffdb-86e2-b422-9c23-345c7100fd88@redhat.com> Date: Tue, 30 Jul 2019 13:33:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/07/19 07:26, Anup Patel wrote: > Here's a brief TODO list which we want to immediately work upon after this > series: > 1. Handle trap from unpriv access in SBI v0.1 emulation > 2. In-kernel PLIC emulation > 3. SBI v0.2 emulation in-kernel > 4. SBI v0.2 hart hotplug emulation in-kernel > 5. ..... and so on ..... > > We will include above TODO list in v2 series cover letter as well. I guess I gave you a bunch of extra items in today's more thorough review. :) BTW, since IPIs are handled in the SBI I wouldn't bother with in-kernel PLIC emulation unless you can demonstrate performance improvements (for example due to irqfd). In fact, it may be more interesting to add plumbing for userspace handling of selected SBI calls (in addition to get/putchar, sbi_system_reset and sbi_hart_down look like good candidates in SBI v0.2). > We were thinking to keep KVM RISC-V disabled by default (i.e. keep it > experimental) until we have validated it on some FPGA or real HW. For now, > users can explicitly enable it and play-around on QEMU emulation. I hope > this is fine with most people ? That's certainly okay with me. Paolo