From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 2/6] staging: rtl8192e: Init tx_pwr_level_cck_a and friends directly
Date: Fri, 20 Jan 2023 21:18:02 +0100 [thread overview]
Message-ID: <9874e99fb9a803be2a89e81e2ecd01ba80398ea1.1674244819.git.philipp.g.hortmann@gmail.com> (raw)
In-Reply-To: <cover.1674244819.git.philipp.g.hortmann@gmail.com>
The arrays EEPROMRfACCKChnl1TxPwLevel, EEPROMRfAOfdmChnlTxPwLevel,
EEPROMRfCCCKChnl1TxPwLevel, EEPROMRfCOfdmChnlTxPwLevel are initialized to
zero and never changed. Delete the arrays and set the variables directly
to zero to avoid CamelCase which is not accepted by checkpatch.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 12 ++++--------
drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 4 ----
2 files changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index 7187ee4c75f6..fdf37c56066c 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -427,14 +427,10 @@ static void _rtl92e_read_eeprom_info(struct net_device *dev)
} else if (priv->epromtype == EEPROM_93C56) {
for (i = 0; i < 14; i++) {
- priv->tx_pwr_level_cck_a[i] =
- priv->EEPROMRfACCKChnl1TxPwLevel[0];
- priv->tx_pwr_level_ofdm_24g_a[i] =
- priv->EEPROMRfAOfdmChnlTxPwLevel[0];
- priv->tx_pwr_level_cck_c[i] =
- priv->EEPROMRfCCCKChnl1TxPwLevel[0];
- priv->tx_pwr_level_ofdm_24g_c[i] =
- priv->EEPROMRfCOfdmChnlTxPwLevel[0];
+ priv->tx_pwr_level_cck_a[i] = 0;
+ priv->tx_pwr_level_ofdm_24g_a[i] = 0;
+ priv->tx_pwr_level_cck_c[i] = 0;
+ priv->tx_pwr_level_ofdm_24g_c[i] = 0;
}
priv->legacy_ht_tx_pwr_diff =
priv->eeprom_legacy_ht_tx_pwr_diff;
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
index 11f3f88491b2..596693fbee4c 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
@@ -423,10 +423,6 @@ struct r8192_priv {
u8 eeprom_tx_pwr_level_cck[14];
u8 eeprom_tx_pwr_level_ofdm24g[14];
- u8 EEPROMRfACCKChnl1TxPwLevel[3];
- u8 EEPROMRfAOfdmChnlTxPwLevel[3];
- u8 EEPROMRfCCCKChnl1TxPwLevel[3];
- u8 EEPROMRfCOfdmChnlTxPwLevel[3];
u16 eeprom_ant_pwr_diff;
u8 eeprom_thermal_meter;
u8 eeprom_crystal_cap;
--
2.39.0
next prev parent reply other threads:[~2023-01-20 20:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 20:17 [PATCH 0/6] Remove several variables that are zero from struct r8192_priv Philipp Hortmann
2023-01-20 20:17 ` [PATCH 1/6] staging: rtl8192e: Combine three loops to one to init tx_pwr_level_ Philipp Hortmann
2023-01-20 20:18 ` Philipp Hortmann [this message]
2023-01-20 20:18 ` [PATCH 3/6] staging: rtl8192e: Remove zeroed arrays tx_pwr_level_cck_a and friends Philipp Hortmann
2023-01-20 20:18 ` [PATCH 4/6] staging: rtl8192e: Remove ant_pwr_diff which is always zero Philipp Hortmann
2023-01-20 20:18 ` [PATCH 5/6] staging: rtl8192e: Remove u4RegValue " Philipp Hortmann
2023-01-20 20:18 ` [PATCH 6/6] staging: rtl8192e: Remove repeated set to zero of powerlevel and friend Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9874e99fb9a803be2a89e81e2ecd01ba80398ea1.1674244819.git.philipp.g.hortmann@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).