From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA7DFC46475 for ; Tue, 23 Oct 2018 17:13:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7360620813 for ; Tue, 23 Oct 2018 17:13:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="s19mhOOL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7360620813 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728552AbeJXBhy (ORCPT ); Tue, 23 Oct 2018 21:37:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:40336 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727758AbeJXBhy (ORCPT ); Tue, 23 Oct 2018 21:37:54 -0400 Received: from [192.168.1.87] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3EB7720671; Tue, 23 Oct 2018 17:13:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1540314818; bh=qekHBaA411MmJxUM02AiDi/UQKWIlGqpaEqPzbqOYoc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=s19mhOOLm5K+Bw967a+ehN7+ntUcKnTsNhgnlY8oKv3qUaqe5qamsAwJ0x7CE+LwF zGQWFV0Jkou+B8+ZAlUVAsa3wSkllWDWeAosRzT0IIgXIBzIwJ/A/eHYPKyvqOiCwn i7KKEosrx3n3OstZWHUeWTkDQLQf4XCgRxvp5yZY= Subject: Re: [RFC PATCH 0/2] improve vmalloc allocation To: Michal Hocko , Matthew Wilcox Cc: Uladzislau Rezki , Kees Cook , Andrew Morton , linux-mm@kvack.org, LKML , Thomas Garnier , Oleksiy Avramchenko , Steven Rostedt , Joel Fernandes , Thomas Gleixner , Ingo Molnar , Tejun Heo , Shuah Khan References: <20181019173538.590-1-urezki@gmail.com> <20181022125142.GD18839@dhcp22.suse.cz> <20181022165253.uphv3xzqivh44o3d@pc636> <20181023072306.GN18839@dhcp22.suse.cz> <20181023152640.GD20085@bombadil.infradead.org> <20181023170532.GW18839@dhcp22.suse.cz> From: Shuah Khan Message-ID: <98842edb-d462-96b1-311f-27c6ebfc108a@kernel.org> Date: Tue, 23 Oct 2018 11:13:36 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181023170532.GW18839@dhcp22.suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/23/2018 11:05 AM, Michal Hocko wrote: > On Tue 23-10-18 08:26:40, Matthew Wilcox wrote: >> On Tue, Oct 23, 2018 at 09:02:56AM -0600, Shuah Khan wrote: > [...] >>> The way it can be handled is by adding a test module under lib. test_kmod, >>> test_sysctl, test_user_copy etc. >> >> The problem is that said module can only invoke functions which are >> exported using EXPORT_SYMBOL. And there's a cost to exporting them, >> which I don't think we're willing to pay, purely to get test coverage. > > Yes, I think we do not want to export internal functionality which might > be still interesting for the testing coverage. Maybe we want something > like EXPORT_SYMBOL_KSELFTEST which would allow to link within the > kselftest machinery but it wouldn't allow the same for general modules > and will not give any API promisses. > I like this proposal. I think we will open up lot of test opportunities with this approach. Maybe we can use this stress test as a pilot and see where it takes us. thanks, -- Shuah