From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: Sergey Senozhatsky <senozhatsky@chromium.org>,
Tomasz Figa <tfiga@chromium.org>
Cc: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
Ricardo Ribalda <ribalda@chromium.org>,
Christoph Hellwig <hch@lst.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv4 4/8] videobuf2: move cache_hints handling to allocators
Date: Tue, 3 Aug 2021 10:11:31 +0200 [thread overview]
Message-ID: <9997d302-effb-7026-6891-56426823fc25@xs4all.nl> (raw)
In-Reply-To: <20210727070517.443167-5-senozhatsky@chromium.org>
On 27/07/2021 09:05, Sergey Senozhatsky wrote:
> This moves cache hints handling from videobuf2 core down
from -> from the
> to allocators level, because allocators do the sync/flush
to allocators -> to the allocator's
> caches eventually and may take better decisions. Besides,
> allocators already decide whether cache sync/flush should
> be done or can be skipped. This patch moves the scattered
> buffer cache sync logic to one common place.
Regards,
Hans
>
> Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
> ---
> drivers/media/common/videobuf2/videobuf2-core.c | 6 ------
> drivers/media/common/videobuf2/videobuf2-dma-contig.c | 6 ++++++
> drivers/media/common/videobuf2/videobuf2-dma-sg.c | 6 ++++++
> 3 files changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/common/videobuf2/videobuf2-core.c b/drivers/media/common/videobuf2/videobuf2-core.c
> index 76210c006958..55af63d54f23 100644
> --- a/drivers/media/common/videobuf2/videobuf2-core.c
> +++ b/drivers/media/common/videobuf2/videobuf2-core.c
> @@ -328,9 +328,6 @@ static void __vb2_buf_mem_prepare(struct vb2_buffer *vb)
> return;
>
> vb->synced = 1;
> - if (vb->skip_cache_sync_on_prepare)
> - return;
> -
> for (plane = 0; plane < vb->num_planes; ++plane)
> call_void_memop(vb, prepare, vb->planes[plane].mem_priv);
> }
> @@ -347,9 +344,6 @@ static void __vb2_buf_mem_finish(struct vb2_buffer *vb)
> return;
>
> vb->synced = 0;
> - if (vb->skip_cache_sync_on_finish)
> - return;
> -
> for (plane = 0; plane < vb->num_planes; ++plane)
> call_void_memop(vb, finish, vb->planes[plane].mem_priv);
> }
> diff --git a/drivers/media/common/videobuf2/videobuf2-dma-contig.c b/drivers/media/common/videobuf2/videobuf2-dma-contig.c
> index 019c3843dc6d..1e218bc440c6 100644
> --- a/drivers/media/common/videobuf2/videobuf2-dma-contig.c
> +++ b/drivers/media/common/videobuf2/videobuf2-dma-contig.c
> @@ -101,6 +101,9 @@ static void vb2_dc_prepare(void *buf_priv)
> struct vb2_dc_buf *buf = buf_priv;
> struct sg_table *sgt = buf->dma_sgt;
>
> + if (buf->vb->skip_cache_sync_on_prepare)
> + return;
> +
> if (!sgt)
> return;
>
> @@ -112,6 +115,9 @@ static void vb2_dc_finish(void *buf_priv)
> struct vb2_dc_buf *buf = buf_priv;
> struct sg_table *sgt = buf->dma_sgt;
>
> + if (buf->vb->skip_cache_sync_on_finish)
> + return;
> +
> if (!sgt)
> return;
>
> diff --git a/drivers/media/common/videobuf2/videobuf2-dma-sg.c b/drivers/media/common/videobuf2/videobuf2-dma-sg.c
> index 50265080cfc8..33ee63a99139 100644
> --- a/drivers/media/common/videobuf2/videobuf2-dma-sg.c
> +++ b/drivers/media/common/videobuf2/videobuf2-dma-sg.c
> @@ -204,6 +204,9 @@ static void vb2_dma_sg_prepare(void *buf_priv)
> struct vb2_dma_sg_buf *buf = buf_priv;
> struct sg_table *sgt = buf->dma_sgt;
>
> + if (buf->vb->skip_cache_sync_on_prepare)
> + return;
> +
> dma_sync_sgtable_for_device(buf->dev, sgt, buf->dma_dir);
> }
>
> @@ -212,6 +215,9 @@ static void vb2_dma_sg_finish(void *buf_priv)
> struct vb2_dma_sg_buf *buf = buf_priv;
> struct sg_table *sgt = buf->dma_sgt;
>
> + if (buf->vb->skip_cache_sync_on_finish)
> + return;
> +
> dma_sync_sgtable_for_cpu(buf->dev, sgt, buf->dma_dir);
> }
>
>
next prev parent reply other threads:[~2021-08-03 8:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 7:05 [PATCHv4 0/8] videobuf2: support new noncontiguous DMA API Sergey Senozhatsky
2021-07-27 7:05 ` [PATCHv4 1/8] videobuf2: rework vb2_mem_ops API Sergey Senozhatsky
2021-08-03 8:08 ` Hans Verkuil
2021-08-17 10:41 ` Sergey Senozhatsky
2021-07-27 7:05 ` [PATCHv4 2/8] videobuf2: inverse buffer cache_hints flags Sergey Senozhatsky
2021-07-27 7:05 ` [PATCHv4 3/8] videobuf2: split buffer cache_hints initialisation Sergey Senozhatsky
2021-08-03 8:10 ` Hans Verkuil
2021-08-17 10:41 ` Sergey Senozhatsky
2021-07-27 7:05 ` [PATCHv4 4/8] videobuf2: move cache_hints handling to allocators Sergey Senozhatsky
2021-08-03 8:11 ` Hans Verkuil [this message]
2021-08-17 10:42 ` Sergey Senozhatsky
2021-07-27 7:05 ` [PATCHv4 5/8] videobuf2: add V4L2_MEMORY_FLAG_NON_COHERENT flag Sergey Senozhatsky
2021-08-03 8:12 ` Hans Verkuil
2021-08-17 10:42 ` Sergey Senozhatsky
2021-07-27 7:05 ` [PATCHv4 6/8] videobuf2: add queue memory coherency parameter Sergey Senozhatsky
2021-08-03 8:29 ` Hans Verkuil
2021-08-17 10:43 ` Sergey Senozhatsky
2021-07-27 7:05 ` [PATCHv4 7/8] videobuf2: handle V4L2_MEMORY_FLAG_NON_COHERENT flag Sergey Senozhatsky
2021-08-03 8:31 ` Hans Verkuil
2021-08-17 10:43 ` Sergey Senozhatsky
2021-07-27 7:05 ` [PATCHv4 8/8] videobuf2: handle non-contiguous DMA allocations Sergey Senozhatsky
2021-08-03 8:33 ` Hans Verkuil
2021-08-03 8:39 ` Hans Verkuil
2021-08-23 10:28 ` Sergey Senozhatsky
2021-08-23 10:27 ` Sergey Senozhatsky
2021-08-03 10:15 ` Hans Verkuil
2021-08-17 11:56 ` Sergey Senozhatsky
2021-08-18 9:20 ` Tomasz Figa
2021-08-23 10:29 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9997d302-effb-7026-6891-56426823fc25@xs4all.nl \
--to=hverkuil-cisco@xs4all.nl \
--cc=dafna.hirschfeld@collabora.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ribalda@chromium.org \
--cc=senozhatsky@chromium.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).