From: Frank Wang <frank.wang@rock-chips.com>
To: "Heiko Stübner" <heiko@sntech.de>, "Mark Rutland" <mark.rutland@arm.com>
Cc: dianders@chromium.org, linux@roeck-us.net, groeck@chromium.org,
jwerner@chromium.org, kishon@ti.com, robh+dt@kernel.org,
pawel.moll@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
linux-rockchip@lists.infradead.org, xzy.xu@rock-chips.com,
kever.yang@rock-chips.com, huangtao@rock-chips.com,
william.wu@rock-chips.com, frank.wang@rock-chips.com
Subject: Re: [PATCH v3 1/2] Documentation: bindings: add DT documentation for Rockchip USB2PHY
Date: Tue, 7 Jun 2016 11:31:59 +0800 [thread overview]
Message-ID: <9a34e448-2b4d-4797-2e6b-c7a36c03b597@rock-chips.com> (raw)
In-Reply-To: <2b3e9b0b-f17e-063b-6eb0-2390bd87901b@rock-chips.com>
Hi Heiko,
On 2016/6/7 10:59, Frank Wang wrote:
> Hi Heiko & Mark,
>
> On 2016/6/6 20:33, Heiko Stübner wrote:
>> Am Montag, 6. Juni 2016, 12:27:54 schrieb Mark Rutland:
>>> On Mon, Jun 06, 2016 at 05:20:03PM +0800, Frank Wang wrote:
>>>> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
>>>> ---
>>>>
>>>> Changes in v3:
>>>> - Added 'clocks' and 'clock-names' optional properties.
>>>> - Specified 'otg-port' and 'host-port' as the sub-node name.
>>>>
>>>> Changes in v2:
>>>> - Changed vbus_host optional property from gpio to regulator.
>>>> - Specified vbus_otg-supply optional property.
>>>> - Specified otg_id and otg_bvalid property.
>>>> .../bindings/phy/phy-rockchip-inno-usb2.txt | 60
>>>> ++++++++++++++++++++ 1 file changed, 60 insertions(+)
>>>> create mode 100644
>>>> Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt>
>>>> diff --git
>>>> a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
>>>> b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt new
>>>> file mode 100644
>>>> index 0000000..0b4bbbb
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
>>>> @@ -0,0 +1,60 @@
>>>> +ROCKCHIP USB2.0 PHY WITH INNO IP BLOCK
>>>> +
>>>> +Required properties (phy (parent) node):
>>>> + - compatible : should be one of the listed compatibles:
>>>> + * "rockchip,rk3366-usb2phy"
>>>> + * "rockchip,rk3399-usb2phy"
>>>> + - #clock-cells : should be 0.
>>>> + - clock-output-names : specify the 480m output clock name.
>>>> +
>>>> +Optional properties:
>>>> + - clocks : phandle + phy specifier pair, for the input clock of phy.
>>>> + - clock-names : input clock name of phy, must be "phyclk".
>>>> + - vbus_host-supply : phandle to a regulator that supplies host vbus.
>>>> + - vbus_otg-supply : phandle to a regulator that supplies otg vbus.
>>> Nit: s/_/-/ here.
>> Something I only stumbled over yesterday for the first time on my
>> rk3288-
>> popmetal: The phy subnodes seem to be able to use a generic phy-supply
>> property from inside the phy-core itself, see:
>>
>> https://github.com/mmind/linux-rockchip/commit/93739f521fc65f44524b00c9aaf6db46bca94e02#diff-ddf3e45ebb753d6debf57022003a1a57R597
>>
>>
>> for my WIP code for that other board.
>>
>
> Ah, good comments! I will try later, if it is practicable, I shall
> correct it into the next patches (patch v4).
>
I am sorry to tell you that seems unworkable, because we have two
sub-nodes (phy-ports) in one parent-node (phy),
what is more, the 'phy-supply' property can only put into parent-node, I
believe it can not be differentiated types of ports.
I mean vbus for host and otg are separately.
>>> Otherwise the rest of this looks generally fine, though I'm confused as
>>> to how you address the programming interface(s), given none are
>>> described.
>> I think that comes generally down to phy_power_on and phy_power_off
>> from the
>> host driver (ehci / dwc2 / whatever) using the generic phy interface.
>> The usb2
>> phys on Rockchip SoCs seem always pretty easy to handle, while the new
>> additional typeC phy seems to require more work
>>
>
> Yeah, just like that.
>
>>
>>
>>>> +
>>>> +Required nodes : a sub-node is required for each port the phy
>>>> provides.
>>>> + The sub-node name is used to identify host or otg port,
>>>> + and shall be the following entries:
>>>> + * "otg-port" : the name of otg port.
>>>> + * "host-port" : the name of host port.
>>>> +
>>>> +Required properties (port (child) node):
>>>> + - #phy-cells : must be 0. See ./phy-bindings.txt for details.
>>>> + - interrupts : specify an interrupt for each entry in
>>>> interrupt-names.
>>>> + - interrupt-names : a list which shall be the following entries:
>>>> + * "otg_id" : for the otg id interrupt.
>>>> + * "otg_bvalid" : for the otg vbus interrupt.
>>>> + * "linestate" : for the host/otg linestate interrupt.
>>>> +
>>>> +Example:
>>>> +
>>>> +grf: syscon@ff770000 {
>>>> + compatible = "rockchip,rk3366-grf", "syscon", "simple-mfd";
>>>> + #address-cells = <1>;
>>>> + #size-cells = <1>;
>>>> +
>>>> +...
>>>> +
>>>> + u2phy: usb2-phy {
>>>> + compatible = "rockchip,rk3366-usb2phy";
>>>> + #clock-cells = <0>;
>>>> + clock-output-names = "sclk_otgphy0_480m";
>>>> +
>>>> + u2phy_otg: otg-port {
>>>> + #phy-cells = <0>;
>>>> + interrupts = <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>,
>>>> + <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>,
>>>> + <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>;
>>>> + interrupt-names = "otg_id", "otg_bvalid", "linestate";
>>>> + status = "okay";
>>>> + };
>>>> +
>>>> + u2phy_host: host-port {
>>>> + #phy-cells = <0>;
>>>> + interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>;
>>>> + interrupt-names = "linestate";
>>>> + status = "okay";
>>>> + };
>>>> + };
>>>> +};
next prev parent reply other threads:[~2016-06-07 3:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 9:20 [PATCH v3 0/2] Add a new Rockchip usb2 phy driver Frank Wang
2016-06-06 9:20 ` [PATCH v3 1/2] Documentation: bindings: add DT documentation for Rockchip USB2PHY Frank Wang
2016-06-06 11:27 ` Mark Rutland
2016-06-06 12:33 ` Heiko Stübner
2016-06-07 2:59 ` Frank Wang
2016-06-07 3:31 ` Frank Wang [this message]
2016-06-07 7:45 ` Kishon Vijay Abraham I
2016-06-07 8:23 ` Frank Wang
2016-06-07 7:59 ` Heiko Stübner
2016-06-06 9:20 ` [PATCH v3 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy Frank Wang
2016-06-07 9:54 ` Heiko Stübner
2016-06-07 13:19 ` Guenter Roeck
2016-06-07 14:12 ` Heiko Stübner
2016-06-07 17:19 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a34e448-2b4d-4797-2e6b-c7a36c03b597@rock-chips.com \
--to=frank.wang@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=groeck@chromium.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jwerner@chromium.org \
--cc=kever.yang@rock-chips.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=william.wu@rock-chips.com \
--cc=xzy.xu@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).