From: Lyude Paul <lyude@redhat.com>
To: Koba Ko <koba.ko@canonical.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Anthony Wong <anthony.wong@canonical.com>
Subject: Re: [PATCH V4] drm/dp_mst: Retrieve extended DPCD caps for topology manager
Date: Wed, 23 Sep 2020 10:17:59 -0400 [thread overview]
Message-ID: <9a4f2216cb621f349aa393de5d64763e4a23bc2b.camel@redhat.com> (raw)
In-Reply-To: <CAJB-X+U0M1YXUyAX2nDxddwwxnPygfkk47PFrFnvERh4fUBxiw@mail.gmail.com>
On Wed, 2020-09-23 at 10:16 +0800, Koba Ko wrote:
> Thanks for the review.
> Sorry for that I thought the review tag should be appended by myself.
> One thing to confirm with you, will you or I push this patch to drm-misc-
> next ?
I already pushed it with the change, so everything is all set
> Thanks a lot.
>
> On Wed, Sep 23, 2020 at 2:01 AM Lyude Paul <lyude@redhat.com> wrote:
> > One last change I realized we should do is print the name of the AUX
> > adapter
> > in question. I don't mind just adding that myself before I push it though
> > so
> > you don't need to send a respin.
> >
> > Going to go push this to drm-misc-next, thanks!
> >
> > On Tue, 2020-09-22 at 14:53 +0800, Koba Ko wrote:
> > > As per DP-1.3, First check DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT.
> > > If DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is 1,read the DP_DP13_DPCD_REV
> > > to
> > > get the faster capability.
> > > If DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is 0,read DP_DPCD_REV.
> > >
> > > Signed-off-by: Koba Ko <koba.ko@canonical.com>
> > > Reviewed-by: Lyude Paul <lyude@redhat.com>
> > > ---
> > > drivers/gpu/drm/drm_dp_mst_topology.c | 6 +++---
> > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c
> > > b/drivers/gpu/drm/drm_dp_mst_topology.c
> > > index e87542533640..63f8809b9aa4 100644
> > > --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> > > +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> > > @@ -3686,9 +3686,9 @@ int drm_dp_mst_topology_mgr_set_mst(struct
> > > drm_dp_mst_topology_mgr *mgr, bool ms
> > > WARN_ON(mgr->mst_primary);
> > >
> > > /* get dpcd info */
> > > - ret = drm_dp_dpcd_read(mgr->aux, DP_DPCD_REV, mgr->dpcd,
> > > DP_RECEIVER_CAP_SIZE);
> > > - if (ret != DP_RECEIVER_CAP_SIZE) {
> > > - DRM_DEBUG_KMS("failed to read DPCD\n");
> > > + ret = drm_dp_read_dpcd_caps(mgr->aux, mgr->dpcd);
> > > + if (ret < 0) {
> > > + drm_dbg_kms(mgr->dev, "failed to read DPCD, ret
> > > %d\n",
> > > ret);
> > > goto out_unlock;
> > > }
> > >
> > --
> > Cheers,
> > Lyude Paul (she/her)
> > Software Engineer at Red Hat
> >
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
prev parent reply other threads:[~2020-09-23 14:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 6:53 [PATCH V4] drm/dp_mst: Retrieve extended DPCD caps for topology manager Koba Ko
2020-09-22 18:01 ` Lyude Paul
2020-09-23 2:16 ` Koba Ko
2020-09-23 14:17 ` Lyude Paul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a4f2216cb621f349aa393de5d64763e4a23bc2b.camel@redhat.com \
--to=lyude@redhat.com \
--cc=airlied@linux.ie \
--cc=anthony.wong@canonical.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=koba.ko@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).