From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Kees Cook <keescook@chromium.org>
Cc: Dave Jones <davej@codemonkey.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-nfs@vger.kernel.org, linux-hardening@vger.kernel.org,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Scott Mayhew <smayhew@redhat.com>,
Anna Schumaker <anna@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: 6.1rc1: NFS memcpy warning on mount
Date: Mon, 17 Oct 2022 11:20:24 +0700 [thread overview]
Message-ID: <9bf36e3a-f718-ec96-3759-e8f17fe025f3@gmail.com> (raw)
In-Reply-To: <202210162113.1A948FEAB@keescook>
On 10/17/22 11:17, Kees Cook wrote:
> On Mon, Oct 17, 2022 at 10:58:55AM +0700, Bagas Sanjaya wrote:
>> On Sun, Oct 16, 2022 at 10:58:21PM -0400, Dave Jones wrote:
>>> Started getting this during mount on a 6.1rc1 kernel..
>>> not sure which mount it's complaining about, but they're all v3 tcp
>>> mounts on that machine.
>>>
>>> [ 19.617475] memcpy: detected field-spanning write (size 28) of single field "request.sap" at fs/nfs/super.c:857 (size 18446744073709551615)
>> [...]
>> Hmm, the blamed line in the warning is introduced by 38465f5d1af932 ("NFS:
>> rename nfs_fs_context pointer arg in a few functions"). Cc: the commit
>> author. Also Cc: Kees for authoring the patch [1] that have fixed
>> similar warning.
>
> The warning is from commit 54d9469bc515 ("fortify: Add run-time WARN
> for cross-field memcpy()")
>
>> Also, does v6.0 have this warning? If so, you need to bisect in the range
>> of v6.0..v6.1-rc1.
>
> No need for bisection -- this is almost certainly a false positive (as
> detailed in the above commit: we're working on purging all of these
> cases from the kernel).
>
>> [1]: https://lore.kernel.org/lkml/20221011065243.583650-1-keescook@chromium.org/
>
> Yeah, I have a v2 of this patch, which should also fix this request.sap
> issue. Sending shortly...
>
OK, thanks!
--
An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2022-10-17 4:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-16 23:01 Linux 6.1-rc1 Linus Torvalds
2022-10-17 1:53 ` linux-next: stats for 6.1-rc1 (was: Linux 6.1-rc1) Stephen Rothwell
2022-10-17 2:58 ` 6.1rc1: NFS memcpy warning on mount Dave Jones
2022-10-17 3:58 ` Bagas Sanjaya
2022-10-17 4:17 ` Kees Cook
2022-10-17 4:20 ` Bagas Sanjaya [this message]
2022-10-17 4:57 ` Kees Cook
2022-10-17 12:34 ` Linux 6.1-rc1 Guenter Roeck
2022-10-17 17:39 ` Linus Torvalds
2022-10-17 18:28 ` Guenter Roeck
2022-10-17 18:54 ` Conor Dooley
2022-10-18 0:03 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bf36e3a-f718-ec96-3759-e8f17fe025f3@gmail.com \
--to=bagasdotme@gmail.com \
--cc=anna@kernel.org \
--cc=davej@codemonkey.org.uk \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=smayhew@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).