From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
Vlastimil Babka <vbabka@suse.cz>,
Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] mm/thp: Make ALLOC_SPLIT_PTLOCKS dependent on USE_SPLIT_PTE_PTLOCKS
Date: Thu, 1 Jul 2021 10:51:27 +0530 [thread overview]
Message-ID: <9d1ce685-e0fd-febd-5ff2-179f7fa6e3fa@arm.com> (raw)
In-Reply-To: <YKZFRPqg4wKjOdVg@casper.infradead.org>
On 5/20/21 4:47 PM, Matthew Wilcox wrote:
> On Wed, May 19, 2021 at 01:03:06PM +0530, Anshuman Khandual wrote:
>> Split ptlocks need not be defined and allocated unless they are being used.
>> ALLOC_SPLIT_PTLOCKS is inherently dependent on USE_SPLIT_PTE_PTLOCKS. This
>> just makes it explicit and clear. While here drop the spinlock_t element
>> from the struct page when USE_SPLIT_PTE_PTLOCKS is not enabled.
>
> I didn't spot this email yesterday. I'm not a fan. Isn't struct page
> already complicated enough without adding another ifdef to it? Surely
> there's a better way than this.
This discussion thread just got dropped off the radar, sorry about it.
None of the spinlock_t elements are required unless split ptlocks are
in use. I understand your concern regarding yet another #ifdef in the
struct page definition. But this change is simple and minimal. Do you
have any other particular alternative in mind which I could explore ?
>
>> +++ b/include/linux/mm_types.h
>> @@ -152,10 +152,12 @@ struct page {
>> struct mm_struct *pt_mm; /* x86 pgds only */
>> atomic_t pt_frag_refcount; /* powerpc */
>> };
>> +#if USE_SPLIT_PTE_PTLOCKS
>> #if ALLOC_SPLIT_PTLOCKS
>> spinlock_t *ptl;
>> #else
>> spinlock_t ptl;
>> +#endif
>> #endif
>> };
>> struct { /* ZONE_DEVICE pages */
next prev parent reply other threads:[~2021-07-01 5:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 7:33 [PATCH V2] mm/thp: Make ALLOC_SPLIT_PTLOCKS dependent on USE_SPLIT_PTE_PTLOCKS Anshuman Khandual
2021-05-20 11:17 ` Matthew Wilcox
2021-07-01 5:21 ` Anshuman Khandual [this message]
2021-07-01 12:57 ` Matthew Wilcox
2021-07-05 3:27 ` Anshuman Khandual
2021-07-05 3:28 ` Matthew Wilcox
2021-07-05 3:39 ` Anshuman Khandual
2021-07-05 11:30 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d1ce685-e0fd-febd-5ff2-179f7fa6e3fa@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rdunlap@infradead.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).