From: YueHaibing <yuehaibing@huawei.com>
To: Arnd Bergmann <arnd@arndb.de>, "David S. Miller" <davem@davemloft.net>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] appletalk: Fix compile regression
Date: Wed, 6 Mar 2019 10:24:09 +0800 [thread overview]
Message-ID: <9d4884eb-eee7-334f-801c-e3089d296308@huawei.com> (raw)
In-Reply-To: <20190305132430.3821758-1-arnd@arndb.de>
On 2019/3/5 21:24, Arnd Bergmann wrote:
> A bugfix just broke compilation of appletalk when CONFIG_SYSCTL
> is disabled:
>
> In file included from net/appletalk/ddp.c:65:
> net/appletalk/ddp.c: In function 'atalk_init':
> include/linux/atalk.h:164:34: error: expected expression before 'do'
> #define atalk_register_sysctl() do { } while(0)
> ^~
> net/appletalk/ddp.c:1934:7: note: in expansion of macro 'atalk_register_sysctl'
> rc = atalk_register_sysctl();
>
> This is easier to avoid by using conventional inline functions
> as stubs rather than macros. The header already has inline
> functions for other purposes, so I'm changing over all the
> macros for consistency.
>
Thank you for fix this
> Fixes: 6377f787aeb9 ("appletalk: Fix use-after-free in atalk_proc_exit")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> include/linux/atalk.h | 18 ++++++++++++++----
> 1 file changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/include/linux/atalk.h b/include/linux/atalk.h
> index 5a90f28d5ff2..d5cfc0b15b76 100644
> --- a/include/linux/atalk.h
> +++ b/include/linux/atalk.h
> @@ -161,16 +161,26 @@ extern int sysctl_aarp_resolve_time;
> extern int atalk_register_sysctl(void);
> extern void atalk_unregister_sysctl(void);
> #else
> -#define atalk_register_sysctl() do { } while(0)
> -#define atalk_unregister_sysctl() do { } while(0)
> +static inline int atalk_register_sysctl(void)
> +{
> + return 0;
> +}
> +static inline void atalk_unregister_sysctl(void)
> +{
> +}
> #endif
>
> #ifdef CONFIG_PROC_FS
> extern int atalk_proc_init(void);
> extern void atalk_proc_exit(void);
> #else
> -#define atalk_proc_init() ({ 0; })
> -#define atalk_proc_exit() do { } while(0)
> +static inline int atalk_proc_init(void)
> +{
> + return 0;
> +}
> +static inline void atalk_proc_exit(void)
> +{
> +}
> #endif /* CONFIG_PROC_FS */
>
> #endif /* __LINUX_ATALK_H__ */
>
prev parent reply other threads:[~2019-03-06 2:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 13:24 [PATCH] appletalk: Fix compile regression Arnd Bergmann
2019-03-05 21:00 ` David Miller
2019-03-06 2:24 ` YueHaibing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d4884eb-eee7-334f-801c-e3089d296308@huawei.com \
--to=yuehaibing@huawei.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).