From: Jon Hunter <jonathanh@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Cc: <linux-pm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 3/5] ARM: tegra: Create tegra20-cpufreq device on Tegra30
Date: Wed, 17 Oct 2018 09:49:40 +0100 [thread overview]
Message-ID: <9ec51c2d-02f6-0988-0940-0ec31d22f697@nvidia.com> (raw)
In-Reply-To: <20180830194356.14059-4-digetx@gmail.com>
On 30/08/2018 20:43, Dmitry Osipenko wrote:
> Tegra20-cpufreq driver require a platform device in order to be loaded,
> instantiate a simple platform device for the driver during of the machines
> late initialization. Driver now supports Tegra30 SoC's, hence create the
> device on Tegra30 machines.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> arch/arm/mach-tegra/tegra.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/mach-tegra/tegra.c b/arch/arm/mach-tegra/tegra.c
> index 67d8ae60ac67..b559e22eab76 100644
> --- a/arch/arm/mach-tegra/tegra.c
> +++ b/arch/arm/mach-tegra/tegra.c
> @@ -111,6 +111,10 @@ static void __init tegra_dt_init_late(void)
> if (IS_ENABLED(CONFIG_ARCH_TEGRA_2x_SOC) &&
> of_machine_is_compatible("nvidia,tegra20"))
> platform_device_register_simple("tegra20-cpufreq", -1, NULL, 0);
> +
> + if (IS_ENABLED(CONFIG_ARCH_TEGRA_3x_SOC) &&
> + of_machine_is_compatible("nvidia,tegra30"))
> + platform_device_register_simple("tegra20-cpufreq", -1, NULL, 0);
> }
>
> static const char * const tegra_dt_board_compat[] = {
Not sure why you would do this if now the driver only works with DT. Am
I missing something?
Cheers
Jon
--
nvpublic
next prev parent reply other threads:[~2018-10-17 8:49 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 19:43 [PATCH v1 0/5] CPUFREQ OPP's and Tegra30 support by tegra20-cpufreq driver Dmitry Osipenko
2018-08-30 19:43 ` [PATCH v1 1/5] dt-bindings: cpufreq: Add binding for NVIDIA Tegra20/30 Dmitry Osipenko
2018-09-25 16:58 ` Rob Herring
2018-09-25 17:29 ` Dmitry Osipenko
2018-09-25 19:36 ` Rob Herring
2018-09-25 21:57 ` Dmitry Osipenko
2018-10-17 8:40 ` Jon Hunter
2018-10-17 12:37 ` Dmitry Osipenko
2018-10-17 12:42 ` Dmitry Osipenko
2018-10-17 12:59 ` Jon Hunter
2018-10-17 13:07 ` Dmitry Osipenko
2018-10-17 13:34 ` Jon Hunter
2018-10-17 13:46 ` Dmitry Osipenko
2018-10-17 14:14 ` Jon Hunter
2018-10-17 14:43 ` Dmitry Osipenko
2018-10-17 19:29 ` Jon Hunter
2018-10-17 20:57 ` Dmitry Osipenko
2018-08-30 19:43 ` [PATCH v1 2/5] cpufreq: tegra20: Support OPP, thermal cooling and Tegra30 Dmitry Osipenko
2018-10-17 8:47 ` Jon Hunter
2018-08-30 19:43 ` [PATCH v1 3/5] ARM: tegra: Create tegra20-cpufreq device on Tegra30 Dmitry Osipenko
2018-10-17 8:49 ` Jon Hunter [this message]
2018-10-17 9:54 ` Jon Hunter
2018-10-17 12:02 ` Dmitry Osipenko
2018-08-30 19:43 ` [PATCH v1 4/5] ARM: dts: tegra20: Add CPU Operating Performance Points Dmitry Osipenko
2018-08-30 19:43 ` [PATCH v1 5/5] ARM: dts: tegra30: " Dmitry Osipenko
2018-09-06 12:35 ` [PATCH v1 0/5] CPUFREQ OPP's and Tegra30 support by tegra20-cpufreq driver Marcel Ziswiler
2018-09-07 16:59 ` Dmitry Osipenko
2018-09-11 8:27 ` Marcel Ziswiler
2018-09-14 10:30 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ec51c2d-02f6-0988-0940-0ec31d22f697@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pdeschrijver@nvidia.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).