From: Sourabh Jain <sourabhjain@linux.ibm.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: mpe@ellerman.id.au, mahesh@linux.vnet.ibm.com,
hbathini@linux.ibm.com, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, corbet@lwn.net,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v4 3/6] powerpc/fadump: reorganize /sys/kernel/fadump_* sysfs files
Date: Sat, 7 Dec 2019 00:43:06 +0530 [thread overview]
Message-ID: <9efa9a4b-b0ce-f9b7-88b0-a74a767bbe81@linux.ibm.com> (raw)
In-Reply-To: <20191206124508.GA1360047@kroah.com>
On 12/6/19 6:15 PM, Greg KH wrote:
> On Fri, Dec 06, 2019 at 05:54:31PM +0530, Sourabh Jain wrote:
>> +static struct kobj_attribute release_attr = __ATTR(release_mem,
>> 0200, NULL,
>> fadump_release_memory_store);
>> -static struct kobj_attribute fadump_attr = __ATTR(fadump_enabled,
>> +static struct kobj_attribute enable_attr = __ATTR(enabled,
>> 0444, fadump_enabled_show,
>> NULL);
>
> __ATTR_RO()?
>
>> -static struct kobj_attribute fadump_register_attr = __ATTR(fadump_registered,
>> +static struct kobj_attribute register_attr = __ATTR(registered,
>> 0644, fadump_register_show,
>> fadump_register_store);
>
> __ATTR_RW()?
Thanks I was not aware of these macros.
>
> And then use an ATTRIBUTE_GROUP() macro to create a group so that you
> then can do:
>
>> @@ -1452,11 +1450,47 @@ static void fadump_init_files(void)
>> printk(KERN_ERR "fadump: unable to create debugfs file"
>> " fadump_region\n");
>>
>> + rc = sysfs_create_file(fadump_kobj, &enable_attr.attr);
>> + if (rc)
>> + pr_err("unable to create enabled sysfs file (%d)\n",
>> + rc);
>> + rc = sysfs_create_file(fadump_kobj, ®ister_attr.attr);
>> + if (rc)
>> + pr_err("unable to create registered sysfs file (%d)\n",
>> + rc);
>> + if (fw_dump.dump_active) {
>> + rc = sysfs_create_file(fadump_kobj, &release_attr.attr);
>> + if (rc)
>> + pr_err("unable to create release_mem sysfs file (%d)\n",
>> + rc);
>> + }
>
> a single call to sysfs_create_groups() here instead of trying to unwind
> the mess if something went wrong.
>
Sure, I will replace the individual calls with a single group call.
Thanks,
Sourabh Jain
next prev parent reply other threads:[~2019-12-06 19:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 12:24 [PATCH v4 0/6] reorganize and add FADump sysfs files Sourabh Jain
2019-12-06 12:24 ` [PATCH v4 1/6] Documentation/ABI: add ABI documentation for /sys/kernel/fadump_* Sourabh Jain
2019-12-06 12:47 ` Greg KH
2019-12-06 12:24 ` [PATCH v4 2/6] sysfs: wrap __compat_only_sysfs_link_entry_to_kobj function to change the symlink name Sourabh Jain
2019-12-06 12:46 ` Greg KH
2019-12-06 18:27 ` Sourabh Jain
2019-12-06 19:14 ` Greg KH
2019-12-07 3:21 ` Sourabh Jain
2019-12-06 12:24 ` [PATCH v4 3/6] powerpc/fadump: reorganize /sys/kernel/fadump_* sysfs files Sourabh Jain
2019-12-06 12:45 ` Greg KH
2019-12-06 19:13 ` Sourabh Jain [this message]
2019-12-06 12:24 ` [PATCH v4 4/6] powerpc/powernv: move core and fadump_release_opalcore under new kobject Sourabh Jain
2019-12-06 12:48 ` Greg KH
2019-12-06 19:16 ` Sourabh Jain
2019-12-06 12:24 ` [PATCH v4 5/6] Documentation/ABI: mark /sys/kernel/fadump_* sysfs files deprecated Sourabh Jain
2019-12-06 12:24 ` [PATCH v4 6/6] powerpc/fadump: sysfs for fadump memory reservation Sourabh Jain
2019-12-06 12:48 ` Greg KH
2019-12-06 19:19 ` Sourabh Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9efa9a4b-b0ce-f9b7-88b0-a74a767bbe81@linux.ibm.com \
--to=sourabhjain@linux.ibm.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=hbathini@linux.ibm.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).