From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, broonie@kernel.org
Cc: alsa-devel@alsa-project.org, ckeepax@opensource.cirrus.com,
tiwai@suse.com, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, vkoul@kernel.org
Subject: Re: [PATCH 03/11] ASoC: q6asm: make commands specific to streams
Date: Tue, 7 Jul 2020 11:52:33 -0500 [thread overview]
Message-ID: <9ff595b4-1093-36c8-f27f-f097e24657a0@linux.intel.com> (raw)
In-Reply-To: <20200707163641.17113-4-srinivas.kandagatla@linaro.org>
> @@ -184,8 +186,8 @@ static void event_handler(uint32_t opcode, uint32_t token,
> switch (opcode) {
> case ASM_CLIENT_EVENT_CMD_RUN_DONE:
> if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
> - q6asm_write_async(prtd->audio_client,
> - prtd->pcm_count, 0, 0, NO_TIMESTAMP);
> + q6asm_write_async(prtd->audio_client, prtd->stream_id,
> + prtd->pcm_count, 0, 0, 0);
sound/soc/qcom/qdsp6/q6asm.h:#define NO_TIMESTAMP 0xFF00
is the change on the previous line intentional?
> break;
> case ASM_CLIENT_EVENT_CMD_EOS_DONE:
> prtd->state = Q6ASM_STREAM_STOPPED;
> @@ -194,8 +196,8 @@ static void event_handler(uint32_t opcode, uint32_t token,
> prtd->pcm_irq_pos += prtd->pcm_count;
> snd_pcm_period_elapsed(substream);
> if (prtd->state == Q6ASM_STREAM_RUNNING)
> - q6asm_write_async(prtd->audio_client,
> - prtd->pcm_count, 0, 0, NO_TIMESTAMP);
> + q6asm_write_async(prtd->audio_client, prtd->stream_id,
> + prtd->pcm_count, 0, 0, 0);
ditto for the timestamp change?
> @@ -501,8 +514,8 @@ static void compress_event_handler(uint32_t opcode, uint32_t token,
> case ASM_CLIENT_EVENT_CMD_RUN_DONE:
> spin_lock_irqsave(&prtd->lock, flags);
> if (!prtd->bytes_sent) {
> - q6asm_write_async(prtd->audio_client, prtd->pcm_count,
> - 0, 0, NO_TIMESTAMP);
> + q6asm_write_async(prtd->audio_client, prtd->stream_id,
> + prtd->pcm_count, 0, 0, 0);
and here as well.
> prtd->bytes_sent += prtd->pcm_count;
> }
>
> @@ -527,8 +540,8 @@ static void compress_event_handler(uint32_t opcode, uint32_t token,
> avail = prtd->bytes_received - prtd->bytes_sent;
>
> if (avail >= prtd->pcm_count) {
> - q6asm_write_async(prtd->audio_client,
> - prtd->pcm_count, 0, 0, NO_TIMESTAMP);
> + q6asm_write_async(prtd->audio_client, prtd->stream_id,
> + prtd->pcm_count, 0, 0, 0);
and here.
next prev parent reply other threads:[~2020-07-07 19:26 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 16:36 [PATCH 00/11] ASoC: qdsp6: add gapless compressed audio support Srinivas Kandagatla
2020-07-07 16:36 ` [PATCH 01/11] ASoC: q6asm: add command opcode to timeout error report Srinivas Kandagatla
2020-07-07 16:36 ` [PATCH 02/11] ASoC: q6asm: rename misleading session id variable Srinivas Kandagatla
2020-07-07 16:36 ` [PATCH 03/11] ASoC: q6asm: make commands specific to streams Srinivas Kandagatla
2020-07-07 16:52 ` Pierre-Louis Bossart [this message]
2020-07-08 9:44 ` Srinivas Kandagatla
2020-07-08 13:13 ` Mark Brown
2020-07-08 15:26 ` Srinivas Kandagatla
2020-07-07 16:36 ` [PATCH 04/11] ASoC: q6asm: use flags directly from asm-dai Srinivas Kandagatla
2020-07-07 16:36 ` [PATCH 05/11] ASoC: q6asm: add length to write command token Srinivas Kandagatla
2020-07-07 16:36 ` [PATCH 06/11] ASoC: q6asm: add support to remove intial and trailing silence Srinivas Kandagatla
2020-07-07 16:55 ` Pierre-Louis Bossart
2020-07-08 9:44 ` Srinivas Kandagatla
2020-07-07 16:36 ` [PATCH 07/11] ASoC: q6asm: add support to gapless flag in asm open Srinivas Kandagatla
2020-07-07 16:57 ` Pierre-Louis Bossart
2020-07-08 9:44 ` Srinivas Kandagatla
2020-07-07 16:36 ` [PATCH 08/11] ASoC: q6asm-dai: add next track metadata support Srinivas Kandagatla
2020-07-07 16:36 ` [PATCH 09/11] ASoC: qdsp6: use dev_err instead of pr_err Srinivas Kandagatla
2020-07-07 16:36 ` [PATCH 10/11] ASoC: qdsp6-dai: add gapless support Srinivas Kandagatla
2020-07-07 17:07 ` Pierre-Louis Bossart
2020-07-08 9:44 ` Srinivas Kandagatla
2020-07-08 13:32 ` Pierre-Louis Bossart
2020-07-08 13:42 ` Mark Brown
2020-07-08 15:23 ` Srinivas Kandagatla
2020-07-08 16:58 ` Pierre-Louis Bossart
2020-07-07 16:36 ` [PATCH 11/11] ASoC: q6asm-dai: add support to copy callback Srinivas Kandagatla
2020-07-08 13:32 ` [PATCH 00/11] ASoC: qdsp6: add gapless compressed audio support Mark Brown
2020-07-08 15:24 ` Srinivas Kandagatla
2020-07-08 16:59 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ff595b4-1093-36c8-f27f-f097e24657a0@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).