From: "Kim, Milo" <Milo.Kim@ti.com>
To: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
Anton Vorontsov <anton.vorontsov@linaro.org>
Subject: [PATCH 0/8] lp8727_charger: cleanup code
Date: Thu, 30 Aug 2012 11:37:16 +0000 [thread overview]
Message-ID: <A874F61F95741C4A9BA573A70FE3998F41EF1C6B@DQHE02.ent.ti.com> (raw)
LP8727 driver should be patched for several reasons.
(a) Need to clean up _probe()/_remove()
(b) Not secure code when the platform data is NULL
(c) Interrupt handling
Two threads are running for handling one IRQ.
One is for the IRQ pin, the other is used for delayed processing.
This is unusual and can be enhanced.
(d) Misuse of mutex code
(e) Lots of definitions should be fixed
(f) Others..
Bunch of code patches are as below.
[PATCH 1/8] lp8727_charger: use devm_kzalloc() rather than
kzalloc()/kfree()
[PATCH 2/8] lp8727_charger: cleanup _probe() and _remove()
[PATCH 3/8] lp8727_charger: fix buggy code when the platform data is
NULL
[PATCH 4/8] lp8727_charger: cleanup the interrupt handler code
[PATCH 5/8] lp8727_charger: move the mutex code
[PATCH 6/8] lp8727_charger: fix code for getting battery temperature
[PATCH 7/8] lp8727_charger: cleanup definitions
[PATCH 8/8] lp8727_charger: make cosmetic code
Best Regards,
Milo
next reply other threads:[~2012-08-30 11:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 11:37 Kim, Milo [this message]
2012-08-30 12:15 ` [PATCH 0/8] lp8727_charger: cleanup code Anton Vorontsov
2012-08-30 22:59 ` Kim, Milo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A874F61F95741C4A9BA573A70FE3998F41EF1C6B@DQHE02.ent.ti.com \
--to=milo.kim@ti.com \
--cc=anton.vorontsov@linaro.org \
--cc=cbouatmailru@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).