From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751427AbcFXFf1 (ORCPT ); Fri, 24 Jun 2016 01:35:27 -0400 Received: from mail-am1on0099.outbound.protection.outlook.com ([157.56.112.99]:29167 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750979AbcFXFf0 convert rfc822-to-8bit (ORCPT ); Fri, 24 Jun 2016 01:35:26 -0400 X-Greylist: delayed 3626 seconds by postgrey-1.27 at vger.kernel.org; Fri, 24 Jun 2016 01:35:25 EDT From: Qiang Zhao To: David Miller CC: "oss@buserror.net" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , Xiaobo Xie Subject: RE: [PATCH] Maxim/driver: Add driver for maxim ds26522 Thread-Topic: [PATCH] Maxim/driver: Add driver for maxim ds26522 Thread-Index: AQHRzO1qS+Ii6lwNLU6kJ/OtLNFrl5/3JcOAgAC22bA= Date: Fri, 24 Jun 2016 02:00:33 +0000 Message-ID: References: <1466644185-6081-1-git-send-email-qiang.zhao@nxp.com> <20160623.105915.1184538161171070695.davem@davemloft.net> In-Reply-To: <20160623.105915.1184538161171070695.davem@davemloft.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=qiang.zhao@nxp.com; x-originating-ip: [199.59.225.131] x-ms-office365-filtering-correlation-id: 30e1536f-a0e3-483f-559d-08d39bd353e8 x-microsoft-exchange-diagnostics: 1;AM3PR04MB1187;6:RneJHniS47QsVER7Mg0Z8r4Zw72HrnVlJZeZTLPXBnHUMOFXdu6LyHqG+q6x03IhPJSZkWcdgsr/nJDnJN0XUd+u+lRX/uU82/XCYXdvMs9E08DrVLpZw5LHM9Dpw5JKA4JFgM+TGrfohcudshhJbO+kV5wP5GtPBu6MqHxrMhPgVYM8rqM+Jg+fiLNHy3wK+QoMIDInUWSnkywO3FjGLDMlB5QAXHK6x5GJUfmG2S02KkdNa4zINIz02EPo2hujoY5RRbf0PC/Za9q619Y6fqVmzofIl5gVdbCuonJ515a47gi1inwwkzNvEkyTPVHiOlhRiEaXtzg+48gbhk8hL5c5T5bkpLZ0oXvK6lNryUE=;5:oSfGw9aLBmv7Kj8wxV3YOlnwl3i5tSeV7mxzuqE7nPGnF1Hj7A0TSddthbVf5Ir1hmmbi6WwKaDEmvFcznveXdWCfKxDpkkwRWE8TsZ3RX++PuADBf9OpYsph7hp9uAI4etBkDdWQeeCqJmb06cL8A==;24:TmA3AgiKSdJ6TpJkYpQwiHg8fvOkf5JmUsqqEHRA5zGttUfCKSLdWEZrrKqgdIYd4V4xc0nI91HJU7w/gjN8dSD0XI5uT5nhA1TBfNTVuYQ=;7:vB0ic7FkDzgLpdsEjvUSvdiG5HZCdfhYHwyhl/6qQ4kqqWwUT426+5XTbPzUzpUFSRKKX2CB5zmkxM4tfLLuiFsuljUVirUXfSZU2RE7rqb+6BXTfb/iBxBV9Lze3gdiPgtQpGfdm/3W4xwvtJR4IhHOftPIb6lCUKR750k5+pCfVeRwZUfkE7VIbbbc0nw75oB0ytXobRz7zA3C/DPVJ6VwFHK/rBxdGdwv0ijhtoj9LRqgN1c+RwPp0XDPOG2jceyuS23+o21JZ/TK03+dZw== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM3PR04MB1187; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(185117386973197); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:AM3PR04MB1187;BCL:0;PCL:0;RULEID:;SRVR:AM3PR04MB1187; x-forefront-prvs: 0983EAD6B2 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(377454003)(189002)(199003)(377424004)(13464003)(24454002)(7736002)(7696003)(5003600100003)(305945005)(7846002)(68736007)(76576001)(81166006)(81156014)(97736004)(74316001)(106116001)(8676002)(106356001)(3660700001)(345774005)(189998001)(3280700002)(9686002)(8936002)(110136002)(19580405001)(19580395003)(101416001)(87936001)(50986999)(2906002)(76176999)(66066001)(54356999)(2950100001)(4326007)(5002640100001)(33656002)(105586002)(5250100002)(2900100001)(92566002)(86362001)(6116002)(3846002)(586003)(102836003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR04MB1187;H:AM3PR04MB1185.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jun 2016 02:00:33.3268 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR04MB1187 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-06-23 at 10:59PM, David Miller wrote: > -----Original Message----- > From: David Miller [mailto:davem@davemloft.net] > Sent: Thursday, June 23, 2016 10:59 PM > To: Qiang Zhao > Cc: oss@buserror.net; linux-kernel@vger.kernel.org; netdev@vger.kernel.org; > Xiaobo Xie > Subject: Re: [PATCH] Maxim/driver: Add driver for maxim ds26522 > > From: Zhao Qiang > Date: Thu, 23 Jun 2016 09:09:45 +0800 > > > +MODULE_DESCRIPTION(DRV_DESC); > > There is no definition of DRV_DESC, so this makes it look like you didn't even > compile this driver. I really, really compiled this driver. Thank you for your review and comments. I will modify it the next version. [zhaoqiang@titan:~/upstream/linux]$ll drivers/net/wan/slic_ds26522.o -rw-r--r-- 1 zhaoqiang klocwork 153288 Jun 22 15:48 drivers/net/wan/slic_ds26522.o [zhaoqiang@titan:~/upstream/linux]$date Fri Jun 24 09:42:16 CST 2016 -Zhao Qiang BR