linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Xiaowei Bao <xiaowei.bao@nxp.com>
To: Shawn Guo <shawnguo@kernel.org>, Ashish Kumar <ashish.kumar@nxp.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"robh@kernel.org" <robh@kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] arm64: dts: ls1028a: Add FlexSPI support for NXP LS1028
Date: Tue, 8 Oct 2019 08:03:03 +0000	[thread overview]
Message-ID: <AM5PR04MB32996FD54858CCF141CBC218F59A0@AM5PR04MB3299.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20191006032019.GP7150@dragon>



> -----Original Message-----
> From: Shawn Guo <shawnguo@kernel.org>
> Sent: 2019年10月6日 11:20
> To: Ashish Kumar <ashish.kumar@nxp.com>
> Cc: devicetree@vger.kernel.org; robh@kernel.org; mark.rutland@arm.com;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Xiaowei
> Bao <xiaowei.bao@nxp.com>
> Subject: Re: [PATCH] arm64: dts: ls1028a: Add FlexSPI support for NXP LS1028
> 
> On Tue, Sep 10, 2019 at 05:50:51PM +0530, Ashish Kumar wrote:
> > Add fspi node property for LS1028A SoC for FlexSPI driver.
> > Property added for FlexSPI controller and for the connected slave
> > device for the LS1028ARDB and LS1028AQDS target.
> > RDB and QDS is having one SPI-NOR flash device, mt35xu02g connected at
> > CS0.
> > This flash device "mt35xu02g" is tested for octal read
> >
> > Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com>
> > Signed-off-by: Ashish Kumar <Ashish.Kumar@nxp.com>
> 
> When you send a patch series, the patches should be numbered properly and
> preferably with a cover-letter.

Got it, thanks.

Thanks
Xiaowei

> 
> > ---
> >  arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 15
> > +++++++++++++++  arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts |
> 15 +++++++++++++++
> >  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi    | 13 +++++++++++++
> >  3 files changed, 43 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > index 5e14e5a..5d46993 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > @@ -103,6 +103,21 @@
> >  	status = "okay";
> >  };
> >
> > +&fspi {
> > +	status = "okay";
> 
> Have a newline between properties and child node..
> 
> > +	flash0: mt35xu02g@0 {
> 
> Use a generic node name and specific label name.
> 
> > +		compatible = "micron,mt35xu02g", "jedec,spi-nor";
> 
> "micron,mt35xu02g" is undocumented.
> 
> Shawn
> 
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> > +		m25p,fast-read;
> > +		spi-max-frequency = <50000000>;
> > +		reg = <0>;
> > +		/* The following setting enables 1-1-8 (CMD-ADDR-DATA) mode */
> > +		spi-rx-bus-width = <8>; /* 8 SPI Rx lines */
> > +		spi-tx-bus-width = <1>; /* 1 SPI Tx line */
> > +	};
> > +};
> > +
> >  &i2c0 {
> >  	status = "okay";
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > index 1a69221..f33cb2e 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > @@ -96,6 +96,21 @@
> >  	status = "okay";
> >  };
> >
> > +&fspi {
> > +	status = "okay";
> > +	flash0: mt35xu02g@0 {
> > +		compatible = "micron,mt35xu02g", "jedec,spi-nor";
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> > +		m25p,fast-read;
> > +		spi-max-frequency = <50000000>;
> > +		reg = <0>;
> > +		/* The following setting enables 1-1-8 (CMD-ADDR-DATA) mode */
> > +		spi-rx-bus-width = <8>; /* 8 SPI Rx lines */
> > +		spi-tx-bus-width = <1>; /* 1 SPI Tx line */
> > +	};
> > +};
> > +
> >  &i2c0 {
> >  	status = "okay";
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > index b139b29..4aa1825 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > @@ -174,6 +174,19 @@
> >  			clocks = <&sysclk>;
> >  		};
> >
> > +		fspi: spi@20c0000 {
> > +			compatible = "nxp,lx2160a-fspi";
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +			reg = <0x0 0x20c0000 0x0 0x10000>,
> > +			      <0x0 0x20000000 0x0 0x10000000>;
> > +			reg-names = "fspi_base", "fspi_mmap";
> > +			interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
> > +			clocks = <&clockgen 4 3>, <&clockgen 4 3>;
> > +			clock-names = "fspi_en", "fspi";
> > +			status = "disabled";
> > +		};
> > +
> >  		i2c0: i2c@2000000 {
> >  			compatible = "fsl,vf610-i2c";
> >  			#address-cells = <1>;
> > --
> > 2.7.4
> >

      reply	other threads:[~2019-10-08  8:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-10 12:20 [PATCH] arm64: dts: ls1028a: Add FlexSPI support for NXP LS1028 Ashish Kumar
2019-09-10 12:20 ` [PATCH] arm64: dts: ls1046a: Add QSPI node for ls1046afrwy Ashish Kumar
2019-09-10 12:20 ` [PATCH] arm64: dts: ls1046a: Append missing properties of QSPI node on ls1046ardb Ashish Kumar
2019-09-10 12:20 ` [PATCH] arm64: dts: ls1088a: Add QSPI support for NXP LS1088 Ashish Kumar
2019-09-10 12:20 ` [PATCH] arm64: dts: ls208x: Remove non-compatible driver device from qspi node Ashish Kumar
2019-10-06  3:20 ` [PATCH] arm64: dts: ls1028a: Add FlexSPI support for NXP LS1028 Shawn Guo
2019-10-08  8:03   ` Xiaowei Bao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM5PR04MB32996FD54858CCF141CBC218F59A0@AM5PR04MB3299.eurprd04.prod.outlook.com \
    --to=xiaowei.bao@nxp.com \
    --cc=ashish.kumar@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).