From: Clark Wang <xiaoning.wang@nxp.com>
To: Joe Perches <joe@perches.com>, "broonie@kernel.org" <broonie@kernel.org>
Cc: "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH V3 1/4] spi: lpspi: Replace all "master" with "controller"
Date: Sat, 8 Dec 2018 05:42:46 +0000 [thread overview]
Message-ID: <AM6PR04MB5016114544649016E2090094F3AB0@AM6PR04MB5016.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1bb3bde9a47a3ca8a026fab9e6af420c1ae59f97.camel@perches.com>
Hi Joe,
This patch series adds slave mode for lpspi controller. So this driver can support both master and slave mode for lpspi controller after apply this patch series. Currently, both master mode and slave mode share the code in this driver. Therefore, using spi_master to represent the structure of slave mode will cause confusion.
When Geert Uytterhoeven add the slave support for spi, he had done " Generalize SPI 'master' to 'controller'" step, too. The commit ID is 8caab75fd2c2a92667cbb1cd315720bede3feaa9.
Thank you.
Regards,
Clark Wang
> -----Original Message-----
> From: Joe Perches <joe@perches.com>
> Sent: Saturday, December 8, 2018 13:14
> To: Clark Wang <xiaoning.wang@nxp.com>; broonie@kernel.org
> Cc: linux-spi@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH V3 1/4] spi: lpspi: Replace all "master" with "controller"
>
> On Fri, 2018-12-07 at 02:50 +0000, Clark Wang wrote:
> > In order to enable the slave mode and make the code more readable,
> > replace all related structure names and object names which is named
> > "master" with "controller".
>
> In what sense does this make the code more readable?
>
next prev parent reply other threads:[~2018-12-08 5:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 2:50 [PATCH V3 0/4] spi: lpspi: Add Slave Mode support for LPSPI Clark Wang
2018-12-07 2:50 ` [PATCH V3 1/4] spi: lpspi: Replace all "master" with "controller" Clark Wang
2018-12-08 5:14 ` Joe Perches
2018-12-08 5:42 ` Clark Wang [this message]
2018-12-07 2:50 ` [PATCH V3 2/4] spi: lpspi: Add slave mode support Clark Wang
2018-12-07 2:50 ` [PATCH V3 3/4] spi: lpspi: Let watermark change with send data length Clark Wang
2018-12-07 2:50 ` [PATCH V3 4/4] doc: lpspi: Document DT bindings for LPSPI slave mode Clark Wang
2018-12-13 12:09 ` Applied "doc: lpspi: Document DT bindings for LPSPI slave mode" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR04MB5016114544649016E2090094F3AB0@AM6PR04MB5016.eurprd04.prod.outlook.com \
--to=xiaoning.wang@nxp.com \
--cc=broonie@kernel.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).