From: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
To: Lee Jones <lee.jones@linaro.org>,
Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Support Opensource <Support.Opensource@diasemi.com>
Subject: RE: [RESEND PATCH v2 1/2] mfd: da9063: Fix revision handling to correctly select reg tables
Date: Mon, 20 Apr 2020 08:14:13 +0000 [thread overview]
Message-ID: <AM6PR10MB22631CD857CCB2C153D009CA80D40@AM6PR10MB2263.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20200420073155.GK3737@dell>
On 20 April 2020 08:32, Lee Jones wrote:
> >
> > > > > > + return -EINVAL;
> > > > >
> > > > > Do you want to fail silently here?
> > > >
> > > > Well an error message is printed in the calling code, so didn't feel like it
> > > > was necessary to have additional debug here. Felt like bloat.
> > >
> > > As a user, I would prefer a more specific reason.
> > >
> > > Thus, I would provide an error message here and omit the generic one.
> >
> > I can update although I'll of course then need to do similar messages for the
> > other error legs of this function. FWIW, as this is only being called once in
> > the same file this error leg of code currently can never occur.
>
> As a tiny improvement, it's not a deal breaker. If it's too much
> work, you can either submit a subsequent patch or omit it completely.
Taken care of in the v3 patch set I submitted Friday. Hopefully that covers
everything. :)
next prev parent reply other threads:[~2020-04-20 8:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 8:54 [RESEND PATCH v2 0/2] Resolve revision handling and add support for DA silicon Adam Thomson
2020-04-06 8:54 ` [RESEND PATCH v2 1/2] mfd: da9063: Fix revision handling to correctly select reg tables Adam Thomson
2020-04-16 7:59 ` Lee Jones
2020-04-16 9:04 ` Adam Thomson
2020-04-17 9:24 ` Lee Jones
2020-04-17 9:51 ` Adam Thomson
2020-04-20 7:31 ` Lee Jones
2020-04-20 8:14 ` Adam Thomson [this message]
2020-04-06 8:54 ` [RESEND v2 PATCH 2/2] mfd: da9063: Add support for latest DA silicon revision Adam Thomson
2020-04-16 8:06 ` Lee Jones
2020-04-16 9:06 ` Adam Thomson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR10MB22631CD857CCB2C153D009CA80D40@AM6PR10MB2263.EURPRD10.PROD.OUTLOOK.COM \
--to=adam.thomson.opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).