From: "Bean Huo (beanhuo)" <beanhuo@micron.com>
To: Bart Van Assche <bvanassche@acm.org>,
Bean Huo <huobean@gmail.com>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
"tomas.winkler@intel.com" <tomas.winkler@intel.com>,
"cang@codeaurora.org" <cang@codeaurora.org>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH v2 2/9] scsi: ufs: Delete struct ufs_dev_desc
Date: Fri, 17 Jan 2020 12:55:03 +0000 [thread overview]
Message-ID: <BN7PR08MB5684A86FC0922C3AC2DF93A3DB310@BN7PR08MB5684.namprd08.prod.outlook.com> (raw)
In-Reply-To: <afc473b1-6857-4cca-101d-2382f5314f0d@acm.org>
Hi, Bart
> On 2020-01-16 13:59, Bean Huo wrote:
> > struct ufs_dev_fix {
> > - struct ufs_dev_desc card;
> > + u16 wmanufacturerid;
> > + u8 *model;
> > unsigned int quirk;
> > };
> >
> > -#define END_FIX { { 0 }, 0 }
> > +#define END_FIX { 0 }
>
> A minor comment: please use { } instead of { 0 }.
>
Will be changed in the next version.
> > /* add specific device quirk */
> > #define UFS_FIX(_vendor, _model, _quirk) { \
> > - .card.wmanufacturerid = (_vendor),\
> > - .card.model = (_model), \
> > + .wmanufacturerid = (_vendor),\
> > + .model = (_model), \
> > .quirk = (_quirk), \
> > }
>
> Is this macro useful? Does it improve readability of the code? If not, how about
> removing it (maybe later)?
>
Before no better solution, I think now we just keep it.
> Anyway:
>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Thanks for reviewing.
//Bean
next prev parent reply other threads:[~2020-01-17 12:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 21:59 [PATCH v2 0/9] Use UFS device indicated maximum LU number Bean Huo
2020-01-16 21:59 ` [PATCH v2 1/9] scsi: ufs: goto with returned value while failed to add WL Bean Huo
2020-01-17 3:56 ` Bart Van Assche
2020-01-17 12:57 ` [EXT] " Bean Huo (beanhuo)
2020-01-17 18:23 ` Asutosh Das (asd)
2020-01-16 21:59 ` [PATCH v2 2/9] scsi: ufs: Delete struct ufs_dev_desc Bean Huo
2020-01-17 3:53 ` Bart Van Assche
2020-01-17 12:55 ` Bean Huo (beanhuo) [this message]
2020-01-17 18:21 ` Asutosh Das (asd)
2020-01-16 21:59 ` [PATCH v2 3/9] scsi: ufs: Split ufshcd_probe_hba() based on its called flow Bean Huo
2020-01-17 20:13 ` Asutosh Das (asd)
2020-01-16 21:59 ` [PATCH v2 4/9] scsi: ufs: Move ufshcd_get_max_pwr_mode() to ufs_init_params() Bean Huo
2020-01-16 21:59 ` [PATCH v2 5/9] scsi: ufs: Delete two unnecessary functions Bean Huo
2020-01-17 3:58 ` Bart Van Assche
2020-01-17 13:32 ` [EXT] " Bean Huo (beanhuo)
2020-01-16 21:59 ` [PATCH v2 6/9] scsi: ufs: Delete is_init_prefetch from struct ufs_hba Bean Huo
2020-01-17 4:00 ` Bart Van Assche
2020-01-17 13:12 ` [EXT] " Bean Huo (beanhuo)
2020-01-16 21:59 ` [PATCH v2 7/9] scsi: ufs: Add max_lu_supported in struct ufs_dev_info Bean Huo
2020-01-17 4:02 ` Bart Van Assche
2020-01-17 13:17 ` [EXT] " Bean Huo (beanhuo)
2020-01-16 21:59 ` [PATCH v2 8/9] scsi: ufs: Initialize max_lu_supported Bean Huo
2020-01-16 21:59 ` [PATCH v2 9/9] scsi: ufs: Use UFS device indicated maximum LU number Bean Huo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN7PR08MB5684A86FC0922C3AC2DF93A3DB310@BN7PR08MB5684.namprd08.prod.outlook.com \
--to=beanhuo@micron.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=huobean@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).