From: Jose Abreu <Jose.Abreu@synopsys.com>
To: Jon Hunter <jonathanh@nvidia.com>,
Jose Abreu <Jose.Abreu@synopsys.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Cc: Joao Pinto <Joao.Pinto@synopsys.com>,
"David S . Miller" <davem@davemloft.net>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
linux-tegra <linux-tegra@vger.kernel.org>
Subject: RE: [PATCH net-next 3/3] net: stmmac: Introducing support for Page Pool
Date: Mon, 22 Jul 2019 09:57:21 +0000 [thread overview]
Message-ID: <BN8PR12MB326667E86622C3ABD5CDE642D3C40@BN8PR12MB3266.namprd12.prod.outlook.com> (raw)
In-Reply-To: <BN8PR12MB3266362102CCB6B4DDE4BEA0D3C40@BN8PR12MB3266.namprd12.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1956 bytes --]
From: Jose Abreu <joabreu@synopsys.com>
Date: Jul/22/2019, 10:47:44 (UTC+00:00)
> From: Jon Hunter <jonathanh@nvidia.com>
> Date: Jul/22/2019, 10:37:18 (UTC+00:00)
>
> >
> > On 22/07/2019 08:23, Jose Abreu wrote:
> > > From: Jon Hunter <jonathanh@nvidia.com>
> > > Date: Jul/19/2019, 14:35:52 (UTC+00:00)
> > >
> > >>
> > >> On 19/07/2019 13:32, Jose Abreu wrote:
> > >>> From: Jon Hunter <jonathanh@nvidia.com>
> > >>> Date: Jul/19/2019, 13:30:10 (UTC+00:00)
> > >>>
> > >>>> I booted the board without using NFS and then started used dhclient to
> > >>>> bring up the network interface and it appears to be working fine. I can
> > >>>> even mount the NFS share fine. So it does appear to be particular to
> > >>>> using NFS to mount the rootfs.
> > >>>
> > >>> Damn. Can you send me your .config ?
> > >>
> > >> Yes no problem. Attached.
> > >
> > > Can you compile your image without modules (i.e. all built-in) and let
> > > me know if the error still happens ?
> >
> > I simply removed the /lib/modules directory from the NFS share and
> > verified that I still see the same issue. So it is not loading the
> > modules that is a problem.
>
> Well, I meant that loading modules can be an issue but that's not the
> way to verify that.
>
> You need to have all modules built-in so that it proves that no module
> will try to be loaded.
>
> Anyway, this is probably not the cause as you wouldn't even be able to
> compile kernel if you need a symbol from a module with stmmac built-in.
> Kconfig would complain about that.
>
> The other cause could be data corruption in the RX path. Are you able to
> send me packet dump by running wireshark either in the transmitter side
> (i.e. NFS server), or using some kind of switch ?
>
> ---
> Thanks,
> Jose Miguel Abreu
Also, please add attached patch. You'll get a compiler warning, just
disregard it.
---
Thanks,
Jose Miguel Abreu
[-- Attachment #2: 0001-net-stmmac-Debug-print.patch --]
[-- Type: application/octet-stream, Size: 1514 bytes --]
From b78be4f19e57b6a4d5f67bda1c52c90f6cd901ab Mon Sep 17 00:00:00 2001
Message-Id: <b78be4f19e57b6a4d5f67bda1c52c90f6cd901ab.1563789387.git.joabreu@synopsys.com>
From: Jose Abreu <joabreu@synopsys.com>
Date: Mon, 22 Jul 2019 11:52:28 +0200
Subject: [PATCH net] net: stmmac: Debug print
Signed-off-by: Jose Abreu <joabreu@synopsys.com>
---
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Jose Abreu <joabreu@synopsys.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: netdev@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 0ac79f3e2cee..7a6920098dd0 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -3433,6 +3433,10 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue)
dma_sync_single_for_device(priv->device, buf->addr,
frame_len, DMA_FROM_DEVICE);
+ pr_info("%s: paddr=0x%llx, vaddr=0x%llx, len=%d", __func__,
+ buf->addr, page_address(buf->page),
+ frame_len);
+
if (netif_msg_pktdata(priv)) {
netdev_dbg(priv->dev, "frame received (%dbytes)",
frame_len);
--
2.7.4
next prev parent reply other threads:[~2019-07-22 9:57 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 10:37 [PATCH net-next 0/3] net: stmmac: Some performance improvements and a fix Jose Abreu
2019-07-03 10:37 ` [PATCH net-next 1/3] net: stmmac: Implement RX Coalesce Frames setting Jose Abreu
2019-07-03 20:41 ` Jakub Kicinski
2019-07-03 10:37 ` [PATCH net-next 2/3] net: stmmac: Fix descriptors address being in > 32 bits address space Jose Abreu
2019-07-03 10:37 ` [PATCH net-next 3/3] net: stmmac: Introducing support for Page Pool Jose Abreu
2019-07-03 10:40 ` Jose Abreu
2019-07-04 9:39 ` Jesper Dangaard Brouer
2019-07-04 14:45 ` Jose Abreu
2019-07-04 15:09 ` Jesper Dangaard Brouer
2019-07-04 15:18 ` Jose Abreu
2019-07-04 15:33 ` Jesper Dangaard Brouer
2019-07-04 9:48 ` Jesper Dangaard Brouer
2019-07-04 10:00 ` Jesper Dangaard Brouer
2019-07-04 10:13 ` Jose Abreu
2019-07-04 11:11 ` Ilias Apalodimas
2019-07-04 11:54 ` Jesper Dangaard Brouer
2019-07-04 12:04 ` Ilias Apalodimas
2019-07-04 12:59 ` Jose Abreu
2019-07-04 13:06 ` Ilias Apalodimas
2019-07-04 10:30 ` Ilias Apalodimas
2019-07-04 12:14 ` Arnd Bergmann
2019-07-04 12:49 ` Ilias Apalodimas
2019-07-17 18:58 ` Jon Hunter
2019-07-18 7:29 ` Jose Abreu
2019-07-18 7:48 ` Jose Abreu
2019-07-18 9:16 ` Jon Hunter
2019-07-19 7:51 ` Jose Abreu
2019-07-19 8:37 ` Jon Hunter
2019-07-19 8:44 ` Jose Abreu
2019-07-19 8:49 ` Jon Hunter
2019-07-19 10:25 ` Jose Abreu
2019-07-19 12:28 ` Jose Abreu
2019-07-19 13:33 ` Jon Hunter
2019-07-19 12:30 ` Jon Hunter
2019-07-19 12:32 ` Jose Abreu
2019-07-19 13:35 ` Jon Hunter
2019-07-22 7:23 ` Jose Abreu
2019-07-22 9:37 ` Jon Hunter
2019-07-22 9:47 ` Jose Abreu
2019-07-22 9:57 ` Jose Abreu [this message]
2019-07-22 10:27 ` Jon Hunter
2019-07-22 10:18 ` Ilias Apalodimas
2019-07-22 11:11 ` Lars Persson
2019-07-22 11:39 ` Jose Abreu
2019-07-22 12:05 ` Jon Hunter
2019-07-22 14:04 ` Jose Abreu
2019-07-23 8:14 ` Jose Abreu
2019-07-23 10:01 ` Jon Hunter
2019-07-23 10:07 ` Jose Abreu
2019-07-23 10:29 ` Robin Murphy
2019-07-23 11:22 ` Jose Abreu
2019-07-23 12:09 ` Jon Hunter
2019-07-23 13:19 ` Robin Murphy
2019-07-23 21:39 ` Jon Hunter
2019-07-24 10:03 ` Robin Murphy
2019-07-23 18:51 ` David Miller
2019-07-24 8:54 ` Ilias Apalodimas
2019-07-24 9:43 ` Jose Abreu
2019-07-24 9:53 ` Ilias Apalodimas
2019-07-24 10:04 ` Jose Abreu
2019-07-24 11:10 ` Jon Hunter
2019-07-24 11:34 ` Jose Abreu
2019-07-24 11:58 ` Jon Hunter
2019-07-25 7:44 ` Jose Abreu
2019-07-25 9:45 ` Jon Hunter
2019-07-25 11:39 ` Ilias Apalodimas
2019-07-23 10:38 ` Jon Hunter
2019-07-23 10:49 ` Jose Abreu
2019-07-23 11:58 ` Jon Hunter
2019-07-23 12:51 ` Jose Abreu
2019-07-23 13:34 ` Jon Hunter
2019-07-29 9:45 ` Mikko Perttunen
2019-07-25 13:20 ` Jon Hunter
2019-07-25 13:26 ` Jose Abreu
2019-07-25 14:25 ` Jon Hunter
2019-07-25 15:12 ` Jose Abreu
2019-07-26 14:11 ` Jon Hunter
2019-07-27 15:56 ` Jose Abreu
2019-07-29 8:16 ` Jose Abreu
2019-07-29 10:55 ` Jon Hunter
2019-07-29 11:29 ` Jose Abreu
2019-07-29 11:52 ` Robin Murphy
2019-07-29 14:08 ` Jose Abreu
2019-07-29 21:33 ` Jon Hunter
2019-07-30 9:39 ` Jose Abreu
2019-07-30 13:36 ` Jon Hunter
2019-07-30 13:58 ` Jose Abreu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR12MB326667E86622C3ABD5CDE642D3C40@BN8PR12MB3266.namprd12.prod.outlook.com \
--to=jose.abreu@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-tegra@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).