From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: "Matias Bjørling" <mb@lightnvm.io>, "axboe@fb.com" <axboe@fb.com>,
"hch@lst.de" <hch@lst.de>,
"Chaitanya Kulkarni" <Chaitanya.Kulkarni@wdc.com>,
"Dmitry Fomichev" <Dmitry.Fomichev@wdc.com>,
"Ajay Joshi" <Ajay.Joshi@wdc.com>,
"Aravind Ramesh" <Aravind.Ramesh@wdc.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>,
"agk@redhat.com" <agk@redhat.com>,
"snitzer@redhat.com" <snitzer@redhat.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"dm-devel@redhat.com" <dm-devel@redhat.com>
Subject: Re: [PATCH 4/4] dm: add zone open, close and finish support
Date: Sat, 22 Jun 2019 01:15:30 +0000 [thread overview]
Message-ID: <BYAPR04MB581688295FDAAF91805CD871E7E60@BYAPR04MB5816.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20190621130711.21986-5-mb@lightnvm.io
On 2019/06/21 22:07, Matias Bjørling wrote:
> From: Ajay Joshi <ajay.joshi@wdc.com>
>
> Implement REQ_OP_ZONE_OPEN, REQ_OP_ZONE_CLOSE and REQ_OP_ZONE_FINISH
> support to allow explicit control of zone states.
>
> Signed-off-by: Ajay Joshi <ajay.joshi@wdc.com>
> ---
> drivers/md/dm-flakey.c | 7 +++----
> drivers/md/dm-linear.c | 2 +-
> drivers/md/dm.c | 5 +++--
> include/linux/blk_types.h | 8 ++++++++
> 4 files changed, 15 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/md/dm-flakey.c b/drivers/md/dm-flakey.c
> index a9bc518156f2..fff529c0732c 100644
> --- a/drivers/md/dm-flakey.c
> +++ b/drivers/md/dm-flakey.c
> @@ -280,7 +280,7 @@ static void flakey_map_bio(struct dm_target *ti, struct bio *bio)
> struct flakey_c *fc = ti->private;
>
> bio_set_dev(bio, fc->dev->bdev);
> - if (bio_sectors(bio) || bio_op(bio) == REQ_OP_ZONE_RESET)
> + if (bio_sectors(bio) || bio_is_zone_mgmt_op(bio))
> bio->bi_iter.bi_sector =
> flakey_map_sector(ti, bio->bi_iter.bi_sector);
> }
> @@ -322,8 +322,7 @@ static int flakey_map(struct dm_target *ti, struct bio *bio)
> struct per_bio_data *pb = dm_per_bio_data(bio, sizeof(struct per_bio_data));
> pb->bio_submitted = false;
>
> - /* Do not fail reset zone */
> - if (bio_op(bio) == REQ_OP_ZONE_RESET)
> + if (bio_is_zone_mgmt_op(bio))
> goto map_bio;
>
> /* Are we alive ? */
> @@ -384,7 +383,7 @@ static int flakey_end_io(struct dm_target *ti, struct bio *bio,
> struct flakey_c *fc = ti->private;
> struct per_bio_data *pb = dm_per_bio_data(bio, sizeof(struct per_bio_data));
>
> - if (bio_op(bio) == REQ_OP_ZONE_RESET)
> + if (bio_is_zone_mgmt_op(bio))
> return DM_ENDIO_DONE;
>
> if (!*error && pb->bio_submitted && (bio_data_dir(bio) == READ)) {
> diff --git a/drivers/md/dm-linear.c b/drivers/md/dm-linear.c
> index ad980a38fb1e..217a1dee8197 100644
> --- a/drivers/md/dm-linear.c
> +++ b/drivers/md/dm-linear.c
> @@ -90,7 +90,7 @@ static void linear_map_bio(struct dm_target *ti, struct bio *bio)
> struct linear_c *lc = ti->private;
>
> bio_set_dev(bio, lc->dev->bdev);
> - if (bio_sectors(bio) || bio_op(bio) == REQ_OP_ZONE_RESET)
> + if (bio_sectors(bio) || bio_is_zone_mgmt_op(bio))
> bio->bi_iter.bi_sector =
> linear_map_sector(ti, bio->bi_iter.bi_sector);
> }
> diff --git a/drivers/md/dm.c b/drivers/md/dm.c
> index 5475081dcbd6..f4507ec20a57 100644
> --- a/drivers/md/dm.c
> +++ b/drivers/md/dm.c
> @@ -1176,7 +1176,8 @@ static size_t dm_dax_copy_to_iter(struct dax_device *dax_dev, pgoff_t pgoff,
>
> /*
> * A target may call dm_accept_partial_bio only from the map routine. It is
> - * allowed for all bio types except REQ_PREFLUSH and REQ_OP_ZONE_RESET.
> + * allowed for all bio types except REQ_PREFLUSH, REQ_OP_ZONE_RESET,
> + * REQ_OP_ZONE_OPEN, REQ_OP_ZONE_CLOSE and REQ_OP_ZONE_FINISH.
> *
> * dm_accept_partial_bio informs the dm that the target only wants to process
> * additional n_sectors sectors of the bio and the rest of the data should be
> @@ -1629,7 +1630,7 @@ static blk_qc_t __split_and_process_bio(struct mapped_device *md,
> ci.sector_count = 0;
> error = __send_empty_flush(&ci);
> /* dec_pending submits any data associated with flush */
> - } else if (bio_op(bio) == REQ_OP_ZONE_RESET) {
> + } else if (bio_is_zone_mgmt_op(bio)) {
> ci.bio = bio;
> ci.sector_count = 0;
> error = __split_and_process_non_flush(&ci);
> diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
> index 067ef9242275..fd2458cd1a49 100644
> --- a/include/linux/blk_types.h
> +++ b/include/linux/blk_types.h
> @@ -398,6 +398,14 @@ static inline bool op_is_zone_mgmt_op(enum req_opf op)
> }
> }
>
> +/*
> + * Check if the bio is zoned operation.
> + */
> +static inline bool bio_is_zone_mgmt_op(struct bio *bio)
> +{
> + return op_is_zone_mgmt_op(bio_op(bio));
> +}
> +
> static inline bool op_is_write(unsigned int op)
> {
> return (op & 1);
>
Looks good.
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2019-06-22 1:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 13:07 [PATCH 0/4] open, close, finish zone support Matias Bjørling
2019-06-21 13:07 ` [PATCH 1/4] block: add zone open, close and finish support Matias Bjørling
2019-06-22 0:51 ` Damien Le Moal
2019-06-24 10:36 ` Matias Bjørling
2019-06-22 6:04 ` Minwoo Im
2019-06-24 19:43 ` Bart Van Assche
2019-06-24 22:27 ` Chaitanya Kulkarni
2019-06-25 10:35 ` Matias Bjørling
2019-06-25 15:55 ` Bart Van Assche
2019-06-25 16:30 ` Javier González
2019-06-25 16:51 ` Chaitanya Kulkarni
2019-06-25 16:53 ` Matias Bjørling
2019-06-26 0:44 ` Damien Le Moal
2019-06-26 0:42 ` Damien Le Moal
2019-06-21 13:07 ` [PATCH 2/4] null_blk: add zone open, close, " Matias Bjørling
2019-06-22 1:02 ` Damien Le Moal
2019-06-25 11:06 ` Matias Bjørling
2019-06-25 12:36 ` Damien Le Moal
2019-06-25 13:03 ` Matias Bjørling
2019-06-21 13:07 ` [PATCH 3/4] scsi: sd_zbc: " Matias Bjørling
2019-06-22 1:12 ` Damien Le Moal
2019-06-24 19:46 ` Bart Van Assche
2019-06-25 10:32 ` Matias Bjørling
2019-06-21 13:07 ` [PATCH 4/4] dm: add zone open, close " Matias Bjørling
2019-06-22 1:15 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB581688295FDAAF91805CD871E7E60@BYAPR04MB5816.namprd04.prod.outlook.com \
--to=damien.lemoal@wdc.com \
--cc=Ajay.Joshi@wdc.com \
--cc=Aravind.Ramesh@wdc.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=Dmitry.Fomichev@wdc.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=agk@redhat.com \
--cc=axboe@fb.com \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mb@lightnvm.io \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).