From: "Nicolas Saenz Julienne" <nsaenzjulienne@suse.de>
To: "Lukas Wunner" <lukas@wunner.de>
Cc: "Matthias Brugger" <matthias.bgg@gmail.com>,
<matthias.bgg@kernel.org>, <linux-arm-kernel@lists.infradead.org>,
"Matthias Brugger" <mbrugger@suse.com>,
"Scott Branden" <sbranden@broadcom.com>,
<gregkh@linuxfoundation.org>, <linux-kernel@vger.kernel.org>,
"Ray Jui" <rjui@broadcom.com>,
"Stephen Boyd" <swboyd@chromium.org>,
"Florian Fainelli" <f.fainelli@gmail.com>,
<bcm-kernel-feedback-list@broadcom.com>,
<linux-rpi-kernel@lists.infradead.org>,
<linux-serial@vger.kernel.org>, <jslaby@suse.com>
Subject: Re: [PATCH] serial: 8250_early: Add earlycon for BCM2835 aux uart
Date: Thu, 30 Jan 2020 17:11:55 +0100 [thread overview]
Message-ID: <C099APQHQAHB.3Q9UVYJYT98TN@linux-9qgx> (raw)
In-Reply-To: <20200128141958.vwbxoqglt5gw4xj5@wunner.de>
On Tue Jan 28, 2020 at 3:19 PM, Lukas Wunner wrote:
> On Tue, Jan 28, 2020 at 01:42:21PM +0100, Nicolas Saenz Julienne wrote:
> > I'm testing this by booting directly from RPi4's bootloader. And it
> > works as long as I add this to config.txt:
> >
> > enable_uart=1
> > gpu_freq=500
> >
> > Which AFAIK blocks frequency scalin on the GPU and fixes the clock to a
> > point where the serial is set at 115200 bauds.
> >
> > Ideally it'd be nice to be able to query the clock frequency, and
> > recalculate the divisors based on that. But I don't know if it's
> > feasible at that point in the boot process.
>
> Well, we don't even support adjusting the baudrate *after* the kernel
> has booted.
Don't 8250 uarts have a clk divisor? I've seen other 8250 earlycon
drivers do this (see 8250_ingenic.c), that said I think it's a lost
cause for us.
BTW did you had the oportunity to have a go at the patch?
> The problem is that in mainline, bcm2835_defconfig contains:
> CONFIG_CPU_FREQ_DEFAULT_GOV_CONSERVATIVE=y
>
> Likewise in the Foundation's downstream tree, bcmrpi_defconfig as well
> as bcm2711_defconfig and bcm2709_defconfig contain:
> CONFIG_CPU_FREQ_DEFAULT_GOV_POWERSAVE=y
>
> In contrast to this, we set the following on Revolution Pi devices:
> CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE=y
>
> Downclocking influences not only the uart1 baud rate but also the
> spi0 clock. We attach Ethernet chips to spi0, throughput was
> significantly worse with the ondemand governor (which is what we
> used previously). We felt that maximum Ethernet performance
> outweighs the relatively small powersaving gains.
In that regard I suggest you use the upstream cpufreq driver which
behaves properly in that regard. It disables GPU freq scaling, so as to
change CPU frequencies without SPI/I2C/UART issues.
Regards,
Nicolas
next prev parent reply other threads:[~2020-01-30 18:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 12:33 [PATCH] serial: 8250_early: Add earlycon for BCM2835 aux uart matthias.bgg
2020-01-26 13:12 ` Lukas Wunner
2020-01-26 20:20 ` Matthias Brugger
2020-01-28 12:42 ` Nicolas Saenz Julienne
2020-01-28 14:19 ` Lukas Wunner
2020-01-30 16:11 ` Nicolas Saenz Julienne [this message]
2020-01-31 15:24 ` Lukas Wunner
2020-02-03 19:10 ` Nicolas Saenz Julienne
2020-02-12 13:28 ` Lukas Wunner
2020-02-12 15:18 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C099APQHQAHB.3Q9UVYJYT98TN@linux-9qgx \
--to=nsaenzjulienne@suse.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=matthias.bgg@gmail.com \
--cc=matthias.bgg@kernel.org \
--cc=mbrugger@suse.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).