From: Linus Torvalds <torvalds@linux-foundation.org>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Bob Peterson <rpeterso@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Steven Whitehouse <swhiteho@redhat.com>,
Andrew Lutomirski <luto@kernel.org>,
Andreas Gruenbacher <agruenba@redhat.com>,
Mel Gorman <mgorman@techsingularity.net>,
linux-mm <linux-mm@kvack.org>, Hugh Dickins <hughd@google.com>
Subject: Re: [RFC][PATCH] make global bitlock waitqueues per-node
Date: Wed, 21 Dec 2016 11:50:49 -0800 [thread overview]
Message-ID: <CA+55aFwQtaKGDzNFsanMavTH=TBoHgjGqQbwqbLvbjs7Y0EWCw@mail.gmail.com> (raw)
In-Reply-To: <20161222050130.49d93982@roar.ozlabs.ibm.com>
On Wed, Dec 21, 2016 at 11:01 AM, Nicholas Piggin <npiggin@gmail.com> wrote:
> Peter's patch is less code and in that regard a bit nicer. I tried
> going that way once, but I just thought it was a bit too sloppy to
> do nicely with wait bit APIs.
So I have to admit that when I read through your and PeterZ's patches
back-to-back, yours was easier to understand.
PeterZ's is smaller but kind of subtle. The whole "return zero from
lock_page_wait() and go around again" and the locking around that
isn't exactly clear. In contrast, yours has the obvious waitqueue
spinlock.
I'll think about it. And yes, it would be good to have more testing,
but at the same time xmas is imminent, and waiting around too much
isn't going to help either..
Linus
next prev parent reply other threads:[~2016-12-21 19:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 22:58 [RFC][PATCH] make global bitlock waitqueues per-node Dave Hansen
[not found] ` <CA+55aFwK6JdSy9v_BkNYWNdfK82sYA1h3qCSAJQ0T45cOxeXmQ@mail.gmail.com>
2016-12-20 0:20 ` Dave Hansen
2016-12-20 2:31 ` Nicholas Piggin
2016-12-20 12:58 ` Mel Gorman
2016-12-20 13:21 ` Nicholas Piggin
2016-12-20 17:31 ` Linus Torvalds
2016-12-20 18:02 ` Linus Torvalds
2016-12-21 8:09 ` Peter Zijlstra
2016-12-21 8:32 ` Peter Zijlstra
2016-12-21 18:02 ` Linus Torvalds
2016-12-21 18:33 ` Nicholas Piggin
2016-12-21 19:01 ` Nicholas Piggin
2016-12-21 19:50 ` Linus Torvalds [this message]
2016-12-22 2:07 ` Nicholas Piggin
2016-12-22 19:28 ` Hugh Dickins
2016-12-21 10:26 ` Nicholas Piggin
2016-12-20 2:26 ` Nicholas Piggin
2016-12-21 12:30 ` Nicholas Piggin
2016-12-21 18:12 ` Linus Torvalds
2016-12-21 18:40 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFwQtaKGDzNFsanMavTH=TBoHgjGqQbwqbLvbjs7Y0EWCw@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=agruenba@redhat.com \
--cc=dave.hansen@linux.intel.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mgorman@techsingularity.net \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=rpeterso@redhat.com \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).