linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fuad Tabba <tabba@google.com>
To: Quentin Perret <qperret@google.com>
Cc: maz@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com,
	suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
	ardb@kernel.org, qwandor@google.com, dbrazdil@google.com,
	kernel-team@android.com
Subject: Re: [PATCH v4 14/21] KVM: arm64: Expose pkvm_hyp_id
Date: Tue, 10 Aug 2021 06:57:13 +0200	[thread overview]
Message-ID: <CA+EHjTyxW_X-xjn7opfrLFWXupfjMzCZFVBYZjgpaqLbxbjDVQ@mail.gmail.com> (raw)
In-Reply-To: <20210809152448.1810400-15-qperret@google.com>

Hi Quentin,

On Mon, Aug 9, 2021 at 5:25 PM Quentin Perret <qperret@google.com> wrote:
>
> Allow references to the hypervisor's owner id from outside
> mem_protect.c.
>
> Signed-off-by: Quentin Perret <qperret@google.com>
> ---

Reviewed-by: Fuad Tabba <tabba@google.com>

Thanks,
/fuad

>  arch/arm64/kvm/hyp/include/nvhe/mem_protect.h | 2 ++
>  arch/arm64/kvm/hyp/nvhe/mem_protect.c         | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h b/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h
> index 0849ee8fa260..23316a021880 100644
> --- a/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h
> +++ b/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h
> @@ -46,6 +46,8 @@ struct host_kvm {
>  };
>  extern struct host_kvm host_kvm;
>
> +extern const u8 pkvm_hyp_id;
> +
>  int __pkvm_prot_finalize(void);
>  int __pkvm_mark_hyp(phys_addr_t start, phys_addr_t end);
>
> diff --git a/arch/arm64/kvm/hyp/nvhe/mem_protect.c b/arch/arm64/kvm/hyp/nvhe/mem_protect.c
> index f95a5a4aa09c..ee255171945c 100644
> --- a/arch/arm64/kvm/hyp/nvhe/mem_protect.c
> +++ b/arch/arm64/kvm/hyp/nvhe/mem_protect.c
> @@ -31,7 +31,7 @@ static struct hyp_pool host_s2_pool;
>  u64 id_aa64mmfr0_el1_sys_val;
>  u64 id_aa64mmfr1_el1_sys_val;
>
> -static const u8 pkvm_hyp_id = 1;
> +const u8 pkvm_hyp_id = 1;
>
>  static void *host_s2_zalloc_pages_exact(size_t size)
>  {
> --
> 2.32.0.605.g8dce9f2422-goog
>

  reply	other threads:[~2021-08-10  4:57 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-09 15:24 [PATCH v4 00/21] Track shared pages at EL2 in protected mode Quentin Perret
2021-08-09 15:24 ` [PATCH v4 01/21] KVM: arm64: Add hyp_spin_is_locked() for basic locking assertions at EL2 Quentin Perret
2021-08-09 15:24 ` [PATCH v4 02/21] KVM: arm64: Introduce hyp_assert_lock_held() Quentin Perret
2021-08-09 15:24 ` [PATCH v4 03/21] KVM: arm64: Provide the host_stage2_try() helper macro Quentin Perret
2021-08-09 15:24 ` [PATCH v4 04/21] KVM: arm64: Introduce helper to retrieve a PTE and its level Quentin Perret
2021-08-17 13:53   ` Andrew Walbran
2021-08-09 15:24 ` [PATCH v4 05/21] KVM: arm64: Expose page-table helpers Quentin Perret
2021-08-10  4:56   ` Fuad Tabba
2021-08-09 15:24 ` [PATCH v4 06/21] KVM: arm64: Optimize host memory aborts Quentin Perret
2021-08-09 15:24 ` [PATCH v4 07/21] KVM: arm64: Rename KVM_PTE_LEAF_ATTR_S2_IGNORED Quentin Perret
2021-08-09 15:24 ` [PATCH v4 08/21] KVM: arm64: Don't overwrite software bits with owner id Quentin Perret
2021-08-09 15:24 ` [PATCH v4 09/21] KVM: arm64: Tolerate re-creating hyp mappings to set software bits Quentin Perret
2021-08-09 15:24 ` [PATCH v4 10/21] KVM: arm64: Enable forcing page-level stage-2 mappings Quentin Perret
2021-08-10  4:33   ` Fuad Tabba
2021-08-09 15:24 ` [PATCH v4 11/21] KVM: arm64: Allow populating software bits Quentin Perret
2021-08-10  4:56   ` Fuad Tabba
2021-08-09 15:24 ` [PATCH v4 12/21] KVM: arm64: Add helpers to tag shared pages in SW bits Quentin Perret
2021-08-09 15:24 ` [PATCH v4 13/21] KVM: arm64: Expose host stage-2 manipulation helpers Quentin Perret
2021-08-10  4:36   ` Fuad Tabba
2021-08-09 15:24 ` [PATCH v4 14/21] KVM: arm64: Expose pkvm_hyp_id Quentin Perret
2021-08-10  4:57   ` Fuad Tabba [this message]
2021-08-09 15:24 ` [PATCH v4 15/21] KVM: arm64: Introduce addr_is_memory() Quentin Perret
2021-08-10  4:37   ` Fuad Tabba
2021-08-09 15:24 ` [PATCH v4 16/21] KVM: arm64: Enable retrieving protections attributes of PTEs Quentin Perret
2021-08-10  4:38   ` Fuad Tabba
2021-08-09 15:24 ` [PATCH v4 17/21] KVM: arm64: Mark host bss and rodata section as shared Quentin Perret
2021-08-10  4:40   ` Fuad Tabba
2021-08-09 15:24 ` [PATCH v4 18/21] KVM: arm64: Remove __pkvm_mark_hyp Quentin Perret
2021-08-10  4:55   ` Fuad Tabba
2021-08-09 15:24 ` [PATCH v4 19/21] KVM: arm64: Refactor protected nVHE stage-1 locking Quentin Perret
2021-08-10  4:41   ` Fuad Tabba
2021-08-09 15:24 ` [PATCH v4 20/21] KVM: arm64: Restrict EL2 stage-1 changes in protected mode Quentin Perret
2021-08-10  4:43   ` Fuad Tabba
2021-08-09 15:24 ` [PATCH v4 21/21] KVM: arm64: Make __pkvm_create_mappings static Quentin Perret
2021-08-10  4:55   ` Fuad Tabba
2021-08-11 11:25 ` [PATCH v4 00/21] Track shared pages at EL2 in protected mode Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+EHjTyxW_X-xjn7opfrLFWXupfjMzCZFVBYZjgpaqLbxbjDVQ@mail.gmail.com \
    --to=tabba@google.com \
    --cc=alexandru.elisei@arm.com \
    --cc=ardb@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=dbrazdil@google.com \
    --cc=james.morse@arm.com \
    --cc=kernel-team@android.com \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=qperret@google.com \
    --cc=qwandor@google.com \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).