From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 280A3C04EBE for ; Thu, 8 Oct 2020 12:23:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C01CC21D43 for ; Thu, 8 Oct 2020 12:23:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZV/udlGz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729814AbgJHMXY (ORCPT ); Thu, 8 Oct 2020 08:23:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729701AbgJHMXY (ORCPT ); Thu, 8 Oct 2020 08:23:24 -0400 Received: from mail-ua1-x942.google.com (mail-ua1-x942.google.com [IPv6:2607:f8b0:4864:20::942]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E07FEC061755 for ; Thu, 8 Oct 2020 05:23:23 -0700 (PDT) Received: by mail-ua1-x942.google.com with SMTP id r21so1805787uaw.10 for ; Thu, 08 Oct 2020 05:23:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6yaLQlxNw70bRGmpr47sIPOg0JWUbIqHrAviNgxR9U8=; b=ZV/udlGzIl/jBrUJkuN1KwkLbErRiww1AXfbdYjhu4aftSNTMtV4+PM1BRjHauZxfp HbtfbtxaCjWO7kt3kz8IqDCxFVt6zufkjs0R5JcP1kz9I5bfIyMblsiuAEvsfk4IJitP k7F6hH3KcaYkZgb85VTdANYMENGpTOqykJwHPOTx+/h7Lk61QKg66tm/uB+lty3qHwiW GEqGpwFCwllORWVB21LnPAoTOZk+p4jhax1BUnlUQoHo1whWYCl7pItcKd+vz4XSCK5I gNwxPHcFXodJUNDYPYp7haWTvUmJiATg0vIwrH1GHoNVL4t1C2nyWafuHOFtVW9XD5+C tTzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6yaLQlxNw70bRGmpr47sIPOg0JWUbIqHrAviNgxR9U8=; b=j4x8YHdaAdfAI2oyUZvQ4bb7tutfAC+o+NvhqU5dhBxH3DI1DZENPq6xEhYJLjm4dW 3McRg9bBmqB+Prt0MOCQbY7Q9QXeIp+/ylBqRqOSjWMBUEXcxPnP7EKwlhP8RciZorRA XgipJeIStpXOW25ePAH8zMBoxjI9uh8pkhgHlYpWO8Ra1F+Ubbu3AN5kdl6ZJXxuwkT4 ArEKRbR4Tgczw/Lvx7Lf2FOo8fWE3uPIMaX04M/6DqVgvR91rOAD8BVc8vzdQqJzhGXv Md4Bq2HTd8lyzi5sgwxyh0mkgHo6hVnbpxh69XybPDN1gZ1v3Qga0Mn8N1P4/CizLevz hNww== X-Gm-Message-State: AOAM530OaJx+IQbSGnXM9LUtjDLIJcUz2cT33Mt7tYDIEbxDGP4F+xdH pFMo+cxvP9F8cckFL0km36+WqacShXA= X-Google-Smtp-Source: ABdhPJyQ92iU2pSPt9y6tCpoKPjUyVMX4PknszyLlmHH0uSdfRK9RkF+tM3lRzhlKVGXAJtSEfFOQQ== X-Received: by 2002:ab0:76cd:: with SMTP id w13mr4344672uaq.37.1602159802368; Thu, 08 Oct 2020 05:23:22 -0700 (PDT) Received: from mail-vs1-f48.google.com (mail-vs1-f48.google.com. [209.85.217.48]) by smtp.gmail.com with ESMTPSA id z7sm609678vsn.14.2020.10.08.05.23.20 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Oct 2020 05:23:21 -0700 (PDT) Received: by mail-vs1-f48.google.com with SMTP id f8so2927363vsl.3 for ; Thu, 08 Oct 2020 05:23:20 -0700 (PDT) X-Received: by 2002:a67:d84:: with SMTP id 126mr4218029vsn.51.1602159800489; Thu, 08 Oct 2020 05:23:20 -0700 (PDT) MIME-Version: 1.0 References: <20201008115808.91850-1-coiby.xu@gmail.com> <20201008115808.91850-2-coiby.xu@gmail.com> In-Reply-To: <20201008115808.91850-2-coiby.xu@gmail.com> From: Willem de Bruijn Date: Thu, 8 Oct 2020 08:22:44 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver To: Coiby Xu Cc: devel@driverdev.osuosl.org, Benjamin Poirier , Shung-Hsi Yu , Manish Chopra , "supporter:QLOGIC QLGE 10Gb ETHERNET DRIVER" , Greg Kroah-Hartman , open list , "open list:QLOGIC QLGE 10Gb ETHERNET DRIVER" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 8, 2020 at 7:58 AM Coiby Xu wrote: > > Initialize devlink health dump framework for the dlge driver so the > coredump could be done via devlink. > > Signed-off-by: Coiby Xu > @@ -4556,6 +4559,13 @@ static int qlge_probe(struct pci_dev *pdev, > struct ql_adapter *qdev = NULL; > static int cards_found; > int err = 0; > + struct devlink *devlink; > + struct qlge_devlink *ql_devlink; > + > + devlink = devlink_alloc(&qlge_devlink_ops, sizeof(struct qlge_devlink)); > + if (!devlink) > + return -ENOMEM; > + ql_devlink = devlink_priv(devlink); > > ndev = alloc_etherdev_mq(sizeof(struct ql_adapter), > min(MAX_CPUS, need to goto devlink_free instead of return -ENOMEM here, too. > @@ -4614,6 +4624,16 @@ static int qlge_probe(struct pci_dev *pdev, > free_netdev(ndev); > return err; and here > } > + > + err = devlink_register(devlink, &pdev->dev); > + if (err) { > + goto devlink_free; > + } > + > + qlge_health_create_reporters(ql_devlink); > + ql_devlink->qdev = qdev; > + ql_devlink->ndev = ndev; > + qdev->ql_devlink = ql_devlink; > /* Start up the timer to trigger EEH if > * the bus goes dead > */ > @@ -4624,6 +4644,10 @@ static int qlge_probe(struct pci_dev *pdev, > atomic_set(&qdev->lb_count, 0); > cards_found++; > return 0; > + > +devlink_free: > + devlink_free(devlink); > + return err; > }