Re: [PATCH 1/2] net: fec_main: Use platform_get_irq_byname_optional() to avoid error message

From: Vladimir Oltean <olteanv@gmail.com>
To: Anson Huang <anson.huang@nxp.com>
Cc: Jakub Kicinski <jakub.kicinski@netronome.com>,
	Andy Duan <fugang.duan@nxp.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
	"rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
	"swboyd@chromium.org" <swboyd@chromium.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 1/2] net: fec_main: Use platform_get_irq_byname_optional() to avoid error message
Date: Fri, 11 Oct 2019 12:55:20 +0300	[thread overview]
Message-ID: <CA+h21hpp5L-tcJNxXWaJaCKZyFzm-qPzUZ32LU+vKOv99PJ9ng@mail.gmail.com> (raw)
In-Reply-To: <DB3PR0402MB3916F0AC3E3AEC2AC1900BCCF5970@DB3PR0402MB3916.eurprd04.prod.outlook.com>

Hi Anson,

On Fri, 11 Oct 2019 at 04:11, Anson Huang <anson.huang@nxp.com> wrote:
>
> Hi, Jakub
>
> > On Fri, 11 Oct 2019 00:38:50 +0000, Anson Huang wrote:
> > > > Hm. Looks like the commit you need is commit f1da567f1dc1 ("driver core:
> > > > platform: Add platform_get_irq_byname_optional()") and it's
> > > > currently in Greg's tree. You have to wait for that commit to make
> > > > its way into Linus'es main tree and then for Dave Miller to pull from Linus.
> > > >
> > > > I'd suggest you check if your patches builds on the net tree:
> > > >
> > > >   git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git
> > > >
> > > > once a week. My guess is it'll probably take two weeks or so for
> > > > Greg's patches to propagate to Dave.
> > >
> > > Thanks for explanation of how these trees work, so could you please
> > > wait the necessary patch landing on network tree then apply this patch
> > > series, thanks for help.
> >
> > Unfortunately the networking subsystem sees around a 100 patches
> > submitted each day, it'd be very hard to keep track of patches which have
> > external dependencies and when to merge them. That's why we need the
> > submitters to do this work for us and resubmit when the patch can be
> > applied cleanly.
>
> OK, I will resend this patch series once the necessary patch lands on the network
> tree.

What has not been mentioned is that you can't create future
dependencies for patches which have a Fixes: tag.

git describe --tags 7723f4c5ecdb # driver core: platform: Add an error
message to platform_get_irq*()
v5.3-rc1-13-g7723f4c5ecdb

git describe --tags f1da567f1dc # driver core: platform: Add
platform_get_irq_byname_optional()
v5.4-rc1-46-gf1da567f1dc1

So you have to consider whether the patch is really fixing anything
(it is only getting rid of a non-fatal error message).
And it's not reasonable anyway to say that you're fixing the patch
that added the error message in the generic framework.
The fallback logic has always been there in the driver. So you might
want to drop the Fixes: tag when you resend.

>
> Thanks,
> Anson

Regards,
-Vladimir