From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2F0BC07E96 for ; Tue, 13 Jul 2021 23:18:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A729061361 for ; Tue, 13 Jul 2021 23:18:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236873AbhGMXVJ (ORCPT ); Tue, 13 Jul 2021 19:21:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236794AbhGMXVG (ORCPT ); Tue, 13 Jul 2021 19:21:06 -0400 Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5187C0613E9 for ; Tue, 13 Jul 2021 16:18:14 -0700 (PDT) Received: by mail-qk1-x729.google.com with SMTP id r125so15871777qkf.1 for ; Tue, 13 Jul 2021 16:18:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X7EKvFIO/8O+BrCmufnPNCIDCKJof7TC2G+GPb281Kk=; b=vstfIIXpC66V8Fdf4gXiMzbgUIxqHrQh2s9iRgiZ9eMvf3unWbjSWZwMPPrPq3PUoc +U3DefG4sYEYRyWdjXmqNPwezvTbwnB8pLyu447a9Ev+FEvtCUVXWrIWsgCEHH5o0bOR lRjJUuw7qCUDMXLloWLJjk73ntKVVo+MmURiCiLFzzJujrNkdW1kJTE8IrWukSnbeyca KDn0PEMzOHJ7v3a2eY8SRkY+vzOyweW1FmwPay6axcOT2ZaSgvpve+uMQF1ME/sxoSwW /1jknaGnzrB4/Q+doN97u6uMvaP2DG46u+zSYP3ydM0he47WVyiTEHYCgQSJxL9N7KB3 +1EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X7EKvFIO/8O+BrCmufnPNCIDCKJof7TC2G+GPb281Kk=; b=hAHIAs6+2gq6UI839/rhAbp/fXBcz8KMZJp8vpc/5KTL2WMTeupvMZPjOHuxWpK+sW s444ZT05ewDlr3Tp4WxQA8aXFExiA+TzseDoUrirgMKTXgexp6MhTLmZUIBusf6TgogR 7MzyfqPXzdh8bbnwIZLVtq8hVHOJRDPAe1X0dFbvYPGB6RPK1whVkfs5OND+JCQNyBQ5 nDLyGOMYbpyLPibeIaOER3inVdMnOjC+AC2UaEAHjOy46A9mK1k6pymfbN0hOidt7OZu yyMxvemv222Az/OpSWJ15dUzNSa0GzYgVy8YRxOrjlenCamSLPGERrtK3SZyu1rdBb0f xG2w== X-Gm-Message-State: AOAM532KaQerVGIiK/olgQHy3C4lyCvtCKDl/BTBeINxPxiGYPhliDt5 Eii/6ar/JILW7K4GIwx66HBjpz0wPAdOvkK2V4/FCA== X-Google-Smtp-Source: ABdhPJw71oxMLOthCOty8sCCNUamAqIXG1dQrWSKcfyxw3TB3eUuJW33VfEC6A0+HHgXbhhD2CzYo5hYvYhgObPdFnw= X-Received: by 2002:a05:620a:a90:: with SMTP id v16mr6752709qkg.150.1626218293567; Tue, 13 Jul 2021 16:18:13 -0700 (PDT) MIME-Version: 1.0 References: <20210621163118.1040170-1-pgonda@google.com> <20210621163118.1040170-2-pgonda@google.com> In-Reply-To: <20210621163118.1040170-2-pgonda@google.com> From: Marc Orr Date: Tue, 13 Jul 2021 16:18:02 -0700 Message-ID: Subject: Re: [PATCH 1/3] KVM, SEV: Refactor out function for unregistering encrypted regions To: Peter Gonda Cc: kvm list , Paolo Bonzini , Sean Christopherson , David Rientjes , "Dr . David Alan Gilbert" , Brijesh Singh , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 21, 2021 at 9:59 AM Peter Gonda wrote: > > Factor out helper function for freeing the encrypted region list. > > Signed-off-by: Peter Gonda > Cc: Paolo Bonzini > Cc: Sean Christopherson > Cc: David Rientjes > Cc: Dr. David Alan Gilbert > Cc: Brijesh Singh > Cc: Vitaly Kuznetsov > Cc: Wanpeng Li > Cc: Jim Mattson > Cc: Joerg Roedel > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: "H. Peter Anvin" > Cc: kvm@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > > --- > arch/x86/kvm/svm/sev.c | 26 +++++++++++++++++--------- > 1 file changed, 17 insertions(+), 9 deletions(-) > > diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c > index 46e339c84998..5af46ff6ec48 100644 > --- a/arch/x86/kvm/svm/sev.c > +++ b/arch/x86/kvm/svm/sev.c > @@ -1767,11 +1767,25 @@ int svm_vm_copy_asid_from(struct kvm *kvm, unsigned int source_fd) > return ret; > } > > +static void __unregister_region_list_locked(struct kvm *kvm, > + struct list_head *mem_regions) > +{ > + struct enc_region *pos, *q; > + > + lockdep_assert_held(&kvm->lock); > + > + if (list_empty(mem_regions)) > + return; > + > + list_for_each_entry_safe(pos, q, mem_regions, list) { > + __unregister_enc_region_locked(kvm, pos); > + cond_resched(); > + } > +} > + > void sev_vm_destroy(struct kvm *kvm) > { > struct kvm_sev_info *sev = &to_kvm_svm(kvm)->sev_info; > - struct list_head *head = &sev->regions_list; > - struct list_head *pos, *q; > > if (!sev_guest(kvm)) > return; > @@ -1795,13 +1809,7 @@ void sev_vm_destroy(struct kvm *kvm) > * if userspace was terminated before unregistering the memory regions > * then lets unpin all the registered memory. > */ > - if (!list_empty(head)) { > - list_for_each_safe(pos, q, head) { > - __unregister_enc_region_locked(kvm, > - list_entry(pos, struct enc_region, list)); > - cond_resched(); > - } > - } > + __unregister_region_list_locked(kvm, &sev->regions_list); > > mutex_unlock(&kvm->lock); > > -- > 2.32.0.288.g62a8d224e6-goog Reviewed-by: Marc Orr