linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tong Zhang <ztong0001@gmail.com>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Alexander A. Klimov" <grandmaster@al2klimov.de>,
	devel@driverdev.osuosl.org,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: comedi: das800: fix request_irq() warn
Date: Thu, 18 Mar 2021 23:48:41 -0400	[thread overview]
Message-ID: <CAA5qM4BvHNT9YboUnKXwQcqHVBMSiAXS16Y9ogLk+pHCk+O4FA@mail.gmail.com> (raw)
In-Reply-To: <8c65b02e-4315-153f-de2c-153862f195be@mev.co.uk>

Thank you all,
I fixed the commit log and resent as v2.
Thanks,
- Tong

On Wed, Mar 17, 2021 at 8:48 AM Ian Abbott <abbotti@mev.co.uk> wrote:
>
> On 16/03/2021 22:42, Tong Zhang wrote:
> > request_irq() wont accept a name which contains slash so we need to
> > repalce it with something else -- otherwise it will trigger a warning
> > and the entry in /proc/irq/ will not be created
> > since the .name might be used by userspace and we don't want to break
> > userspace, so we are changing the parameters passed to request_irq()
> >
> > Suggested-by: Ian Abbott <abbotti@mev.co.uk>
> > Signed-off-by: Tong Zhang <ztong0001@gmail.com>
> > ---
> >   drivers/staging/comedi/drivers/das800.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/comedi/drivers/das800.c b/drivers/staging/comedi/drivers/das800.c
> > index 2881808d6606..bc08324f422f 100644
> > --- a/drivers/staging/comedi/drivers/das800.c
> > +++ b/drivers/staging/comedi/drivers/das800.c
> > @@ -668,7 +668,7 @@ static int das800_attach(struct comedi_device *dev, struct comedi_devconfig *it)
> >       dev->board_name = board->name;
> >
> >       if (irq > 1 && irq <= 7) {
> > -             ret = request_irq(irq, das800_interrupt, 0, dev->board_name,
> > +             ret = request_irq(irq, das800_interrupt, 0, "das800",
> >                                 dev);
> >               if (ret == 0)
> >                       dev->irq = irq;
> >
>
> Looks good (apart from the minor spelling niggle spotted by Dan
> Carpenter), thanks!
>
> Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
>
> --
> -=( Ian Abbott <abbotti@mev.co.uk> || MEV Ltd. is a company  )=-
> -=( registered in England & Wales.  Regd. number: 02862268.  )=-
> -=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
> -=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-

  parent reply	other threads:[~2021-03-19  3:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-14  3:57 [PATCH] staging: comedi: replace slash in name Tong Zhang
2021-03-15 10:44 ` Ian Abbott
2021-03-15 10:48   ` Ian Abbott
2021-03-15 19:58     ` [PATCH v2] staging: comedi: cb_pcidas64: fix request_irq() warn Tong Zhang
2021-03-16 10:31       ` Ian Abbott
2021-03-15 20:00     ` [PATCH] staging: comedi: replace slash in name Tong Zhang
2021-03-16 10:37       ` Ian Abbott
2021-03-16 22:42         ` [PATCH] staging: comedi: das800: fix request_irq() warn Tong Zhang
2021-03-17  5:14           ` Dan Carpenter
     [not found]             ` <CAA5qM4BcQ6+aa1C3_28zLVojwLduK-WZwsEftuasJgo8z0t0ew@mail.gmail.com>
2021-03-17  6:52               ` Dan Carpenter
2021-03-17 22:43                 ` Tong Zhang
2021-03-17 12:48           ` Ian Abbott
2021-03-19  3:47             ` [PATCH v2] " Tong Zhang
2021-03-19  3:48             ` Tong Zhang [this message]
2021-03-16 22:42         ` [PATCH] staging: comedi: replace slash in name Tong Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA5qM4BvHNT9YboUnKXwQcqHVBMSiAXS16Y9ogLk+pHCk+O4FA@mail.gmail.com \
    --to=ztong0001@gmail.com \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=grandmaster@al2klimov.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).