From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A2E5C4332F for ; Fri, 11 Feb 2022 02:12:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347169AbiBKCMD (ORCPT ); Thu, 10 Feb 2022 21:12:03 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:33724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242403AbiBKCMB (ORCPT ); Thu, 10 Feb 2022 21:12:01 -0500 Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18A4D5FAE for ; Thu, 10 Feb 2022 18:12:01 -0800 (PST) Received: by mail-qt1-x830.google.com with SMTP id l14so7583752qtp.7 for ; Thu, 10 Feb 2022 18:12:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=06aBiVvbhWkfXru/N9K7na0D6XrgIVuslgTLZxvkDek=; b=WIcP552qomNEjdcOHaTSCGKmebrYHEM6VQ3xlCShI8mAoL9/+yUJ4p6Qa2rPVKvpP6 XBPO1lzNE69XEFzLhdauJbuaQ/V+IzD49npN6nQh1i0bO1tdr0KM9eZ8xJJXGlaWzi6q Pve7GDkdE8luCalDrM/R3j+1rkDOyQHcXHCxw414yuTrDFnuRabFOeRExMPZL2zOB3t3 JqQ2/8sd5USAJz7DEUqHuzQ3928MUlLqR7O0EcVsaqxu/rASzGBpb8kthUBAEmUlkcCk wjU19iPeylMGo0RYEmGkkuY5rFfc7r3Dpff+K8Uqb/PCUjy4wMm4+L93QWT6Dc1R7ntf WlnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=06aBiVvbhWkfXru/N9K7na0D6XrgIVuslgTLZxvkDek=; b=0MVpo3vfIGeJSKINlMDR1NhZVKljR5AJcpD7g3eqUHx1cuHhbN64OsC+9ERN+E4dFi 2Hc0lIIx1itFli4KcQWnVs2CsOy/zdv3mR1UMREion9CyDAQqPd7NDnx174lKTLxqzle 2B80z+m0YVVE8rDToJEuRgevSD3r/Y4MY8QGOps1OCwGmYjeh/j/LehsKIN6+3euljKv cyL/6JwahbIvVKWVzdalSjU4Bhvm+VEfNWuKWq1LZdkvhoXPwleZyoxvQN8JdPgankM9 BdHEsGzsQKKWcIKgNTSFI76WAvt4ZXqEjzziybOhJsyoDBQrGic5hmcmoXbKFp6F1ett 9x9w== X-Gm-Message-State: AOAM530n5FmN2Kpxl8IploW+VZbly0Rc/M8eli8XIM9Vml9DbMOj/dKa ZztGzosIW2UmZK/NZzSpx2yTy6LXb8qqZFI0ZiOHag== X-Google-Smtp-Source: ABdhPJwK7HH5Z3aPWfCQnRO7fXOlintpSX7+Wo3G/7vTfUrJgjQl/zb43Or4bBKvloZZ6EymgcbVxJMJZKXipywum74= X-Received: by 2002:a05:622a:4d:: with SMTP id y13mr7092687qtw.629.1644545520212; Thu, 10 Feb 2022 18:12:00 -0800 (PST) MIME-Version: 1.0 References: <20220210224933.379149-1-yury.norov@gmail.com> <20220210224933.379149-9-yury.norov@gmail.com> In-Reply-To: <20220210224933.379149-9-yury.norov@gmail.com> From: Dmitry Baryshkov Date: Fri, 11 Feb 2022 05:11:45 +0300 Message-ID: Subject: Re: [PATCH 08/49] drm: replace bitmap_weight with bitmap_empty where appropriate To: Yury Norov Cc: Andy Shevchenko , Rasmus Villemoes , Andrew Morton , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Greg Kroah-Hartman , Peter Zijlstra , David Laight , Joe Perches , Dennis Zhou , Emil Renner Berthing , Nicholas Piggin , Matti Vaittinen , Alexey Klimov , linux-kernel@vger.kernel.org, Rob Clark , Sean Paul , Abhinav Kumar , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 11 Feb 2022 at 02:09, Yury Norov wrote: > > smp_request_block() in drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c calls > bitmap_weight() to check if any bit of a given bitmap is set. It's > better to use bitmap_empty() in that case because bitmap_empty() stops > traversing the bitmap as soon as it finds first set bit, while > bitmap_weight() counts all bits unconditionally. > > Signed-off-by: Yury Norov > --- > drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c > index d7fa2c49e741..56a3063545ec 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c > @@ -68,7 +68,7 @@ static int smp_request_block(struct mdp5_smp *smp, > uint8_t reserved; > > /* we shouldn't be requesting blocks for an in-use client: */ > - WARN_ON(bitmap_weight(cs, cnt) > 0); > + WARN_ON(!bitmap_empty(cs, cnt)); Reviewed-by: Dmitry Baryshkov > > reserved = smp->reserved[cid]; > > -- > 2.32.0 > -- With best wishes Dmitry